* feat(#3907): gates report no-input instead of asserting a verdict they never reached The three stdin-reading gates bound 2 to a stdin read error only, with no arm for stdin closed at zero bytes - so empty input flowed into the detector, found nothing, and exited 1, which each module's own comment defines as a negative verdict. An unset PHASE_SECTION made the UI gate assert the phase has no UI. Empty and whitespace-only input now exit NO_INPUT, and a read error exits UNAVAILABLE rather than a locally-invented 2, both resolved through the registry and delivered by terminateNow. The exit code was only half of it: under --json the same input emitted {detected:false}, byte-identical to the fabricated payload #3909 exists to fix, and the blocking coverage gate reads that payload. Empty input now emits the in-tree {skipped:true,reason} form with no detected key at all. teams-status is excluded: it never reads stdin and has no invented 2, so the four-module framing in the issue and ADR is wrong. The dead root bin/lib/ui-safety-gate.cjs is deleted - no installer reference, no workflow invocation, and the live fallback chains are for other modules. Its removal restores the unit tests to the module that actually ships; they had been asserting the stale copy's two-field shape, which is why it drifted unnoticed. * fix(#3907): drive gate tests through the process seam, and make removed-but-needed basename-precise CONTRIBUTING requires every subprocess go through tests/helpers/process-seam.cjs; two of the three gate suites hand-rolled spawnSync while the third, added in the same change, used runNode correctly for the identical injection case. Converted the blocks this change added, leaving pre-existing ones alone. Deleting one of two files sharing a basename made lint-removed-but-needed report 14 references that were all to the surviving canonical module - the false-positive class its own docstring names. It now matches on the deleted file's full path when a surviving file shares its basename, which is more precise rather than weaker: a genuine full-path reference still fails, and behaviour is unchanged when no basename collides. It immediately caught a docstring on this branch that spelled the deleted path. * test(#3907): update the one existing assertion that pinned the old empty-stdin verdict A pre-existing test asserted exit 1 on empty stdin - the defect this phase removes - and was missed because the change added new blocks without auditing existing ones pinning the old contract. Audited the rest: the other three status-1 assertions in that file all feed real input and are the genuine-negative controls that must keep returning 1, so exactly one was stale. The retired 2 is gone from the describe's contract comment too. * chore(#3907): backfill changeset pr number --------- Co-authored-by: sim <sim@local>
This commit is contained in:
@@ -1,6 +1,6 @@
|
||||
/**
|
||||
* UI Safety Gate — shell-free implementation (ADR-457 build-at-publish: the
|
||||
* hand-written bin/lib/ui-safety-gate.cjs collapsed to a TypeScript source of
|
||||
* hand-written root copy of this file collapsed to a TypeScript source of
|
||||
* truth). Behaviour is preserved byte-for-behaviour from the prior hand-written
|
||||
* .cjs; only types are added.
|
||||
*
|
||||
@@ -21,13 +21,17 @@
|
||||
*
|
||||
* CLI usage — reads phase-section text from STDIN to avoid ARG_MAX limits:
|
||||
* echo "$PHASE_SECTION" | node gsd-core/bin/lib/ui-safety-gate.cjs
|
||||
* echo $? → 0 if UI tokens found, 1 if not, 2 on usage error
|
||||
* echo $? → 0 if UI tokens found, 1 if not (real input, none found),
|
||||
* NO_INPUT (registry, src/cli-exit.cts) if stdin was empty or
|
||||
* whitespace-only, UNAVAILABLE (registry) if stdin read failed
|
||||
* (ADR-3889 Phase 3, #3907)
|
||||
*
|
||||
* Exit codes mirror grep: 0 = match found, 1 = no match, 2 = usage error.
|
||||
*
|
||||
* Canonical location: gsd-core/bin/lib/ui-safety-gate.cjs (#448)
|
||||
* This path is deployed by the GSD installer to $RUNTIME_DIR/gsd-core/bin/lib/.
|
||||
* bin/lib/ui-safety-gate.cjs (root) is retained for source-repo and npm usage.
|
||||
* The former root-level copy of this file (outside gsd-core/) was removed in
|
||||
* #3907 as dead code: no installer reference, no workflow invocation, and no
|
||||
* fallback chain in shipped content ever pointed at it. Do not re-create it.
|
||||
*/
|
||||
|
||||
export interface UiPresenceResult {
|
||||
@@ -134,9 +138,29 @@ export function checkUiPresence(text: string): UiPresenceResult {
|
||||
// ── CLI entry point ─────────────────────────────────────────────────────────
|
||||
// Reads phase-section text from STDIN (not argv) to avoid OS ARG_MAX limits.
|
||||
// Invoked by workflow .md bash blocks as: echo "$PHASE_SECTION" | node .../ui-safety-gate.cjs
|
||||
// Exit 0 = UI found, 1 = no UI, 2 = startup error.
|
||||
//
|
||||
// Exit codes (ADR-3889 Phase 3, #3907): 0 = UI found, 1 = no UI (real input,
|
||||
// examined, nothing found), NO_INPUT (registry — see src/cli-exit.cts) = stdin
|
||||
// closed with zero bytes (or whitespace-only), UNAVAILABLE (registry) = stdin
|
||||
// read failed. The prior single "2 = startup error" arm conflated "I was
|
||||
// handed nothing" with "the phase says it has no UI" — those are different
|
||||
// answers; only the former is new here. `hint === 'no'` on REAL input still
|
||||
// exits 1 — that is the author's own declaration, not an empty-input
|
||||
// artifact.
|
||||
//
|
||||
// Terminates via terminateNow (src/cli-exit.cts), not raw process.exit: these
|
||||
// exits fire from inside a stdin event handler, which is exactly what
|
||||
// terminateNow (write-then-terminate) exists for, and it is total (cannot
|
||||
// throw or return). This module never emits --json, so every payload here is
|
||||
// `undefined` — terminateNow's JSON.stringify(undefined) is not a valid
|
||||
// Buffer source and is swallowed by its own emission-failure guard, so
|
||||
// nothing is written to stdout, preserving this CLI's historical contract of
|
||||
// silence.
|
||||
|
||||
if (require.main === module) {
|
||||
// eslint-disable-next-line @typescript-eslint/no-require-imports
|
||||
const cliExit = require('./cli-exit.cjs') as { terminateNow: (outcome: string, payload: unknown) => never };
|
||||
|
||||
// Collect stdin chunks asynchronously.
|
||||
const chunks: string[] = [];
|
||||
process.stdin.setEncoding('utf-8');
|
||||
@@ -145,12 +169,19 @@ if (require.main === module) {
|
||||
|
||||
process.stdin.on('end', () => {
|
||||
const input = chunks.join('');
|
||||
// Whitespace-only counts as empty (ADR-3889 §1's NO_INPUT: "zero units
|
||||
// were in scope, and that emptiness is known to be genuine"). Real input
|
||||
// — including a lone NUL byte, which .trim() does not strip — always
|
||||
// falls through to the detector.
|
||||
if (input.trim().length === 0) {
|
||||
cliExit.terminateNow('NO_INPUT', undefined);
|
||||
}
|
||||
const result = checkUiPresence(input);
|
||||
process.exit(result.hasUI ? 0 : 1);
|
||||
cliExit.terminateNow(result.hasUI ? 'PASS' : 'FAIL', undefined);
|
||||
});
|
||||
|
||||
process.stdin.on('error', (err: Error) => {
|
||||
process.stderr.write(`ERROR: ui-safety-gate.cjs stdin read failed: ${err.message}\n`);
|
||||
process.exit(2);
|
||||
cliExit.terminateNow('UNAVAILABLE', undefined);
|
||||
});
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user