* test(#4658): add failing-first coverage for native frontend evidence hasStaticFrontendEvidence recognised only JS-ecosystem evidence, so computeUiPlanGate could never block for a SwiftUI/Compose/Flutter/XAML project. Adds evidence-level fixtures for the four suggested markers (import-matched for .swift/.kt/.dart, extension-alone for .xaml), the reporter's non-UI Swift control case, marker-exactness and SKIP_DIRS and I/O-degrade negatives, gate-level block assertions through makeProject's new native frontendEvidence modes, and a pinned-seed fast-check property. All new assertions are RED until src/ui-frontend-evidence.cts grows the native branch. * fix(#4658): give the ui plan gate's evidence check a native branch hasStaticFrontendEvidence recognised only JS-ecosystem evidence (a root package.json UI-framework dep, or a .tsx/.jsx/.vue/.svelte file), so computeUiPlanGate could never block for a SwiftUI, Jetpack Compose, Flutter, or .NET MAUI project — the #3312 gate was structurally unreachable for them. Adds a native BFS over the same bounds and skip rules: .xaml is evidence by extension alone (the .tsx analogue), while .swift/.kt/.dart count only when their content carries the ecosystem's UI import marker (import SwiftUI / import UIKit, androidx.compose, package:flutter) — matched on the import, not the extension, so a non-UI Swift package stays silent exactly as the issue's 37-file control case requires. Marker reads are bounded to a 64 KiB prefix; any I/O failure degrades to false per the module contract. The #3718 vocabulary filter, the JS evidence rules, and the weaker-extension exclusion are untouched. * chore(#4658): regenerate the macos conformance tier list The native-evidence additions to tests/check-ui-plan-gate.test.cjs move the file into the macOS conformance tier per the classifier; the committed generated list is a derived artifact and must match the live tests/ tree (the same sync the fragment-single-edit-propagation install test enforces). * fix(#4658): accept both Dart quote styles and extract the shared bounded walk The isolated reviews' remaining findings: the Dart marker carried only the single-quote anchor, missing legal double-quoted imports (a spec-narrowing deviation); the two evidence walks duplicated the subtle MAX_WALK_ENTRIES cap semantics verbatim, so they are extracted into one walkProjectFiles BFS with a visit callback; tests now use the createTempDir helper, shared fixture literals that cannot drift from NATIVE_UI_CONTENT_MARKERS, a double-quoted Flutter import case, and drop a vacuous assertion and a mid-body re-require alias. * docs(#4658): backfill changeset PR number --------- Co-authored-by: sim <sim@local>
This commit is contained in:
@@ -569,8 +569,10 @@ function findUiSpecInDir(phaseDir: string): string {
|
||||
* matches the token `dashboard` exactly like the real compound `micro-frontend`
|
||||
* (the boundary rule of #3718 is intentional and untouched). The gate therefore
|
||||
* blocks only when the token match is corroborated by static frontend evidence
|
||||
* in the repo tree (hasStaticFrontendEvidence: package.json UI-framework dep or
|
||||
* a component-framework file). This mirrors the sibling post-wave gate
|
||||
* in the repo tree (hasStaticFrontendEvidence: package.json UI-framework dep, a
|
||||
* component-framework file, or native UI evidence — a `.xaml` file or a
|
||||
* `.swift`/`.kt`/`.dart` file carrying its ecosystem's UI import marker,
|
||||
* #4658). This mirrors the sibling post-wave gate
|
||||
* computeUiSafetyGate, which requires `hasUiFiles` (git diff) before blocking.
|
||||
* matchedToken/matchedLine surface what tripped the sniffer so an operator can
|
||||
* judge the flag in one second instead of reaching for --skip-ui.
|
||||
|
||||
@@ -22,6 +22,19 @@
|
||||
* html, ...) are deliberately NOT static evidence: docs sites and
|
||||
* markdown/bash/config repos routinely carry stray `.html`/`.css`, which
|
||||
* is precisely the false-positive class #3312 reports.
|
||||
* (c) any `*.xaml` file, or a `*.swift` / `*.kt` / `*.dart` file whose
|
||||
* content carries its ecosystem's UI-framework import marker
|
||||
* (`import SwiftUI` / `import UIKit`, `androidx.compose`,
|
||||
* `package:flutter`) (#4658). Native UI projects (SwiftUI, Jetpack
|
||||
* Compose, Flutter, .NET MAUI) carry neither (a) nor (b), which made the
|
||||
* gate structurally unreachable for them. Source files match on the
|
||||
* IMPORT, not the extension alone — the same unambiguity bar that
|
||||
* justifies (b)'s subset and excludes (css, scss, html): a non-UI Swift
|
||||
* package (a CLI, a server) imports Foundation, not SwiftUI, and must
|
||||
* stay silent. `.xaml` is extension-alone for the same reason `.tsx` is —
|
||||
* the extension itself is unambiguous. Marker matching is case-sensitive
|
||||
* (imports are case-sensitive in all four ecosystems); extension
|
||||
* matching is case-insensitive, mirroring `UI_COMPONENT_FILE_RE`.
|
||||
*
|
||||
* All I/O failures degrade to `false` (no evidence) — never throw.
|
||||
*/
|
||||
@@ -32,6 +45,25 @@ import path from 'node:path';
|
||||
/** Component-framework file extensions — the static-evidence subset of UI_FILE_EXTENSIONS_RE. */
|
||||
export const UI_COMPONENT_FILE_RE = /\.(tsx|jsx|vue|svelte)$/i;
|
||||
|
||||
/** Native UI source files whose CONTENT is scanned for an import marker (#4658). */
|
||||
export const NATIVE_UI_SOURCE_RE = /\.(swift|kt|dart)$/i;
|
||||
|
||||
/** Native UI files that are evidence by extension alone — `.xaml`, the `.tsx` analogue. */
|
||||
export const NATIVE_UI_XAML_RE = /\.xaml$/i;
|
||||
|
||||
/**
|
||||
* Per-extension UI-framework import markers for `NATIVE_UI_SOURCE_RE` files
|
||||
* (#4658). Every marker embeds its ecosystem's import keyword, so a bare
|
||||
* framework-name mention in prose or a comment is not evidence; the Dart
|
||||
* marker carries both legal quote styles. Case-sensitive: imports are
|
||||
* case-sensitive in Swift, Kotlin and Dart.
|
||||
*/
|
||||
export const NATIVE_UI_CONTENT_MARKERS: Readonly<Record<string, readonly string[]>> = {
|
||||
'.swift': ['import SwiftUI', 'import UIKit'],
|
||||
'.kt': ['import androidx.compose'],
|
||||
'.dart': ["import 'package:flutter", 'import "package:flutter'],
|
||||
};
|
||||
|
||||
/**
|
||||
* UI-framework package.json dependencies (dependencies OR devDependencies).
|
||||
* Component frameworks/renderers only — deliberately excludes meta tooling
|
||||
@@ -106,9 +138,19 @@ function packageJsonHasUiFramework(projectDir: string): boolean {
|
||||
return false;
|
||||
}
|
||||
|
||||
function treeHasComponentFile(projectDir: string): boolean {
|
||||
// Iterative BFS — bounded by MAX_WALK_ENTRIES so a pathological tree cannot
|
||||
// stall the gate. Symlinks are never followed (withFileTypes + isDirectory).
|
||||
/**
|
||||
* Shared bounded BFS over the project tree — the single home of the walk
|
||||
* semantics both evidence walks depend on: SKIP_DIRS pruning, the
|
||||
* MAX_WALK_ENTRIES entry cap (cap-hit → `false`: the tree is treated as
|
||||
* scanned and evidence stays undecided), symlinks never followed
|
||||
* (withFileTypes Dirents), unreadable directories skipped. `visit` is called
|
||||
* for every regular file with its name and full path; returning `true` stops
|
||||
* the walk with `true` (evidence found).
|
||||
*/
|
||||
function walkProjectFiles(
|
||||
projectDir: string,
|
||||
visit: (name: string, fullPath: string) => boolean,
|
||||
): boolean {
|
||||
const queue: string[] = [projectDir];
|
||||
let visited = 0;
|
||||
while (queue.length > 0 && visited < MAX_WALK_ENTRIES) {
|
||||
@@ -124,7 +166,7 @@ function treeHasComponentFile(projectDir: string): boolean {
|
||||
if (visited >= MAX_WALK_ENTRIES) return false;
|
||||
if (entry.isDirectory()) {
|
||||
if (!SKIP_DIRS.has(entry.name)) queue.push(path.join(dir, entry.name));
|
||||
} else if (entry.isFile() && UI_COMPONENT_FILE_RE.test(entry.name)) {
|
||||
} else if (entry.isFile() && visit(entry.name, path.join(dir, entry.name))) {
|
||||
return true;
|
||||
}
|
||||
}
|
||||
@@ -132,16 +174,68 @@ function treeHasComponentFile(projectDir: string): boolean {
|
||||
return false;
|
||||
}
|
||||
|
||||
function treeHasComponentFile(projectDir: string): boolean {
|
||||
return walkProjectFiles(projectDir, (name) => UI_COMPONENT_FILE_RE.test(name));
|
||||
}
|
||||
|
||||
/**
|
||||
* Read at most the first 64 KiB of `file` and report whether any of `markers`
|
||||
* occurs in it (#4658). Import sections live at the top of a source file, so a
|
||||
* bounded prefix read keeps the gate's plan-time cost profile without reading
|
||||
* generated monsters in full. Any I/O failure degrades to false — never throw.
|
||||
*/
|
||||
function fileHasAnyMarker(file: string, markers: readonly string[]): boolean {
|
||||
let fd: number;
|
||||
try {
|
||||
fd = fs.openSync(file, 'r');
|
||||
} catch {
|
||||
return false;
|
||||
}
|
||||
try {
|
||||
const bytes = Buffer.alloc(64 * 1024);
|
||||
const read = fs.readSync(fd, bytes, 0, bytes.length, 0);
|
||||
const prefix = bytes.toString('utf8', 0, read);
|
||||
return markers.some((m) => prefix.includes(m));
|
||||
} catch {
|
||||
return false;
|
||||
} finally {
|
||||
try {
|
||||
fs.closeSync(fd);
|
||||
} catch {
|
||||
// already closed — nothing to degrade
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Native-UI walk over the shared bounded BFS (#4658): `.xaml` is evidence by
|
||||
* extension alone; `.swift`/`.kt`/`.dart` are evidence only when the file's
|
||||
* content carries its ecosystem's import marker.
|
||||
*/
|
||||
function treeHasNativeUiFile(projectDir: string): boolean {
|
||||
return walkProjectFiles(projectDir, (name, fullPath) => {
|
||||
if (NATIVE_UI_XAML_RE.test(name)) return true;
|
||||
if (NATIVE_UI_SOURCE_RE.test(name)) {
|
||||
const markers = NATIVE_UI_CONTENT_MARKERS[path.extname(name).toLowerCase()];
|
||||
return markers != null && fileHasAnyMarker(fullPath, markers);
|
||||
}
|
||||
return false;
|
||||
});
|
||||
}
|
||||
|
||||
/**
|
||||
* Does the project tree carry static evidence of a frontend?
|
||||
*
|
||||
* @param projectDir - Absolute path to the project root (the gate's cwd).
|
||||
* @returns true when package.json declares a UI-framework dependency or the
|
||||
* tree contains a component-framework file; false otherwise (including
|
||||
* on any I/O failure — evidence must be affirmative).
|
||||
* @returns true when package.json declares a UI-framework dependency, the tree
|
||||
* contains a component-framework file, or the tree contains native UI
|
||||
* evidence (a `.xaml` file, or a `.swift`/`.kt`/`.dart` file carrying
|
||||
* its ecosystem's UI import marker — #4658); false otherwise
|
||||
* (including on any I/O failure — evidence must be affirmative).
|
||||
*/
|
||||
export function hasStaticFrontendEvidence(projectDir: string): boolean {
|
||||
if (typeof projectDir !== 'string' || projectDir === '') return false;
|
||||
if (packageJsonHasUiFramework(projectDir)) return true;
|
||||
return treeHasComponentFile(projectDir);
|
||||
if (treeHasComponentFile(projectDir)) return true;
|
||||
return treeHasNativeUiFile(projectDir);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user