refactor(#1291): T6 — migrate test files off the core spine ahead of deletion (#1293)

The convergence lint only scanned src/ + gsd-core/bin, so ~35 test files
still imported core.cjs. Repoint all 33 behaviour importers to the leaf
modules directly (same symbol->leaf map as the src migration; leaves are the
objects core re-exported by reference), delete the now-meaningless
shim-identity describe blocks in the 8 leaf tests, and delete tests/core.test.cjs
(forwarded-behaviour coverage now lives at the leaves; resolveWorktreeRoot
test relocated to worktree-safety in T0) and tests/lint-core-spine-imports.test.cjs
(the lint is removed in T-final). Dropped the stale core.test.cjs entries from
the allow-test-rule-refs allowlist; eslint-rules RuleTester fixture path
pointed at io.cjs.

After T6: ZERO test imports core.cjs. core.cts still builds (now fully unused);
T-final deletes it. No behaviour change.

Closes #1291

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Tom Boucher
2026-06-15 18:11:20 -04:00
committed by GitHub
parent 76765bc24d
commit c76827afbc
36 changed files with 51 additions and 2650 deletions

View File

@@ -19,7 +19,6 @@ const os = require('node:os');
const fs = require('node:fs');
const io = require('../gsd-core/bin/lib/io.cjs');
const core = require('../gsd-core/bin/lib/core.cjs');
// ─── ERROR_REASON constants ───────────────────────────────────────────────────
@@ -308,37 +307,6 @@ describe('reapStaleTempFiles (via io)', () => {
});
});
// ─── core.cjs re-export shim parity ──────────────────────────────────────────
describe('core.cjs re-export shims', () => {
test('core.output is the same function as io.output', () => {
assert.strictEqual(core.output, io.output);
});
test('core.error is the same function as io.error', () => {
assert.strictEqual(core.error, io.error);
});
test('core.ERROR_REASON is the same object as io.ERROR_REASON', () => {
assert.strictEqual(core.ERROR_REASON, io.ERROR_REASON);
});
test('core.setJsonErrorMode is the same function as io.setJsonErrorMode', () => {
assert.strictEqual(core.setJsonErrorMode, io.setJsonErrorMode);
});
test('core.getJsonErrorMode is the same function as io.getJsonErrorMode', () => {
assert.strictEqual(core.getJsonErrorMode, io.getJsonErrorMode);
});
test('core.reapStaleTempFiles is the same function as io.reapStaleTempFiles', () => {
assert.strictEqual(core.reapStaleTempFiles, io.reapStaleTempFiles);
});
test('core.GSD_TEMP_DIR is the same value as io.GSD_TEMP_DIR', () => {
assert.strictEqual(core.GSD_TEMP_DIR, io.GSD_TEMP_DIR);
});
});
// ─── bug #1008: output()/error() tolerate a full / slow non-blocking pipe ─────
//