golem15/msd-core
4
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(#1291): T6 — migrate test files off the core spine ahead of deletion (#1293)

Browse Source 
The convergence lint only scanned src/ + gsd-core/bin, so ~35 test files
still imported core.cjs. Repoint all 33 behaviour importers to the leaf
modules directly (same symbol->leaf map as the src migration; leaves are the
objects core re-exported by reference), delete the now-meaningless
shim-identity describe blocks in the 8 leaf tests, and delete tests/core.test.cjs
(forwarded-behaviour coverage now lives at the leaves; resolveWorktreeRoot
test relocated to worktree-safety in T0) and tests/lint-core-spine-imports.test.cjs
(the lint is removed in T-final). Dropped the stale core.test.cjs entries from
the allow-test-rule-refs allowlist; eslint-rules RuleTester fixture path
pointed at io.cjs.

After T6: ZERO test imports core.cjs. core.cts still builds (now fully unused);
T-final deletes it. No behaviour change.

Closes #1291

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Tom Boucher
2026-06-15 18:11:20 -04:00
committed by GitHub
parent 76765bc24d
commit c76827afbc
36 changed files with 51 additions and 2650 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tests/temp-subdir.test.cjs
View File

@@ -14,7 +14,7 @@ const os = require('os');
const {
reapStaleTempFiles,
} = require('../gsd-core/bin/lib/core.cjs');
} = require('../gsd-core/bin/lib/io.cjs');
const GSD_TEMP_DIR = path.join(os.tmpdir(), 'gsd');
@@ -121,14 +121,14 @@ describe('dedicated gsd temp subdirectory', () => {
// The legacy reap function should still clean old-location files
// We import it if exported, or verify the main reap handles both
const core = require('../gsd-core/bin/lib/core.cjs');
if (typeof core.reapStaleTempFilesLegacy === 'function') {
core.reapStaleTempFilesLegacy(testPrefix, { maxAgeMs: 5 * 60 * 1000 });
const ioModule = require('../gsd-core/bin/lib/io.cjs');
if (typeof ioModule.reapStaleTempFilesLegacy === 'function') {
ioModule.reapStaleTempFilesLegacy(testPrefix, { maxAgeMs: 5 * 60 * 1000 });
assert.ok(!fs.existsSync(oldLocationPath), 'legacy reap should clean old location');
} else {
// If no separate legacy function, the main output() should do a one-time
// migration sweep. We just verify the export shape is correct.
assert.ok(typeof core.reapStaleTempFiles === 'function');
assert.ok(typeof ioModule.reapStaleTempFiles === 'function');
// Clean up manually since we're not testing migration here
fs.unlinkSync(oldLocationPath);
}