feat(#985): intel command cutover — commands-only capability, last first-party family (ADR-857 phase 4d-impl-4) (#988)
* feat(#985): intel command cutover — commands-only capability, last first-party family (ADR-857 phase 4d-impl-4) Migrate the intel CLI command family from a hardcoded gsd-tools.cjs case arm to a registry-dispatched Capability (commandFamilies mechanism, #961), mirroring the graphify (#972) and audit (#984) cutovers. New src/intel-command-router.cts exports routeIntelCommand reproducing all 9 subcommands verbatim (incl. the status timeAgo non-raw post-processing), lazily requiring intel.cjs inside the route fn. capabilities/intel/capability.json declares the intel command family; commands-only (skills:[]), declares the existing intel.enabled gate (default false — behavior unchanged). Behavior-CHANGING (dispatch path) but equivalence-proven: CLI output identical; existing intel.test.cjs passes unchanged. Completes the first-party command- family cutover sequence (graphify/audit/intel). Closes #985 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * test(#985): compute expected planningDir via path.join in intel cutover unit tests (Windows CI) The intel-command-cutover unit-mock assertions hardcoded a POSIX `/.planning` expectation while the router builds it with path.join(cwd, '.planning') → backslashes on Windows, so the planningDir-arg assertions (query/status/diff/ snapshot/validate/update/api-surface) failed only on windows-latest CI. Compute the expectation with path.join (cross-platform); production router unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
147
src/intel-command-router.cts
Normal file
147
src/intel-command-router.cts
Normal file
@@ -0,0 +1,147 @@
|
||||
'use strict';
|
||||
/**
|
||||
* Intel command router — CLI subcommand dispatcher for `gsd-tools intel`.
|
||||
*
|
||||
* ADR-959 (phase 4d-impl-4): intel command family cutover — last first-party
|
||||
* command cutover in the initial capability rollout.
|
||||
* Extracted from the hardcoded `case 'intel':` arm in gsd-tools.cjs.
|
||||
* Behaviour is preserved byte-for-behaviour from the prior inline case;
|
||||
* the dispatch path now flows: default → dispatchCapabilityCommand →
|
||||
* require(intel-command-router.cjs) → routeIntelCommand.
|
||||
*
|
||||
* Router signature: { args, cwd, raw, error } — identical to the existing
|
||||
* host routers. No new handler/arg convention; the capability registry
|
||||
* discovers this router by name.
|
||||
*
|
||||
* Arg indexing (preserved exactly from the original case):
|
||||
* args[0] = 'intel' (family — matched by dispatchCapabilityCommand)
|
||||
* args[1] = subcommand (query | status | diff | snapshot | patch-meta |
|
||||
* validate | extract-exports | update | api-surface)
|
||||
* args[2] = term (query) | filePath (patch-meta | extract-exports)
|
||||
*
|
||||
* Notable: the `status` subcommand applies a `timeAgo` transform on
|
||||
* `status.files[*].updated_at` in non-raw mode — preserved exactly.
|
||||
*
|
||||
* Test seams: pass `_intel` to inject a mock intel module; pass `_core` to
|
||||
* inject a mock core module (captures `output` calls and provides a
|
||||
* deterministic `timeAgo` without writing to real stdout). The `_`-prefix
|
||||
* follows the repo's established seam convention (see audit-command-router.cts
|
||||
* for the `_core` seam pattern). Production callers omit both.
|
||||
*
|
||||
* Note on `error(); return` pairs: in production `error()` calls
|
||||
* `process.exit(1)` so the `return` is an equivalent no-op halt. The pairs
|
||||
* are kept for lint/control-flow clarity; they do NOT change behaviour.
|
||||
*
|
||||
* Lazy require: intel.cjs is required INSIDE the route function so it is
|
||||
* only loaded when an intel command is actually dispatched (preserves
|
||||
* equivalence with the old inline case arm which required it at the top of
|
||||
* the case block).
|
||||
*/
|
||||
|
||||
// eslint-disable-next-line @typescript-eslint/no-require-imports
|
||||
import core = require('./core.cjs');
|
||||
// eslint-disable-next-line @typescript-eslint/no-require-imports
|
||||
import io = require('./io.cjs');
|
||||
// eslint-disable-next-line @typescript-eslint/no-require-imports
|
||||
import path = require('path');
|
||||
|
||||
const { ERROR_REASON } = io;
|
||||
|
||||
// ─── Types ────────────────────────────────────────────────────────────────────
|
||||
|
||||
interface IntelModule {
|
||||
intelQuery(term: string, planningDir: string): unknown;
|
||||
intelStatus(planningDir: string): { files?: Record<string, { updated_at?: string }> };
|
||||
intelDiff(planningDir: string): unknown;
|
||||
intelSnapshot(planningDir: string): unknown;
|
||||
intelValidate(planningDir: string): unknown;
|
||||
intelUpdate(planningDir: string): unknown;
|
||||
intelApiSurface(planningDir: string): unknown;
|
||||
intelPatchMeta(filePath: string): unknown;
|
||||
intelExtractExports(filePath: string): unknown;
|
||||
}
|
||||
|
||||
interface CoreModule {
|
||||
output(value: unknown, raw: boolean): void;
|
||||
timeAgo(date: Date): string;
|
||||
}
|
||||
|
||||
interface RouteIntelCommandOptions {
|
||||
args: string[];
|
||||
cwd: string;
|
||||
raw: boolean;
|
||||
error: (message: string, reason?: string) => void;
|
||||
/** Test seam: inject a mock intel module. Defaults to the real module. */
|
||||
_intel?: IntelModule;
|
||||
/** Test seam: inject a mock core module to capture output calls and provide
|
||||
* a deterministic timeAgo. Defaults to the real module. */
|
||||
_core?: CoreModule;
|
||||
}
|
||||
|
||||
// ─── Implementation ───────────────────────────────────────────────────────────
|
||||
|
||||
function routeIntelCommand({ args, cwd, raw, error, _intel, _core }: RouteIntelCommandOptions): void {
|
||||
// eslint-disable-next-line @typescript-eslint/no-require-imports, @typescript-eslint/no-unsafe-assignment
|
||||
const intel: IntelModule = _intel ?? require('./intel.cjs');
|
||||
const c: CoreModule = _core ?? core;
|
||||
const subcommand = args[1];
|
||||
|
||||
if (subcommand === 'query') {
|
||||
const term = args[2];
|
||||
if (!term) {
|
||||
error('Usage: gsd-tools intel query <term>', ERROR_REASON.USAGE);
|
||||
return;
|
||||
}
|
||||
const planningDir = path.join(cwd, '.planning');
|
||||
c.output(intel.intelQuery(term, planningDir), raw);
|
||||
} else if (subcommand === 'status') {
|
||||
const planningDir = path.join(cwd, '.planning');
|
||||
const status = intel.intelStatus(planningDir);
|
||||
if (!raw && status.files) {
|
||||
for (const file of Object.values(status.files)) {
|
||||
if (file.updated_at) {
|
||||
file.updated_at = c.timeAgo(new Date(file.updated_at));
|
||||
}
|
||||
}
|
||||
}
|
||||
c.output(status, raw);
|
||||
} else if (subcommand === 'diff') {
|
||||
const planningDir = path.join(cwd, '.planning');
|
||||
c.output(intel.intelDiff(planningDir), raw);
|
||||
} else if (subcommand === 'snapshot') {
|
||||
const planningDir = path.join(cwd, '.planning');
|
||||
c.output(intel.intelSnapshot(planningDir), raw);
|
||||
} else if (subcommand === 'patch-meta') {
|
||||
const filePath = args[2];
|
||||
if (!filePath) {
|
||||
error('Usage: gsd-tools intel patch-meta <file-path>', ERROR_REASON.USAGE);
|
||||
return;
|
||||
}
|
||||
c.output(intel.intelPatchMeta(path.resolve(cwd, filePath)), raw);
|
||||
} else if (subcommand === 'validate') {
|
||||
const planningDir = path.join(cwd, '.planning');
|
||||
c.output(intel.intelValidate(planningDir), raw);
|
||||
} else if (subcommand === 'extract-exports') {
|
||||
const filePath = args[2];
|
||||
if (!filePath) {
|
||||
error('Usage: gsd-tools intel extract-exports <file-path>', ERROR_REASON.USAGE);
|
||||
return;
|
||||
}
|
||||
c.output(intel.intelExtractExports(path.resolve(cwd, filePath)), raw);
|
||||
} else if (subcommand === 'update') {
|
||||
const planningDir = path.join(cwd, '.planning');
|
||||
c.output(intel.intelUpdate(planningDir), raw);
|
||||
} else if (subcommand === 'api-surface') {
|
||||
const planningDir = path.join(cwd, '.planning');
|
||||
c.output(intel.intelApiSurface(planningDir), raw);
|
||||
} else {
|
||||
error(
|
||||
'Unknown intel subcommand. Available: query, status, update, diff, snapshot, patch-meta, validate, extract-exports, api-surface',
|
||||
ERROR_REASON.SDK_UNKNOWN_COMMAND,
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
export = {
|
||||
routeIntelCommand,
|
||||
};
|
||||
Reference in New Issue
Block a user