From cb48b2b48f945ab22b8e26fc0d43238b49acd8cf Mon Sep 17 00:00:00 2001 From: Tom Boucher Date: Sun, 12 Jul 2026 11:13:48 -0400 Subject: [PATCH] test(#2133): drop no-op try/finally in runAgainst helper (review) --- ...fix-2133-fast-md-log-to-state-schema.test.cjs | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/tests/fix-2133-fast-md-log-to-state-schema.test.cjs b/tests/fix-2133-fast-md-log-to-state-schema.test.cjs index 6a9fea60f..8445bd42b 100644 --- a/tests/fix-2133-fast-md-log-to-state-schema.test.cjs +++ b/tests/fix-2133-fast-md-log-to-state-schema.test.cjs @@ -93,16 +93,12 @@ describe('#2133 fast.md log_to_state schema gate', () => { const tmpDir = createTempProject('fix-2133-'); const statePath = path.join(tmpDir, '.planning', 'STATE.md'); fs.writeFileSync(statePath, makeStateMd(headerLine, separatorLine, existingRows)); - let stdout = ''; - try { - stdout = execFileSync('bash', ['-c', bashBlock], { - cwd: tmpDir, - env: { ...process.env, TASK: TASK_DESC }, - encoding: 'utf8', - }); - } finally { - // cleanup deferred to caller via t.after where bound - } + // Cleanup is bound by each caller via t.after(tmpDir). + const stdout = execFileSync('bash', ['-c', bashBlock], { + cwd: tmpDir, + env: { ...process.env, TASK: TASK_DESC }, + encoding: 'utf8', + }); const after = fs.readFileSync(statePath, 'utf8'); return { tmpDir, stdout, after }; }