golem15/msd-core
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(#4823): the Current Plan reset is scoped to the Current Position section (#4898)

Browse Source 
* test(#4823): failing-first — the Current Plan reset must not rewrite prose outside Current Position

* fix(#4823): the Current Plan reset is scoped to the Current Position section — the whole-body 'Plan' fallback matched hard-wrapped prose lines starting with plan:

* chore(#4823): changeset fragment

* chore(#4823): backfill changeset PR number (4898)

---------

Co-authored-by: sim <sim@local>
This commit is contained in:
Tom Boucher
2026-09-20 11:45:50 -04:00
committed by GitHub
parent bd79a97df0
commit ccfed63355
3 changed files with 89 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/state-transition.cts
View File

@@ -18,7 +18,7 @@
import frontmatter = require('./frontmatter.cjs');
import { stateReplaceField, stateExtractField, stateReplaceFieldIfTemplate, stateReplaceFieldWithFallback, stateReplaceFieldInSession, stateCurrentPositionSlice } from './state-document.cjs';
import { KNOWN_TEMPLATE_DEFAULTS, toFiniteNumber, computeProgressPercent } from './state-document.cjs';
import { tokenizeHeadings } from './markdown-sectionizer.cjs';
import { tokenizeHeadings, withSection } from './markdown-sectionizer.cjs';
import type { HeadingToken } from './markdown-sectionizer.cjs';
import { deriveProgressFromRoadmap, clampPercent, clampPercentFromFraction, renderProgressBar } from './phase-lifecycle.cjs';
import { escapeRegex } from './pattern.cjs';
@@ -2145,8 +2145,26 @@ function completePhaseCore(
updated.push('Status');
}
// Current Plan — reset for the next phase.
const planAfter = stateReplaceFieldWithFallback(body, 'Current Plan', 'Plan', 'Not started');
// Current Plan — reset for the next phase. #4823: when a Current Position
// section exists (the canonical layout, #2956 locator), the reset is scoped
// to it — the whole-body fallback 'Plan' run matched any hard-wrapped prose
// line starting with `plan:` anywhere in the document and rewrote it to
// 'Not started', silently destroying narrative. Legacy sectionless layouts
// (fields at top level, no section) keep the whole-body behavior unchanged:
// there is no section to scope to, and their fields are the intended
// targets.
let planAfter;
const positionScope = stateCurrentPositionSlice(body);
if (positionScope !== null) {
planAfter = withSection(
body,
(h) => (h.level === 2 || h.level === 3) && h.text.trim().toLowerCase() === 'current position',
(sectionBody) => stateReplaceFieldWithFallback(sectionBody, 'Current Plan', 'Plan', 'Not started'),
{ levelBounded: true },
);
} else {
planAfter = stateReplaceFieldWithFallback(body, 'Current Plan', 'Plan', 'Not started');
}
if (planAfter !== body) {
body = planAfter;
updated.push('Current Plan');