fix(orchestrators): inline file contents in Task prompts
The @ file reference syntax does not expand across Task() boundaries. Subagents receive literal @path strings instead of file contents. Changed orchestrator→subagent handoffs to explicitly read files and inline content before spawning: - plan-phase → gsd-planner: STATE, ROADMAP, REQUIREMENTS, CONTEXT, RESEARCH - plan-phase → gsd-plan-checker: PLAN files, REQUIREMENTS - plan-phase → gsd-planner (revision): PLAN files - execute-phase → gsd-executor: PLAN, STATE, config Fixes #182 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
@@ -230,12 +230,22 @@ After user runs /gsd:plan-phase {Z} --gaps:
|
|||||||
<wave_execution>
|
<wave_execution>
|
||||||
**Parallel spawning:**
|
**Parallel spawning:**
|
||||||
|
|
||||||
Spawn all plans in a wave with a single message containing multiple Task calls:
|
Before spawning, read file contents. The `@` syntax does not work across Task() boundaries.
|
||||||
|
|
||||||
|
```bash
|
||||||
|
# Read each plan and STATE.md
|
||||||
|
PLAN_01_CONTENT=$(cat "{plan_01_path}")
|
||||||
|
PLAN_02_CONTENT=$(cat "{plan_02_path}")
|
||||||
|
PLAN_03_CONTENT=$(cat "{plan_03_path}")
|
||||||
|
STATE_CONTENT=$(cat .planning/STATE.md)
|
||||||
|
```
|
||||||
|
|
||||||
|
Spawn all plans in a wave with a single message containing multiple Task calls, with inlined content:
|
||||||
|
|
||||||
```
|
```
|
||||||
Task(prompt="Execute plan at {plan_01_path}\n\nPlan: @{plan_01_path}\nProject state: @.planning/STATE.md", subagent_type="gsd-executor")
|
Task(prompt="Execute plan at {plan_01_path}\n\nPlan:\n{plan_01_content}\n\nProject state:\n{state_content}", subagent_type="gsd-executor")
|
||||||
Task(prompt="Execute plan at {plan_02_path}\n\nPlan: @{plan_02_path}\nProject state: @.planning/STATE.md", subagent_type="gsd-executor")
|
Task(prompt="Execute plan at {plan_02_path}\n\nPlan:\n{plan_02_content}\n\nProject state:\n{state_content}", subagent_type="gsd-executor")
|
||||||
Task(prompt="Execute plan at {plan_03_path}\n\nPlan: @{plan_03_path}\nProject state: @.planning/STATE.md", subagent_type="gsd-executor")
|
Task(prompt="Execute plan at {plan_03_path}\n\nPlan:\n{plan_03_content}\n\nProject state:\n{state_content}", subagent_type="gsd-executor")
|
||||||
```
|
```
|
||||||
|
|
||||||
All three run in parallel. Task tool blocks until all complete.
|
All three run in parallel. Task tool blocks until all complete.
|
||||||
|
|||||||
@@ -205,21 +205,23 @@ ls "${PHASE_DIR}"/*-PLAN.md 2>/dev/null
|
|||||||
|
|
||||||
**If exists:** Offer: 1) Continue planning (add more plans), 2) View existing, 3) Replan from scratch. Wait for response.
|
**If exists:** Offer: 1) Continue planning (add more plans), 2) View existing, 3) Replan from scratch. Wait for response.
|
||||||
|
|
||||||
## 7. Gather Context Paths
|
## 7. Read Context Files
|
||||||
|
|
||||||
Identify context files for the planner agent:
|
Read and store context file contents for the planner agent. The `@` syntax does not work across Task() boundaries - content must be inlined.
|
||||||
|
|
||||||
```bash
|
```bash
|
||||||
# Required
|
# Read required files
|
||||||
STATE=.planning/STATE.md
|
STATE_CONTENT=$(cat .planning/STATE.md)
|
||||||
ROADMAP=.planning/ROADMAP.md
|
ROADMAP_CONTENT=$(cat .planning/ROADMAP.md)
|
||||||
REQUIREMENTS=.planning/REQUIREMENTS.md
|
|
||||||
|
|
||||||
# Optional (created by earlier steps or commands)
|
# Read optional files (empty string if missing)
|
||||||
CONTEXT="${PHASE_DIR}/${PHASE}-CONTEXT.md"
|
REQUIREMENTS_CONTENT=$(cat .planning/REQUIREMENTS.md 2>/dev/null)
|
||||||
RESEARCH="${PHASE_DIR}/${PHASE}-RESEARCH.md"
|
CONTEXT_CONTENT=$(cat "${PHASE_DIR}"/*-CONTEXT.md 2>/dev/null)
|
||||||
VERIFICATION="${PHASE_DIR}/${PHASE}-VERIFICATION.md"
|
RESEARCH_CONTENT=$(cat "${PHASE_DIR}"/*-RESEARCH.md 2>/dev/null)
|
||||||
UAT="${PHASE_DIR}/${PHASE}-UAT.md"
|
|
||||||
|
# Gap closure files (only if --gaps mode)
|
||||||
|
VERIFICATION_CONTENT=$(cat "${PHASE_DIR}"/*-VERIFICATION.md 2>/dev/null)
|
||||||
|
UAT_CONTENT=$(cat "${PHASE_DIR}"/*-UAT.md 2>/dev/null)
|
||||||
```
|
```
|
||||||
|
|
||||||
## 8. Spawn gsd-planner Agent
|
## 8. Spawn gsd-planner Agent
|
||||||
@@ -233,7 +235,7 @@ Display stage banner:
|
|||||||
◆ Spawning planner...
|
◆ Spawning planner...
|
||||||
```
|
```
|
||||||
|
|
||||||
Fill prompt and spawn:
|
Fill prompt with inlined content and spawn:
|
||||||
|
|
||||||
```markdown
|
```markdown
|
||||||
<planning_context>
|
<planning_context>
|
||||||
@@ -242,23 +244,23 @@ Fill prompt and spawn:
|
|||||||
**Mode:** {standard | gap_closure}
|
**Mode:** {standard | gap_closure}
|
||||||
|
|
||||||
**Project State:**
|
**Project State:**
|
||||||
@.planning/STATE.md
|
{state_content}
|
||||||
|
|
||||||
**Roadmap:**
|
**Roadmap:**
|
||||||
@.planning/ROADMAP.md
|
{roadmap_content}
|
||||||
|
|
||||||
**Requirements (if exists):**
|
**Requirements (if exists):**
|
||||||
@.planning/REQUIREMENTS.md
|
{requirements_content}
|
||||||
|
|
||||||
**Phase Context (if exists):**
|
**Phase Context (if exists):**
|
||||||
@.planning/phases/{phase_dir}/{phase}-CONTEXT.md
|
{context_content}
|
||||||
|
|
||||||
**Research (if exists):**
|
**Research (if exists):**
|
||||||
@.planning/phases/{phase_dir}/{phase}-RESEARCH.md
|
{research_content}
|
||||||
|
|
||||||
**Gap Closure (if --gaps mode):**
|
**Gap Closure (if --gaps mode):**
|
||||||
@.planning/phases/{phase_dir}/{phase}-VERIFICATION.md
|
{verification_content}
|
||||||
@.planning/phases/{phase_dir}/{phase}-UAT.md
|
{uat_content}
|
||||||
|
|
||||||
</planning_context>
|
</planning_context>
|
||||||
|
|
||||||
@@ -320,7 +322,17 @@ Display:
|
|||||||
◆ Spawning plan checker...
|
◆ Spawning plan checker...
|
||||||
```
|
```
|
||||||
|
|
||||||
Fill checker prompt and spawn:
|
Read plans and requirements for the checker:
|
||||||
|
|
||||||
|
```bash
|
||||||
|
# Read all plans in phase directory
|
||||||
|
PLANS_CONTENT=$(cat "${PHASE_DIR}"/*-PLAN.md 2>/dev/null)
|
||||||
|
|
||||||
|
# Read requirements (reuse from step 7 if available)
|
||||||
|
REQUIREMENTS_CONTENT=$(cat .planning/REQUIREMENTS.md 2>/dev/null)
|
||||||
|
```
|
||||||
|
|
||||||
|
Fill checker prompt with inlined content and spawn:
|
||||||
|
|
||||||
```markdown
|
```markdown
|
||||||
<verification_context>
|
<verification_context>
|
||||||
@@ -329,10 +341,10 @@ Fill checker prompt and spawn:
|
|||||||
**Phase Goal:** {goal from ROADMAP}
|
**Phase Goal:** {goal from ROADMAP}
|
||||||
|
|
||||||
**Plans to verify:**
|
**Plans to verify:**
|
||||||
@.planning/phases/{phase_dir}/*-PLAN.md
|
{plans_content}
|
||||||
|
|
||||||
**Requirements (if exists):**
|
**Requirements (if exists):**
|
||||||
@.planning/REQUIREMENTS.md
|
{requirements_content}
|
||||||
|
|
||||||
</verification_context>
|
</verification_context>
|
||||||
|
|
||||||
@@ -371,6 +383,12 @@ Track: `iteration_count` (starts at 1 after initial plan + check)
|
|||||||
|
|
||||||
Display: `Sending back to planner for revision... (iteration {N}/3)`
|
Display: `Sending back to planner for revision... (iteration {N}/3)`
|
||||||
|
|
||||||
|
Read current plans for revision context:
|
||||||
|
|
||||||
|
```bash
|
||||||
|
PLANS_CONTENT=$(cat "${PHASE_DIR}"/*-PLAN.md 2>/dev/null)
|
||||||
|
```
|
||||||
|
|
||||||
Spawn gsd-planner with revision prompt:
|
Spawn gsd-planner with revision prompt:
|
||||||
|
|
||||||
```markdown
|
```markdown
|
||||||
@@ -380,7 +398,7 @@ Spawn gsd-planner with revision prompt:
|
|||||||
**Mode:** revision
|
**Mode:** revision
|
||||||
|
|
||||||
**Existing plans:**
|
**Existing plans:**
|
||||||
@.planning/phases/{phase_dir}/*-PLAN.md
|
{plans_content}
|
||||||
|
|
||||||
**Checker issues:**
|
**Checker issues:**
|
||||||
{structured_issues_from_checker}
|
{structured_issues_from_checker}
|
||||||
@@ -388,7 +406,7 @@ Spawn gsd-planner with revision prompt:
|
|||||||
</revision_context>
|
</revision_context>
|
||||||
|
|
||||||
<instructions>
|
<instructions>
|
||||||
Read existing PLAN.md files. Make targeted updates to address checker issues.
|
Make targeted updates to address checker issues.
|
||||||
Do NOT replan from scratch unless issues are fundamental.
|
Do NOT replan from scratch unless issues are fundamental.
|
||||||
Return what changed.
|
Return what changed.
|
||||||
</instructions>
|
</instructions>
|
||||||
|
|||||||
@@ -170,9 +170,18 @@ Execute each wave in sequence. Autonomous plans within a wave run in parallel.
|
|||||||
- Bad: "Executing terrain generation plan"
|
- Bad: "Executing terrain generation plan"
|
||||||
- Good: "Procedural terrain generator using Perlin noise — creates height maps, biome zones, and collision meshes. Required before vehicle physics can interact with ground."
|
- Good: "Procedural terrain generator using Perlin noise — creates height maps, biome zones, and collision meshes. Required before vehicle physics can interact with ground."
|
||||||
|
|
||||||
2. **Spawn all autonomous agents in wave simultaneously:**
|
2. **Read files and spawn all autonomous agents in wave simultaneously:**
|
||||||
|
|
||||||
Use Task tool with multiple parallel calls. Each agent gets prompt from subagent-task-prompt template:
|
Before spawning, read file contents. The `@` syntax does not work across Task() boundaries - content must be inlined.
|
||||||
|
|
||||||
|
```bash
|
||||||
|
# Read each plan in the wave
|
||||||
|
PLAN_CONTENT=$(cat "{plan_path}")
|
||||||
|
STATE_CONTENT=$(cat .planning/STATE.md)
|
||||||
|
CONFIG_CONTENT=$(cat .planning/config.json 2>/dev/null)
|
||||||
|
```
|
||||||
|
|
||||||
|
Use Task tool with multiple parallel calls. Each agent gets prompt with inlined content:
|
||||||
|
|
||||||
```
|
```
|
||||||
<objective>
|
<objective>
|
||||||
@@ -189,9 +198,14 @@ Execute each wave in sequence. Autonomous plans within a wave run in parallel.
|
|||||||
</execution_context>
|
</execution_context>
|
||||||
|
|
||||||
<context>
|
<context>
|
||||||
Plan: @{plan_path}
|
Plan:
|
||||||
Project state: @.planning/STATE.md
|
{plan_content}
|
||||||
Config: @.planning/config.json (if exists)
|
|
||||||
|
Project state:
|
||||||
|
{state_content}
|
||||||
|
|
||||||
|
Config (if exists):
|
||||||
|
{config_content}
|
||||||
</context>
|
</context>
|
||||||
|
|
||||||
<success_criteria>
|
<success_criteria>
|
||||||
|
|||||||
Reference in New Issue
Block a user