feat: Phase 2 caller migration — gsd-sdk query in workflows, agents, commands (#2179)

* feat: Phase 2 caller migration — gsd-sdk query in workflows (#2122)

Cherry-picked orchestration rewrites from feat/sdk-foundation (#2008, 4018fee) onto current main, resolving conflicts to keep upstream worktree guards and post-merge test gate. SDK stub registry omitted (out of Phase 2 scope per #2122).

Refs: #2122 #2008
Made-with: Cursor

* docs: add gsd-sdk query migration blurb

Made-with: Cursor

* docs(workflows): extend Phase 2 gsd-sdk query caller migration

- Swap node gsd-tools.cjs for gsd-sdk query in review, plan-phase, execute-plan,
  ship, extract_learnings, ai-integration-phase, eval-review, next, thread
- Document graphify CJS-only in gsd-planner; dual-path in CLI-TOOLS and ARCHITECTURE
- Update tests: workstreams gsd-sdk path, thread frontmatter.get, workspace init.*,
  CRLF-safe autonomous frontmatter parse
- CHANGELOG: Phase 2 caller migration scope

Made-with: Cursor

* docs(phase2): USER-GUIDE + remaining gsd-sdk query call sites

- USER-GUIDE: dual-path CLI section; state validate/sync use full CJS path
- Commands: debug (config-get+tdd), quick (security note), intel Task prompt
- Agent: gsd-debug-session-manager resolve-model via jq
- Workflows: milestone-summary, forensics, next, complete-milestone/verify-work
  (audit-open CJS notes), discuss-phase, progress, verify-phase, add/insert/remove
  phase, transition, manager, quick workflow; remove-phase commit without --files
- Test: quick-session-management accepts frontmatter.get
- CHANGELOG: Phase 2 follow-up bullet

Made-with: Cursor

* docs(phase2): align gsd-sdk query examples in commands and agents

- init.* query names; frontmatter.get uses positional field name
- state.* handlers use positional args; commit uses positional paths
- CJS-only notes for from-gsd2 and graphify; learnings.query wording
- CHANGELOG: Phase 2 orchestration doc pass

Made-with: Cursor

* docs(phase2): normalize gsd-sdk query commit to positional file paths

- Strip --files from commit examples in workflows, references, commands
- Keep commit-to-subrepo ... --files (separate handler)
- git-planning-commit.md: document positional args
- Tests: new-project commit line, state.record-session, gates CRLF, roadmap.analyze
- CHANGELOG [Unreleased]

Made-with: Cursor

* feat(sdk): gsd-sdk query parity with gsd-tools and PR 2179 registry fixes

- Route query via longest-prefix match and dotted single-token expansion; fall back
  to runGsdToolsQuery (same argv as node gsd-tools.cjs) for full CLI coverage.
- Parse gsd-sdk query permissively so gsd-tools flags (--json, --verify, etc.) are
  not rejected by strict parseArgs.
- resolveGsdToolsPath: honor GSD_TOOLS_PATH; prefer bundled get-shit-done copy
  over project .claude installs; export runGsdToolsQuery from the SDK.
- Fix gsd-tools audit-open (core.output; pass object for --json JSON).
- Register summary-extract as alias of summary.extract; fix audit-fix workflow to
  call audit-uat instead of invalid init.audit-uat (PR review).

Updates QUERY-HANDLERS.md and CHANGELOG [Unreleased].

Made-with: Cursor

* fix(sdk): Phase 2 scope — Trek-e review (#2179, #2122)

- Remove gsd-sdk query passthrough to gsd-tools.cjs; drop GSD_TOOLS_PATH
- Consolidate argv routing in resolveQueryArgv(); update USAGE and QUERY-HANDLERS
- Surface @file: read failures in GSDTools.parseOutput
- execute-plan: defer Task Commit Protocol to gsd-executor
- stale-colon-refs: skip .planning/ and root CLAUDE.md (gitignored overlays)
- CHANGELOG [Unreleased]: maintainer review and routing notes

Made-with: Cursor
This commit is contained in:
Rezolv
2026-04-15 22:46:31 -04:00
committed by GitHub
parent 762b8ed25b
commit d3a79917fa
120 changed files with 845 additions and 586 deletions

View File

@@ -327,13 +327,17 @@ describe('GSDTools', () => {
// ─── resolveGsdToolsPath() tests ────────────────────────────────────────
describe('resolveGsdToolsPath()', () => {
it('returns repo-local path when it exists', async () => {
it('prefers bundled gsd-tools over project .claude when the bundled file exists', async () => {
const localBinDir = join(tmpDir, '.claude', 'get-shit-done', 'bin');
await mkdir(localBinDir, { recursive: true });
await writeFile(join(localBinDir, 'gsd-tools.cjs'), '// stub');
const result = resolveGsdToolsPath(tmpDir);
expect(result).toBe(join(localBinDir, 'gsd-tools.cjs'));
if (existsSync(BUNDLED_GSD_TOOLS_PATH)) {
expect(result).toBe(BUNDLED_GSD_TOOLS_PATH);
} else {
expect(result).toBe(join(localBinDir, 'gsd-tools.cjs'));
}
});
it('falls back to bundled repo path when repo-local does not exist', () => {
@@ -345,7 +349,7 @@ describe('GSDTools', () => {
expect(result).toBe(expected);
});
it('constructor uses repo-local path when available', async () => {
it('uses explicit gsdToolsPath when provided (overrides bundled / .claude resolution)', async () => {
const localBinDir = join(tmpDir, '.claude', 'get-shit-done', 'bin');
await mkdir(localBinDir, { recursive: true });
const scriptPath = join(localBinDir, 'gsd-tools.cjs');
@@ -355,8 +359,7 @@ describe('GSDTools', () => {
{ mode: 0o755 },
);
// No explicit gsdToolsPath — should auto-resolve to local
const tools = new GSDTools({ projectDir: tmpDir });
const tools = new GSDTools({ projectDir: tmpDir, gsdToolsPath: scriptPath });
const result = await tools.exec('test', []);
expect(result).toEqual({ source: 'local' });
});