The #452 ESLint migration replaced the homegrown source-grep regex linters with the local/no-source-grep AST rule (eslint-rules/no-source-grep.cjs, wired in eslint.config.mjs) but left the old scripts on disk, wired to nothing. Removed: - scripts/lint-no-source-grep.cjs — CLI linter; no module.exports, never required, not referenced by package.json / CI / eslint. Superseded by the rule. - scripts/lint-no-source-grep-extras.cjs — var-binding + wrapped-assert-ok regex detectors; the ESLint rule covers both forms via AST (VariableDeclarator/AssignmentExpression tracking + member-call checks). - tests/bug-2982-lint-var-binding.test.cjs — exercised only the deleted extras module; the #2982 var-binding scenario is already covered against the live rule by tests/eslint-rules.test.cjs. Also dropped the now-dangling 'scripts/lint-no-source-grep.cjs' entry from DEFAULT_RELATIVE_FILES in scripts/lint-pr-check-project-dir.cjs (the list is existsSync-filtered, so this is tidy-up, not a behavior change). No functional change: source-grep enforcement remains intact via the ESLint rule, and the full unit suite stays green. Three surviving comment-only mentions of "lint-no-source-grep" refer to the rule concept (which lives on in ESLint), not the deleted files. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: Tom Boucher <trekkie@nomorestars.com>
This commit is contained in:
@@ -1,103 +0,0 @@
|
||||
// allow-test-rule: structural-regression-guard
|
||||
// Reads hook .js or bin/install.js source to assert structural invariants
|
||||
// (search array order, function wiring, path constants) that cannot be
|
||||
// verified by observing runtime outputs alone. Per CONTRIBUTING.md exception matrix.
|
||||
'use strict';
|
||||
// Migrated (#455): detectVarBindingViolations/detectWrappedAssertOkMatch are pure
|
||||
// functions returning typed violation records; all assertions use typed fields.
|
||||
|
||||
process.env.GSD_TEST_MODE = '1';
|
||||
|
||||
const { test, describe } = require('node:test');
|
||||
const assert = require('node:assert/strict');
|
||||
const path = require('node:path');
|
||||
|
||||
const { detectVarBindingViolations, VIOLATION } = require(path.join(__dirname, '..', 'scripts', 'lint-no-source-grep-extras.cjs'));
|
||||
|
||||
// detectVarBindingViolations is pure: takes source text, returns a list of
|
||||
// violation records. Tests assert on the structured records, not on the
|
||||
// detector's prose (per "Prohibited: Raw Text Matching on Test Outputs").
|
||||
|
||||
describe('Bug #2982: var-binding readFileSync.includes() detector', () => {
|
||||
test('VIOLATION enum exposes the documented codes', () => {
|
||||
assert.deepEqual(
|
||||
Object.keys(VIOLATION).sort(),
|
||||
['VAR_FROM_READFILE_USED_IN_TEXT_MATCH', 'WRAPPED_ASSERT_OK_MATCH'].sort(),
|
||||
);
|
||||
});
|
||||
|
||||
test('flags a single var bound from readFileSync then used with .includes() later', () => {
|
||||
const src = [
|
||||
"const x = fs.readFileSync('foo.cjs', 'utf8');",
|
||||
'// some lines later',
|
||||
"if (x.includes('foo')) { /* ... */ }",
|
||||
].join('\n');
|
||||
const findings = detectVarBindingViolations(src);
|
||||
assert.equal(findings.length, 1);
|
||||
assert.equal(findings[0].kind, VIOLATION.VAR_FROM_READFILE_USED_IN_TEXT_MATCH);
|
||||
assert.equal(findings[0].variable, 'x');
|
||||
assert.equal(findings[0].method, 'includes');
|
||||
});
|
||||
});
|
||||
|
||||
describe('Bug #2982: var-binding detector — coverage of methods (#2982)', () => {
|
||||
const { detectVarBindingViolations, VIOLATION } = require(require('node:path').join(__dirname, '..', 'scripts', 'lint-no-source-grep-extras.cjs'));
|
||||
|
||||
for (const method of ['includes', 'startsWith', 'endsWith', 'match', 'search']) {
|
||||
test(`flags <var>.${method}( on a readFileSync-bound variable`, () => {
|
||||
const src = `const c = fs.readFileSync('x.cjs','utf8');\nc.${method}('foo');\n`;
|
||||
const findings = detectVarBindingViolations(src);
|
||||
assert.equal(findings.length, 1);
|
||||
assert.equal(findings[0].method, method);
|
||||
});
|
||||
}
|
||||
|
||||
test('flags multiple violations across multiple variables', () => {
|
||||
const src = [
|
||||
"const a = readFileSync('a.cjs', 'utf8');",
|
||||
"const b = fs.readFileSync('b.cjs');",
|
||||
"if (a.includes('x')) {}",
|
||||
"if (b.startsWith('y')) {}",
|
||||
"a.endsWith('z');",
|
||||
].join('\n');
|
||||
const findings = detectVarBindingViolations(src);
|
||||
assert.equal(findings.length, 3);
|
||||
const byVar = findings.reduce((acc, f) => {
|
||||
acc[f.variable] = (acc[f.variable] || []).concat(f.method);
|
||||
return acc;
|
||||
}, {});
|
||||
assert.deepEqual(byVar.a.sort(), ['endsWith', 'includes']);
|
||||
assert.deepEqual(byVar.b, ['startsWith']);
|
||||
});
|
||||
|
||||
test('does NOT flag .includes() on a variable that was not bound from readFileSync', () => {
|
||||
const src = "const arr = [1, 2, 3];\nif (arr.includes(2)) {}";
|
||||
assert.deepEqual(detectVarBindingViolations(src), []);
|
||||
});
|
||||
|
||||
test('does NOT flag a fresh string literal substring check', () => {
|
||||
const src = "if ('hello world'.includes('world')) {}";
|
||||
assert.deepEqual(detectVarBindingViolations(src), []);
|
||||
});
|
||||
});
|
||||
|
||||
describe('Bug #2982: assert.ok(...match(...)) detector', () => {
|
||||
const { detectWrappedAssertOkMatch, VIOLATION } = require(require('node:path').join(__dirname, '..', 'scripts', 'lint-no-source-grep-extras.cjs'));
|
||||
|
||||
test('flags assert.ok(text.match(/.../)) which escapes assert.match', () => {
|
||||
const src = "assert.ok(text.match(/Failures: \\d+/));";
|
||||
const findings = detectWrappedAssertOkMatch(src);
|
||||
assert.equal(findings.length, 1);
|
||||
assert.equal(findings[0].kind, VIOLATION.WRAPPED_ASSERT_OK_MATCH);
|
||||
});
|
||||
|
||||
test('does NOT flag assert.match itself (covered by base lint)', () => {
|
||||
const src = "assert.match(text, /foo/);";
|
||||
assert.deepEqual(detectWrappedAssertOkMatch(src), []);
|
||||
});
|
||||
|
||||
test('does NOT flag .matchAll(...) — matchAll is not match, so assert.ok(.matchAll(...)) is not flagged', () => {
|
||||
const src = "assert.ok([...text.matchAll(/foo/g)].length > 0);";
|
||||
assert.deepEqual(detectWrappedAssertOkMatch(src), []);
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user