golem15/msd-core
4
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Merge remote-tracking branch 'origin/main' into feat/2387-ingest-docs-clean

Browse Source 
# Conflicts:
#	CHANGELOG.md
This commit is contained in:
Jeremy McSpadden
2026-04-17 21:46:39 -05:00
parent b96255cf0c 0f7bcabd78
commit d5f849955b
7 changed files with 171 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

57
tests/bugs-1656-1657.test.cjs
View File

@@ -48,22 +48,67 @@ describe('#1656: community .sh hooks must be present in hooks/dist', () => {
});
// ─── #1657 ───────────────────────────────────────────────────────────────────
//
// Historical context: #1657 originally guarded against a broken `promptSdk()`
// flow that shipped when `@gsd-build/sdk` did not yet exist on npm. The
// package was published at v0.1.0 and is now a hard runtime requirement for
// every /gsd-* command (they all shell out to `gsd-sdk query …`).
//
// #2385 restored the `--sdk` flag and made SDK install the default path in
// bin/install.js. These guards are inverted: we now assert that SDK install
// IS wired up, and that the old broken `promptSdk()` prompt is still gone.
describe('#1657: SDK prompt must not appear in installer source', () => {
describe('#1657 / #2385: SDK install must be wired into installer source', () => {
let src;
test('install.js does not contain promptSdk call', () => {
test('install.js does not contain the legacy promptSdk() prompt (#1657)', () => {
src = fs.readFileSync(INSTALL_SRC, 'utf-8');
assert.ok(
!src.includes('promptSdk('),
'promptSdk() must not be called — SDK prompt causes install failures when package does not exist on npm'
'promptSdk() must not be reintroduced — the old interactive prompt flow was broken'
);
});
test('install.js does not contain --sdk flag handling', () => {
test('install.js wires up --sdk / --no-sdk flag handling (#2385)', () => {
src = src || fs.readFileSync(INSTALL_SRC, 'utf-8');
assert.ok(
!src.includes("args.includes('--sdk')"),
'--sdk flag must be removed to prevent users triggering a broken SDK install'
src.includes("args.includes('--sdk')"),
'--sdk flag must be parsed so users can force SDK (re)install'
);
assert.ok(
src.includes("args.includes('--no-sdk')"),
'--no-sdk flag must be parsed so users can opt out of SDK install'
);
});
test('install.js builds gsd-sdk from in-repo sdk/ source (#2385)', () => {
src = src || fs.readFileSync(INSTALL_SRC, 'utf-8');
// The installer must locate the in-repo sdk/ directory, run the build,
// and install it globally. We intentionally do NOT install
// @gsd-build/sdk from npm because that published version lags the source
// tree and shipping it breaks query handlers added since the last
// publish.
assert.ok(
src.includes("path.resolve(__dirname, '..', 'sdk')") ||
src.includes('path.resolve(__dirname, "..", "sdk")'),
'installer must locate the in-repo sdk/ directory'
);
assert.ok(
src.includes("'npm install -g .'") ||
src.includes("['install', '-g', '.']"),
'installer must run `npm install -g .` from sdk/ to install the built package globally'
);
assert.ok(
src.includes("['run', 'build']"),
'installer must compile TypeScript via `npm run build` before installing globally'
);
});
test('package.json ships sdk source in published tarball (#2385)', () => {
const rootPkg = JSON.parse(fs.readFileSync(path.join(__dirname, '..', 'package.json'), 'utf-8'));
const files = rootPkg.files || [];
assert.ok(
files.some((f) => f === 'sdk' || f.startsWith('sdk/')),
'root package.json `files` must include sdk source so npm-registry installs can build gsd-sdk from source'
);
});
});