* test(#3864): smart-entry classify must match the verif* status stem (failing first) * fix(#3864): classify() matches the verif* status stem, aligning with normalizeStateStatus "verified"/"verification" contain no "verify" substring, so the exact-word branch never matched: a STATE.md declaring status: verified fell through to situation "unknown" (or idle-stranded on a clean tree with unpushed commits — differently wrong, which made it look intermittent). state-document's normalizeStateStatus already matches any verif* stem; the classifier now uses the same stem, so the two owners agree on the invariant. verify_failed is tested earlier in classify(), so failed verification still wins. Negative controls (completed/executing/planning/paused) unchanged and pinned. * test(#3864): review fold-in — the real handler-written verification status pinned both ways 'Phase complete — ready for verification' (state-document.cts's own Status default) carries the verif stem but names completion: at 5/5 it must stay complete (isComplete beats the stem), mid-project it must route to verify-pending (pre-fix it fell through to unknown/idle- stranded — a real behavior change beyond the literal verified repro, sanctioned by the issue's own verification→verify-pending table). * chore(#3864): changeset fragment (pr number backfilled after PR creation) * chore(#3864): backfill changeset PR number (4052) --------- Co-authored-by: sim <sim@local>
This commit is contained in:
@@ -114,6 +114,52 @@ describe('smart-entry: situation coverage', () => {
|
||||
});
|
||||
}
|
||||
|
||||
// #3860-family guard is NOT wanted here; these are #3864's missing pins:
|
||||
// the classifier's verify branch must match the same verif* stem that
|
||||
// state-document's normalizeStateStatus matches, or a STATE.md declaring
|
||||
// `status: verified` falls through to `unknown` (and, on a clean tree with
|
||||
// unpushed commits, to idle-stranded — differently wrong).
|
||||
test('#3864: status "verified" classifies as verify-pending', () => {
|
||||
const dir = track(makeProject({ state: state({ status: 'verified', total_phases: 5, current_phase: 2 }), roadmap: true }));
|
||||
const result = classifyProject(dir);
|
||||
assert.equal(result.situation, 'verify-pending');
|
||||
});
|
||||
|
||||
test('#3864: status "verification" classifies as verify-pending', () => {
|
||||
const dir = track(makeProject({ state: state({ status: 'verification', total_phases: 5, current_phase: 2 }), roadmap: true }));
|
||||
const result = classifyProject(dir);
|
||||
assert.equal(result.situation, 'verify-pending');
|
||||
});
|
||||
|
||||
test('#3864: the stem does not over-match — "completed" still reaches complete', () => {
|
||||
const dir = track(makeProject({ state: state({ status: 'completed', total_phases: 5, current_phase: 5 }), roadmap: true }));
|
||||
const result = classifyProject(dir);
|
||||
assert.equal(result.situation, 'complete');
|
||||
});
|
||||
|
||||
test('#3864: "Phase complete — ready for verification" at 5/5 stays complete (complete beats a verif-bearing status)', () => {
|
||||
// A real handler-written Status default (state-document.cts). It carries
|
||||
// the verif stem but names COMPLETION — isComplete must win over the
|
||||
// verify-pending branch when the project is actually done.
|
||||
const dir = track(makeProject({ state: state({ status: 'Phase complete — ready for verification', total_phases: 5, current_phase: 5 }), roadmap: true }));
|
||||
const result = classifyProject(dir);
|
||||
assert.equal(result.situation, 'complete');
|
||||
});
|
||||
|
||||
test('#3864: "Phase complete — ready for verification" mid-project is verify-pending', () => {
|
||||
// Same real status word, phases remaining: pre-fix this fell through to
|
||||
// unknown/idle-stranded (no "verify" substring); the stem now routes it.
|
||||
const dir = track(makeProject({ state: state({ status: 'Phase complete — ready for verification', total_phases: 5, current_phase: 2 }), roadmap: true }));
|
||||
const result = classifyProject(dir);
|
||||
assert.equal(result.situation, 'verify-pending');
|
||||
});
|
||||
|
||||
test('#3864: verify-failed still wins over the verify-pending stem (ordering pinned)', () => {
|
||||
const dir = track(makeProject({ state: state({ status: 'verify-failed', total_phases: 5, current_phase: 2 }), roadmap: true, verifyFail: true }));
|
||||
const result = classifyProject(dir);
|
||||
assert.equal(result.situation, 'verify-failed');
|
||||
});
|
||||
|
||||
test('SITUATIONS constant lists all 11 (incl unknown) and is frozen', () => {
|
||||
assert.equal(SITUATIONS.length, 11);
|
||||
assert.ok(SITUATIONS.includes('unknown'));
|
||||
|
||||
Reference in New Issue
Block a user