golem15/msd-core
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(#3345): stop counting blocked summaries as completed plans (#3459)

Browse Source 
* fix(#3345): stop counting blocked summaries as completed plans

* chore(#3345): set changeset pr reference

---------

Co-authored-by: sim <sim@local>
This commit is contained in:
Tom Boucher
2026-08-14 10:24:05 -04:00
committed by GitHub
parent 69e7afd0c7
commit da7d4dac52
6 changed files with 425 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/phase.cts
View File

@@ -79,7 +79,7 @@ import verifyMod = require('./verify.cjs');
const { readVerificationStatus } = verificationMod;
// eslint-disable-next-line @typescript-eslint/no-require-imports -- plan-dependency-graph.cjs is an export= CommonJS module
import planDependencyGraphMod = require('./plan-dependency-graph.cjs');
const { computeHaltPropagation, buildSummaryFileIndex, isSummaryFileHalted } = planDependencyGraphMod;
const { computeHaltPropagation, buildSummaryFileIndex, isSummaryFileHalted, isSummaryFileBlocked } = planDependencyGraphMod;
const { planningDir, withPlanningLock, listAvailableWorkstreams, getActiveWorkstream } =
planningWorkspace;
@@ -769,7 +769,20 @@ function cmdPhasePlanIndex(cwd: string, phase: string, raw: boolean): void {
// `plans/SUMMARY-01.md` correctly) instead of a bespoke ID-Set built from
// extractCanonicalPlanId, which only ever handled the root-canonical
// `-PLAN.md`/`-SUMMARY.md` naming form.
const unsummarizedPlanFiles = new Set(findUnsummarizedPlans(planFiles, summaryFiles));
//
// #3345: the summary list is filtered through the SAME shared predicate
// scanPhasePlans filters its countable set with
// (plan-dependency-graph.cjs's isSummaryFileBlocked), so a SUMMARY declaring
// `status: blocked` reads as NO completion record here — has_summary false,
// the plan lands in `incomplete` — exactly matching the count side. Fail-open
// on a SUMMARY with no status key / unreadable file (filename fallback);
// `status: halted` stays summarized (#2830 designed stop). summaryFileByPlanId
// below still indexes EVERY summary on disk because the halted lookup is a
// file resolution for reading status, not a completion pairing.
const countableSummaryFiles = summaryFiles.filter(
(f) => !isSummaryFileBlocked(path.join(phaseDir, f)),
);
const unsummarizedPlanFiles = new Set(findUnsummarizedPlans(planFiles, countableSummaryFiles));
// #2830: reverse lookup from a completed plan's id (exact or canonical) to
// the actual summary filename, so a plan's own SUMMARY frontmatter can be
// read for its `status`. Shared builder (also used by phase-locator.cts's