golem15/msd-core
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(#2771): advisor mode spawns registered gsd-advisor-researcher subagent instead of general-purpose (#2884)

Browse Source 
* test(#2771): advisor mode must spawn gsd-advisor-researcher, not general-purpose

* fix(#2771): spawn registered gsd-advisor-researcher subagent instead of general-purpose in advisor mode

universal-anti-patterns rule 10 (injected into discuss-phase via <required_reading>)
says NEVER use non-GSD agent types. The advisor mode spawned general-purpose and
manually told the agent to read the def — but gsd-advisor-researcher IS registered,
so spawning by type auto-loads it. Drop the manual-read prompt line (re-specifying
the def is a drift risk) and use the registered type.

* chore(#2771): changeset fragment (mentions follow-up #2883)

* test(#2771): widen manual-read-line regex to deny phrasing variants (review minor)

/read\s+@.*gsd-advisor-researcher\.md/i (case-insensitive, any 'read @' lead-in)
so a drift variant like 'Read @' or 'Load @' can't sneak the manual-def-read back in.

* chore(#2771): backfill changeset PR number (2884)

---------

Co-authored-by: Test <test@example.com>
This commit is contained in:
Tom Boucher
2026-07-30 17:25:55 -04:00
committed by GitHub
parent 185da024cb
commit dbb0a653be
3 changed files with 50 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/curious-pumas-wake.md Normal file
View File

@@ -0,0 +1,5 @@
---
type: Fixed
pr: 2886
---
**Discuss-phase advisor mode now spawns the registered `gsd-advisor-researcher` subagent instead of `general-purpose`** — resolving a contradiction with the universal-anti-patterns rule (injected into the same context) that forbids non-GSD agent types. The manual "read the agent def" prompt line is dropped (spawning by type auto-loads it). (#2771; the sibling assumptions-site needs a design decision — filed as #2883)