golem15/msd-core
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(#2335): normalize volta node image paths to the stable shim (#2375)

Browse Source 
Adds a volta branch to normalizeNodePath() that rewrites the version-pinned node image path to volta's stable shim, so managed hooks survive a volta node prune (the fnm/Homebrew/mise class, now covered for volta). Also unifies the release-smoke install timeout into one shared 600s constant across before() and runSmoke() so slow benches no longer spuriously time out.

Closes #2335. Admin-merged (self-review bypass) with full green CI.
This commit is contained in:
Tom Boucher
2026-07-17 12:38:37 -04:00
committed by GitHub
parent b302f53ee6
commit dcb4954131
5 changed files with 152 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/runtime-hooks-surface.cts
View File

@@ -356,6 +356,24 @@ function normalizeNodePath(execPath: string, opts?: NodeNormOpts): string {
const shim = `${miseMatch[1]}/shims/node${miseMatch[2] || ''}`;
if (existsSync(shim)) return shim;
}
// volta pins a concrete node image at <VOLTA_HOME>/tools/image/node/<ver>/bin/node
// (Windows: <VOLTA_HOME>/tools/image/node/<ver>/node.exe — volta's own layout
// puts node.exe at the image root, no bin/). `volta uninstall node@<ver>` prunes
// that image, so a baked hook command 404s — the same ephemeral-path failure
// #977 fixed for fnm and #1619 for mise. The stable alias is the shim
// <VOLTA_HOME>/bin/node, a symlink to volta-shim that always resolves to the
// active pin. Derive <VOLTA_HOME> from execPath rather than the env so a custom
// VOLTA_HOME and the Windows %LOCALAPPDATA%\Volta default both work (#2185's
// reasoning), and only rewrite when the shim exists — otherwise fall back to
// the raw execPath unchanged.
const voltaMatch = normalizedForMatch.match(
/^(.*)\/tools\/image\/node\/[^/]+\/(?:bin\/)?node(\.exe)?$/,
);
if (voltaMatch) {
const shim = `${voltaMatch[1]}/bin/node${voltaMatch[2] || ''}`;
if (existsSync(shim)) return shim;
}
return execPath;
}