test(#1971): consolidate 48 gsd-tools CLI regression tests into subcommand suites
Fold 48 issue-named gsd-tools CLI regression files into the canonical test file that owns each subcommand subject (state, roadmap, phase, milestone, audit, config, router/dispatch, stats, verify, health, etc.), preserving every assertion and its origin issue number as provenance (block-scoped describe wrappers, 299 subtests conserved 1:1). No monolithic gsd-tools.test.cjs created — routes into 18 existing per-subject suites. Removes 48 tests/ files. Regenerates regression-name allowlist (271->231), ratchets the file-count allowlist across 6 buckets (audit/milestone/phase/roadmap/state/verify), and makes 10 relocated allow-test-rule exemptions issue-ref-compliant (ADR-456; prunes 10 stale ids). Repoints one CONTEXT.md symptom ref and ADR-3524's parity-test ref. lint:ci green. Part of epic #1969. Closes #1971. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
@@ -83,3 +83,85 @@ describe('phases-command-router', () => {
|
||||
assert.equal(message, 'Unknown phases subcommand. Available: list, clear');
|
||||
});
|
||||
});
|
||||
|
||||
|
||||
// ────────────────────────────────────────────────────────────────────────
|
||||
// Folded from tests/bug-1826-phases-clear-confirm.test.cjs — consolidation epic #1969 (B2 #1971)
|
||||
// ────────────────────────────────────────────────────────────────────────
|
||||
{
|
||||
const { describe: __foldDescribe } = require('node:test');
|
||||
__foldDescribe("folded:bug-1826-phases-clear-confirm (consolidation epic #1969 B2 #1971)", () => {
|
||||
/**
|
||||
* Regression tests for bug #1826
|
||||
*
|
||||
* `phases clear` must require an explicit --confirm flag before deleting any
|
||||
* phase directories. Without it, any accidental or hallucinated invocation
|
||||
* wipes the entire .planning/phases/ tree with no warning.
|
||||
*
|
||||
* Rules:
|
||||
* - Phase dirs present + no --confirm → non-zero exit, clear error message
|
||||
* - Phase dirs present + --confirm → deletes, exits 0, reports count
|
||||
* - No phase dirs + no --confirm → exits 0, cleared=0 (nothing to guard)
|
||||
*/
|
||||
|
||||
'use strict';
|
||||
|
||||
const { describe, test, beforeEach, afterEach } = require('node:test');
|
||||
const assert = require('node:assert/strict');
|
||||
const fs = require('fs');
|
||||
const path = require('path');
|
||||
const { runGsdTools, createTempProject, cleanup } = require('./helpers.cjs');
|
||||
|
||||
describe('bug #1826: phases clear --confirm guard', () => {
|
||||
let tmpDir;
|
||||
|
||||
beforeEach(() => {
|
||||
tmpDir = createTempProject();
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup(tmpDir);
|
||||
});
|
||||
|
||||
test('phases clear without --confirm is rejected when phase dirs exist', () => {
|
||||
const phasesDir = path.join(tmpDir, '.planning', 'phases');
|
||||
fs.mkdirSync(path.join(phasesDir, '01-foundation'), { recursive: true });
|
||||
fs.mkdirSync(path.join(phasesDir, '02-api'), { recursive: true });
|
||||
|
||||
const result = runGsdTools(['phases', 'clear'], tmpDir);
|
||||
|
||||
assert.ok(!result.success, 'should exit non-zero when dirs exist and --confirm absent');
|
||||
assert.ok(
|
||||
result.error.includes('--confirm'),
|
||||
`error message must mention --confirm; got: ${result.error}`
|
||||
);
|
||||
|
||||
// Dirs must be untouched
|
||||
assert.ok(fs.existsSync(path.join(phasesDir, '01-foundation')), 'dirs must not be deleted');
|
||||
assert.ok(fs.existsSync(path.join(phasesDir, '02-api')), 'dirs must not be deleted');
|
||||
});
|
||||
|
||||
test('phases clear --confirm deletes dirs and reports count', () => {
|
||||
const phasesDir = path.join(tmpDir, '.planning', 'phases');
|
||||
fs.mkdirSync(path.join(phasesDir, '01-foundation'), { recursive: true });
|
||||
fs.mkdirSync(path.join(phasesDir, '02-api'), { recursive: true });
|
||||
|
||||
const result = runGsdTools(['phases', 'clear', '--confirm'], tmpDir);
|
||||
|
||||
assert.ok(result.success, `should succeed with --confirm: ${result.error}`);
|
||||
const out = JSON.parse(result.output);
|
||||
assert.strictEqual(out.cleared, 2);
|
||||
assert.ok(!fs.existsSync(path.join(phasesDir, '01-foundation')), 'dirs should be removed');
|
||||
});
|
||||
|
||||
test('phases clear without --confirm succeeds when no phase dirs exist', () => {
|
||||
// .planning/phases/ exists but is empty — nothing to guard
|
||||
const result = runGsdTools(['phases', 'clear'], tmpDir);
|
||||
|
||||
assert.ok(result.success, `should succeed with empty phases dir: ${result.error}`);
|
||||
const out = JSON.parse(result.output);
|
||||
assert.strictEqual(out.cleared, 0);
|
||||
});
|
||||
});
|
||||
});
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user