golem15/msd-core
3
0
Fork 0
Code Issues Pull Requests Actions 4 Packages Projects Releases Wiki Activity

test: add --no-sdk to hook-deployment installer tests

Browse Source 
Tests #1834, #1924, #2136 exercise hook/artifact deployment and don't
care about SDK install. Now that installSdkIfNeeded() failures are
fatal, these tests fail on any CI runner without gsd-sdk pre-built
because the sdk/ tsc build path runs and can fail in CI env.

Pass --no-sdk so each test focuses on its actual subject. SDK install
path has dedicated end-to-end coverage in install-smoke.yml.
This commit is contained in:
Jeremy McSpadden
2026-04-19 16:35:32 -05:00
parent af66cd89ca
commit e213ce0292
3 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
tests/bug-1834-sh-hooks-installed.test.cjs
View File

@@ -58,7 +58,10 @@ function cleanup(dir) {
* Returns the path to the installed hooks directory. * Returns the path to the installed hooks directory.
*/ */
function runInstaller(configDir) { function runInstaller(configDir) {
execFileSync(process.execPath, [INSTALL_SCRIPT, '--claude', '--global', '--yes'], { // --no-sdk: this test covers hook deployment only; skip SDK build to avoid
// flakiness and keep the test fast (SDK install path has dedicated coverage
// in install-smoke.yml).
execFileSync(process.execPath, [INSTALL_SCRIPT, '--claude', '--global', '--yes', '--no-sdk'], {
encoding: 'utf-8', encoding: 'utf-8',
stdio: 'pipe', stdio: 'pipe',
env: { env: {

4
tests/bug-1924-preserve-user-artifacts.test.cjs
View File

@@ -57,7 +57,9 @@ function cleanup(dir) {
function runInstaller(configDir) { function runInstaller(configDir) {
const env = { ...process.env, CLAUDE_CONFIG_DIR: configDir }; const env = { ...process.env, CLAUDE_CONFIG_DIR: configDir };
delete env.GSD_TEST_MODE; delete env.GSD_TEST_MODE;
execFileSync(process.execPath, [INSTALL_SCRIPT, '--claude', '--global', '--yes'], { // --no-sdk: this test covers user-artifact preservation only; skip SDK
// build (covered by install-smoke.yml) to keep the test deterministic.
execFileSync(process.execPath, [INSTALL_SCRIPT, '--claude', '--global', '--yes', '--no-sdk'], {
encoding: 'utf-8', encoding: 'utf-8',
stdio: 'pipe', stdio: 'pipe',
env, env,

4
tests/bug-2136-sh-hook-version.test.cjs
View File

@@ -68,7 +68,9 @@ function cleanup(dir) {
} }
function runInstaller(configDir) { function runInstaller(configDir) {
execFileSync(process.execPath, [INSTALL_SCRIPT, '--claude', '--global', '--yes'], { // --no-sdk: this test covers .sh hook version stamping only; skip SDK
// build (covered by install-smoke.yml).
execFileSync(process.execPath, [INSTALL_SCRIPT, '--claude', '--global', '--yes', '--no-sdk'], {
encoding: 'utf-8', encoding: 'utf-8',
stdio: 'pipe', stdio: 'pipe',
env: { ...process.env, CLAUDE_CONFIG_DIR: configDir }, env: { ...process.env, CLAUDE_CONFIG_DIR: configDir },