golem15/msd-core
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: remove stale SDK router shim wrappers (#298)

Browse Source 
* refactor(#297): remove stale sdk router shim wrappers

* test: remove sdk-era refusal wording fixtures
This commit is contained in:
Tom Boucher
2026-05-26 12:21:04 -04:00
committed by GitHub
parent e905ca1c32
commit e4f29feabc
8 changed files with 27 additions and 68 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/command-routing-hub.test.cjs
View File

@@ -292,7 +292,7 @@ describe('CommandRoutingHub — kind: HandlerRefusal', () => {
'list-plans': (_ctx) => ({
ok: false,
kind: ERROR_KINDS.HandlerRefusal,
reason: 'phase list-plans is SDK-only',
reason: 'phase list-plans is not supported in this router.',
}),
},
},
@@ -457,7 +457,7 @@ describe('CommandRoutingHub — P1.2 typed-payload discriminated union (#176)',
'list-plans': (_ctx) => ({
ok: false,
kind: ERROR_KINDS.HandlerRefusal,
reason: 'phase list-plans is SDK-only',
reason: 'phase list-plans is not supported in this router.',
}),
},
},
@@ -467,7 +467,7 @@ describe('CommandRoutingHub — P1.2 typed-payload discriminated union (#176)',
assert.ok(!result.ok);
assert.equal(result.kind, ERROR_KINDS.HandlerRefusal);
assert.ok(result.reason.includes('SDK-only'));
assert.ok(result.reason.includes('not supported'));
// Strict field set
const keys = Object.keys(result).sort();
assert.deepStrictEqual(keys, ['kind', 'ok', 'reason']);
@@ -781,7 +781,7 @@ describe('CommandRoutingHub — Finding 3: factory returns are Object.frozen', (
});
test('makeHandlerRefusal returns a frozen object', () => {
const result = makeHandlerRefusal('SDK-only');
const result = makeHandlerRefusal('not supported');
assert.ok(Object.isFrozen(result),
'makeHandlerRefusal must return a frozen object');
});

19
tests/phase-command-router.test.cjs
View File

@@ -6,7 +6,7 @@
* Shape:
* 1. Adapter translation — CLI args → hub dispatch shape
* 2. Result translation — hub result → stdout / error callback
* 3. Unsupported subcommands — SDK-only commands produce the documented error
* 3. Unsupported subcommands — unsupported commands produce the documented error
* 4. Unknown subcommand — unmapped subcommands produce a well-formed error
* 5. Integration — real hub + real CJS phase handler invocation
*
@@ -22,8 +22,7 @@ const assert = require('node:assert/strict');
const { routePhaseCommand } = require('../get-shit-done/bin/lib/phase-command-router.cjs');
// Force CJS path throughout: set GSD_WORKSTREAM so tryLoadSdk() is bypassed.
// This makes unit-level assertions deterministic regardless of SDK build state.
// Set GSD_WORKSTREAM for deterministic routing context in tests.
let _prevWorkstream;
before(() => {
_prevWorkstream = process.env.GSD_WORKSTREAM;
@@ -282,10 +281,10 @@ describe('phase-command-router — result translation (error path)', () => {
});
});
// ─── 3. Unsupported (SDK-only) subcommands ────────────────────────────────────
// ─── 3. Unsupported subcommands ───────────────────────────────────────────────
describe('phase-command-router — SDK-only subcommands', () => {
test('phase list-plans calls error() with SDK-only message', () => {
describe('phase-command-router — unsupported subcommands', () => {
test('phase list-plans calls error() with unsupported message', () => {
let msg = null;
routePhaseCommand({
phase: makePhase(),
@@ -296,11 +295,11 @@ describe('phase-command-router — SDK-only subcommands', () => {
});
assert.ok(msg !== null);
assert.ok(msg.includes('SDK-only'), `expected "SDK-only" in: ${msg}`);
assert.ok(msg.includes('not supported'), `expected unsupported text in: ${msg}`);
assert.ok(msg.includes('list-plans'));
});
test('phase list-artifacts calls error() with SDK-only message', () => {
test('phase list-artifacts calls error() with unsupported message', () => {
let msg = null;
routePhaseCommand({
phase: makePhase(),
@@ -311,7 +310,7 @@ describe('phase-command-router — SDK-only subcommands', () => {
});
assert.ok(msg !== null);
assert.ok(msg.includes('SDK-only'));
assert.ok(msg.includes('not supported'));
assert.ok(msg.includes('list-artifacts'));
});
@@ -363,7 +362,7 @@ describe('phase-command-router — unknown subcommand', () => {
assert.ok(msg.includes('add'), `expected add in available list: ${msg}`);
assert.ok(msg.includes('complete'), `expected complete in available list: ${msg}`);
assert.ok(!msg.includes('list-plans'), `list-plans (SDK-only) must not appear in available list: ${msg}`);
assert.ok(!msg.includes('list-plans'), `list-plans (unsupported) must not appear in available list: ${msg}`);
});
});

6
tests/phases-command-router.test.cjs
View File

@@ -5,11 +5,7 @@ const assert = require('node:assert/strict');
const { routePhasesCommand } = require('../get-shit-done/bin/lib/phases-command-router.cjs');
// These tests exercise the CJS dispatch path of the router. Since #3577 the
// router prefers the SDK bridge when sdk/dist is present, which would bypass
// the mocked `phase`/`milestone` handlers below. The router gates SDK
// dispatch on `process.env.GSD_WORKSTREAM` being unset, so set it for these
// tests to deterministically take the CJS path that the mocks model.
// These tests exercise router dispatch with a deterministic runtime context.
let _prevWorkstream;
before(() => {
_prevWorkstream = process.env.GSD_WORKSTREAM;

6
tests/roadmap-command-router.test.cjs
View File

@@ -5,11 +5,7 @@ const assert = require('node:assert/strict');
const { routeRoadmapCommand } = require('../get-shit-done/bin/lib/roadmap-command-router.cjs');
// These tests exercise the CJS dispatch path of the router. Since #3577 the
// router prefers the SDK bridge when sdk/dist is present, which would bypass
// the mocked `roadmap` handlers below. The router gates SDK dispatch on
// `process.env.GSD_WORKSTREAM` being unset, so set it here to deterministically
// take the CJS path that the mocks model.
// These tests exercise router dispatch with a deterministic runtime context.
let _prevWorkstream;
before(() => {
_prevWorkstream = process.env.GSD_WORKSTREAM;