fix(init): ignore archived phases from prior milestones sharing a phase number (#2186)

When a new milestone reuses a phase number that exists in an archived
milestone (e.g., v2.0 Phase 2 while v1.0-phases/02-old-feature exists),
findPhaseInternal falls through to the archive and returns the old
phase. init plan-phase and init execute-phase then emitted archived
values for phase_dir, phase_slug, has_context, has_research, and
*_path fields, while phase_req_ids came from the current ROADMAP —
producing a silent inconsistency that pointed downstream agents at a
shipped phase from a previous milestone.

cmdInitPhaseOp already guarded against this (see lines 617-642);
apply the same guard in cmdInitPlanPhase, cmdInitExecutePhase, and
cmdInitVerifyWork: if findPhaseInternal returns an archived match
and the current ROADMAP.md has the phase, discard the archived
phaseInfo so the ROADMAP fallback path produces clean values.

Adds three regression tests covering plan-phase, execute-phase, and
verify-work under the shared-number scenario.
This commit is contained in:
Gabriel Rodrigues Garcia
2026-04-13 11:59:11 -03:00
committed by GitHub
parent c11ec05554
commit e6e33602c3
2 changed files with 100 additions and 0 deletions

View File

@@ -58,6 +58,16 @@ function cmdInitExecutePhase(cwd, phase, raw, options = {}) {
const roadmapPhase = getRoadmapPhaseInternal(cwd, phase);
// If findPhaseInternal matched an archived phase from a prior milestone, but
// the phase exists in the current milestone's ROADMAP.md, ignore the archive
// match — we are initializing a new phase in the current milestone that
// happens to share a number with an archived one. Without this, phase_dir,
// phase_slug and related fields would point at artifacts from a previous
// milestone.
if (phaseInfo?.archived && roadmapPhase?.found) {
phaseInfo = null;
}
// Fallback to ROADMAP.md if no phase directory exists yet
if (!phaseInfo && roadmapPhase?.found) {
const phaseName = roadmapPhase.phase_name;
@@ -181,6 +191,16 @@ function cmdInitPlanPhase(cwd, phase, raw, options = {}) {
const roadmapPhase = getRoadmapPhaseInternal(cwd, phase);
// If findPhaseInternal matched an archived phase from a prior milestone, but
// the phase exists in the current milestone's ROADMAP.md, ignore the archive
// match — we are planning a new phase in the current milestone that happens
// to share a number with an archived one. Without this, phase_dir,
// phase_slug, has_context and has_research would point at artifacts from a
// previous milestone.
if (phaseInfo?.archived && roadmapPhase?.found) {
phaseInfo = null;
}
// Fallback to ROADMAP.md if no phase directory exists yet
if (!phaseInfo && roadmapPhase?.found) {
const phaseName = roadmapPhase.phase_name;
@@ -552,6 +572,16 @@ function cmdInitVerifyWork(cwd, phase, raw) {
const config = loadConfig(cwd);
let phaseInfo = findPhaseInternal(cwd, phase);
// If findPhaseInternal matched an archived phase from a prior milestone, but
// the phase exists in the current milestone's ROADMAP.md, ignore the archive
// match — same pattern as cmdInitPhaseOp.
if (phaseInfo?.archived) {
const roadmapPhase = getRoadmapPhaseInternal(cwd, phase);
if (roadmapPhase?.found) {
phaseInfo = null;
}
}
// Fallback to ROADMAP.md if no phase directory exists yet
if (!phaseInfo) {
const roadmapPhase = getRoadmapPhaseInternal(cwd, phase);