fix(2129): exclude 999.x backlog phases from next-phase and all_complete (#2135)
* test(2129): add failing tests for 999.x backlog phase exclusion Bug A: phase complete reports 999.1 as next phase instead of 3 Bug B: init manager returns all_complete:false when only 999.x is incomplete Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(2129): exclude 999.x backlog phases from next-phase scan and all_complete check In cmdPhaseComplete, backlog phases (999.x) on disk were picked as the next phase when intervening milestone phases had no directory yet. Now the filesystem scan skips any directory whose phase number starts with 999. In cmdInitManager, all_complete compared completed count against the full phase list including 999.x stubs, making it impossible to reach true when backlog items existed. Now the check uses only non-backlog phases. Closes #2129 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -2330,6 +2330,83 @@ describe('phase complete updates Performance Metrics', () => {
|
||||
});
|
||||
});
|
||||
|
||||
// ─────────────────────────────────────────────────────────────────────────────
|
||||
// phase complete — backlog phase (999.x) exclusion (#2129)
|
||||
// ─────────────────────────────────────────────────────────────────────────────
|
||||
|
||||
describe('phase complete excludes 999.x backlog from next-phase (#2129)', () => {
|
||||
let tmpDir;
|
||||
|
||||
beforeEach(() => {
|
||||
tmpDir = createTempProject();
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup(tmpDir);
|
||||
});
|
||||
|
||||
test('next phase skips 999.x backlog dirs and falls back to roadmap', () => {
|
||||
// ROADMAP defines phases 1, 2, 3 and a backlog 999.1
|
||||
fs.writeFileSync(
|
||||
path.join(tmpDir, '.planning', 'ROADMAP.md'),
|
||||
[
|
||||
'# Roadmap',
|
||||
'',
|
||||
'- [ ] Phase 1: Setup',
|
||||
'- [ ] Phase 2: Core',
|
||||
'- [ ] Phase 3: Polish',
|
||||
'- [ ] Phase 999.1: Backlog idea',
|
||||
'',
|
||||
'### Phase 1: Setup',
|
||||
'**Goal:** Initial setup',
|
||||
'',
|
||||
'### Phase 2: Core',
|
||||
'**Goal:** Build core',
|
||||
'',
|
||||
'### Phase 3: Polish',
|
||||
'**Goal:** Polish everything',
|
||||
'',
|
||||
'### Phase 999.1: Backlog idea',
|
||||
'**Goal:** Parked idea',
|
||||
].join('\n')
|
||||
);
|
||||
fs.writeFileSync(
|
||||
path.join(tmpDir, '.planning', 'STATE.md'),
|
||||
[
|
||||
'# State',
|
||||
'',
|
||||
'**Current Phase:** 02',
|
||||
'**Status:** In progress',
|
||||
'**Current Plan:** 02-01',
|
||||
'**Last Activity:** 2025-01-01',
|
||||
'**Last Activity Description:** Working',
|
||||
].join('\n')
|
||||
);
|
||||
|
||||
// Phase 1 and 2 exist on disk, phase 3 does NOT exist yet, 999.1 DOES exist
|
||||
const p1 = path.join(tmpDir, '.planning', 'phases', '01-setup');
|
||||
fs.mkdirSync(p1, { recursive: true });
|
||||
fs.writeFileSync(path.join(p1, '01-01-PLAN.md'), '# Plan');
|
||||
fs.writeFileSync(path.join(p1, '01-01-SUMMARY.md'), '# Summary');
|
||||
|
||||
const p2 = path.join(tmpDir, '.planning', 'phases', '02-core');
|
||||
fs.mkdirSync(p2, { recursive: true });
|
||||
fs.writeFileSync(path.join(p2, '02-01-PLAN.md'), '# Plan');
|
||||
fs.writeFileSync(path.join(p2, '02-01-SUMMARY.md'), '# Summary');
|
||||
|
||||
// Backlog stub on disk — this is what triggers the bug
|
||||
fs.mkdirSync(path.join(tmpDir, '.planning', 'phases', '999.1-backlog-idea'), { recursive: true });
|
||||
|
||||
const result = runGsdTools('phase complete 2', tmpDir);
|
||||
assert.ok(result.success, `Command failed: ${result.error}`);
|
||||
|
||||
const output = JSON.parse(result.output);
|
||||
// Should find phase 3 from roadmap, NOT 999.1 from filesystem
|
||||
assert.strictEqual(output.next_phase, '3', 'next_phase should be 3, not 999.1');
|
||||
assert.strictEqual(output.is_last_phase, false, 'should not be last phase');
|
||||
});
|
||||
});
|
||||
|
||||
// ─────────────────────────────────────────────────────────────────────────────
|
||||
// milestone complete command
|
||||
// ─────────────────────────────────────────────────────────────────────────────
|
||||
|
||||
Reference in New Issue
Block a user