fix(config): prevent workflow.research reset during milestone transitions

Two bugs caused workflow.research to silently reset to false:

1. new-milestone.md unconditionally overwrote workflow.research via
   config-set after asking about research — coupling a per-milestone
   decision to a persistent user preference. Now the research question
   is per-invocation only; persistent config changes via /gsd:settings.

2. verify.cjs health repair (createConfig/resetConfig) used flat keys
   (research, plan_checker, verifier) instead of the canonical nested
   workflow object from config.cjs, also missing branch templates,
   nyquist_validation, and brave_search fields.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Maxim Brashenko
2026-03-15 21:08:59 +05:00
committed by GitHub
parent 63823c2e8a
commit eba9423ce0
4 changed files with 36 additions and 13 deletions

View File

@@ -86,21 +86,23 @@ Extract from init JSON: `researcher_model`, `synthesizer_model`, `roadmapper_mod
## 8. Research Decision
Check `research_enabled` from init JSON (loaded from config).
**If `research_enabled` is `true`:**
AskUserQuestion: "Research the domain ecosystem for new features before defining requirements?"
- "Research first (Recommended)" — Discover patterns, features, architecture for NEW capabilities
- "Skip research" — Go straight to requirements
- "Skip research for this milestone" — Go straight to requirements (does not change your default)
**Persist choice to config** (so future `/gsd:plan-phase` honors it):
**If `research_enabled` is `false`:**
```bash
# If "Research first": persist true
node "$HOME/.claude/get-shit-done/bin/gsd-tools.cjs" config-set workflow.research true
AskUserQuestion: "Research the domain ecosystem for new features before defining requirements?"
- "Skip research (current default)" — Go straight to requirements
- "Research first" — Discover patterns, features, architecture for NEW capabilities
# If "Skip research": persist false
node "$HOME/.claude/get-shit-done/bin/gsd-tools.cjs" config-set workflow.research false
```
**IMPORTANT:** Do NOT persist this choice to config.json. The `workflow.research` setting is a persistent user preference that controls plan-phase behavior across the project. Changing it here would silently alter future `/gsd:plan-phase` behavior. To change the default, use `/gsd:settings`.
**If "Research first":**
**If user chose "Research first":**
```
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━