Merge pull request #1372 from gsd-build/fix/agent-install-validation-1371
fix: detect missing GSD agents to prevent silent subagent_type fallback
This commit is contained in:
@@ -58,6 +58,7 @@
|
||||
* Validation:
|
||||
* validate consistency Check phase numbering, disk/roadmap sync
|
||||
* validate health [--repair] Check .planning/ integrity, optionally repair
|
||||
* validate agents Check GSD agent installation status
|
||||
*
|
||||
* Progress:
|
||||
* progress [json|table|bar] Render progress in various formats
|
||||
@@ -648,8 +649,10 @@ async function runCommand(command, args, cwd, raw) {
|
||||
} else if (subcommand === 'health') {
|
||||
const repairFlag = args.includes('--repair');
|
||||
verify.cmdValidateHealth(cwd, { repair: repairFlag }, raw);
|
||||
} else if (subcommand === 'agents') {
|
||||
verify.cmdValidateAgents(cwd, raw);
|
||||
} else {
|
||||
error('Unknown validate subcommand. Available: consistency, health');
|
||||
error('Unknown validate subcommand. Available: consistency, health, agents');
|
||||
}
|
||||
break;
|
||||
}
|
||||
|
||||
@@ -932,6 +932,58 @@ function getRoadmapPhaseInternal(cwd, phaseNum) {
|
||||
}
|
||||
}
|
||||
|
||||
// ─── Agent installation validation (#1371) ───────────────────────────────────
|
||||
|
||||
/**
|
||||
* Resolve the agents directory from the GSD install location.
|
||||
* gsd-tools.cjs lives at <configDir>/get-shit-done/bin/gsd-tools.cjs,
|
||||
* so agents/ is at <configDir>/agents/.
|
||||
*
|
||||
* @returns {string} Absolute path to the agents directory
|
||||
*/
|
||||
function getAgentsDir() {
|
||||
// __dirname is get-shit-done/bin/lib/ → go up 3 levels to configDir
|
||||
return path.join(__dirname, '..', '..', '..', 'agents');
|
||||
}
|
||||
|
||||
/**
|
||||
* Check which GSD agents are installed on disk.
|
||||
* Returns an object with installation status and details.
|
||||
*
|
||||
* @returns {{ agents_installed: boolean, missing_agents: string[], installed_agents: string[], agents_dir: string }}
|
||||
*/
|
||||
function checkAgentsInstalled() {
|
||||
const agentsDir = getAgentsDir();
|
||||
const expectedAgents = Object.keys(MODEL_PROFILES);
|
||||
const installed = [];
|
||||
const missing = [];
|
||||
|
||||
if (!fs.existsSync(agentsDir)) {
|
||||
return {
|
||||
agents_installed: false,
|
||||
missing_agents: expectedAgents,
|
||||
installed_agents: [],
|
||||
agents_dir: agentsDir,
|
||||
};
|
||||
}
|
||||
|
||||
for (const agent of expectedAgents) {
|
||||
const agentFile = path.join(agentsDir, `${agent}.md`);
|
||||
if (fs.existsSync(agentFile)) {
|
||||
installed.push(agent);
|
||||
} else {
|
||||
missing.push(agent);
|
||||
}
|
||||
}
|
||||
|
||||
return {
|
||||
agents_installed: installed.length > 0 && missing.length === 0,
|
||||
missing_agents: missing,
|
||||
installed_agents: installed,
|
||||
agents_dir: agentsDir,
|
||||
};
|
||||
}
|
||||
|
||||
// ─── Model alias resolution ───────────────────────────────────────────────────
|
||||
|
||||
/**
|
||||
@@ -1173,4 +1225,6 @@ module.exports = {
|
||||
filterSummaryFiles,
|
||||
getPhaseFileStats,
|
||||
readSubdirectories,
|
||||
getAgentsDir,
|
||||
checkAgentsInstalled,
|
||||
};
|
||||
|
||||
@@ -5,7 +5,7 @@
|
||||
const fs = require('fs');
|
||||
const path = require('path');
|
||||
const { execSync } = require('child_process');
|
||||
const { loadConfig, resolveModelInternal, findPhaseInternal, getRoadmapPhaseInternal, pathExistsInternal, generateSlugInternal, getMilestoneInfo, getMilestonePhaseFilter, stripShippedMilestones, extractCurrentMilestone, normalizePhaseName, planningPaths, planningDir, planningRoot, toPosixPath, output, error } = require('./core.cjs');
|
||||
const { loadConfig, resolveModelInternal, findPhaseInternal, getRoadmapPhaseInternal, pathExistsInternal, generateSlugInternal, getMilestoneInfo, getMilestonePhaseFilter, stripShippedMilestones, extractCurrentMilestone, normalizePhaseName, planningPaths, planningDir, planningRoot, toPosixPath, output, error, checkAgentsInstalled } = require('./core.cjs');
|
||||
|
||||
function getLatestCompletedMilestone(cwd) {
|
||||
const milestonesPath = path.join(planningRoot(cwd), 'MILESTONES.md');
|
||||
@@ -31,6 +31,12 @@ function getLatestCompletedMilestone(cwd) {
|
||||
*/
|
||||
function withProjectRoot(cwd, result) {
|
||||
result.project_root = cwd;
|
||||
// Inject agent installation status into all init outputs (#1371).
|
||||
// Workflows that spawn named subagents use this to detect when agents
|
||||
// are missing and would silently fall back to general-purpose.
|
||||
const agentStatus = checkAgentsInstalled();
|
||||
result.agents_installed = agentStatus.agents_installed;
|
||||
result.missing_agents = agentStatus.missing_agents;
|
||||
return result;
|
||||
}
|
||||
|
||||
|
||||
@@ -5,7 +5,7 @@
|
||||
const fs = require('fs');
|
||||
const path = require('path');
|
||||
const os = require('os');
|
||||
const { safeReadFile, loadConfig, normalizePhaseName, execGit, findPhaseInternal, getMilestoneInfo, stripShippedMilestones, extractCurrentMilestone, planningDir, planningRoot, output, error } = require('./core.cjs');
|
||||
const { safeReadFile, loadConfig, normalizePhaseName, execGit, findPhaseInternal, getMilestoneInfo, stripShippedMilestones, extractCurrentMilestone, planningDir, planningRoot, output, error, checkAgentsInstalled } = require('./core.cjs');
|
||||
const { extractFrontmatter, parseMustHavesBlock } = require('./frontmatter.cjs');
|
||||
const { writeStateMd } = require('./state.cjs');
|
||||
|
||||
@@ -699,6 +699,24 @@ function cmdValidateHealth(cwd, options, raw) {
|
||||
}
|
||||
} catch { /* intentionally empty */ }
|
||||
|
||||
// ─── Check 7c: Agent installation (#1371) ──────────────────────────────────
|
||||
// Verify GSD agents are installed. Missing agents cause Task(subagent_type=...)
|
||||
// to silently fall back to general-purpose, losing specialized instructions.
|
||||
try {
|
||||
const agentStatus = checkAgentsInstalled();
|
||||
if (!agentStatus.agents_installed) {
|
||||
if (agentStatus.installed_agents.length === 0) {
|
||||
addIssue('warning', 'W010',
|
||||
`No GSD agents found in ${agentStatus.agents_dir} — Task(subagent_type="gsd-*") will fall back to general-purpose`,
|
||||
'Run the GSD installer: npx get-shit-done-cc@latest');
|
||||
} else {
|
||||
addIssue('warning', 'W010',
|
||||
`Missing ${agentStatus.missing_agents.length} GSD agents: ${agentStatus.missing_agents.join(', ')} — affected workflows will fall back to general-purpose`,
|
||||
'Run the GSD installer: npx get-shit-done-cc@latest');
|
||||
}
|
||||
}
|
||||
} catch { /* intentionally empty — agent check is non-blocking */ }
|
||||
|
||||
// ─── Check 8: Run existing consistency checks ─────────────────────────────
|
||||
// Inline subset of cmdValidateConsistency
|
||||
if (fs.existsSync(roadmapPath)) {
|
||||
@@ -838,6 +856,24 @@ function cmdValidateHealth(cwd, options, raw) {
|
||||
}, raw);
|
||||
}
|
||||
|
||||
/**
|
||||
* Validate agent installation status (#1371).
|
||||
* Returns detailed information about which agents are installed and which are missing.
|
||||
*/
|
||||
function cmdValidateAgents(cwd, raw) {
|
||||
const { MODEL_PROFILES } = require('./model-profiles.cjs');
|
||||
const agentStatus = checkAgentsInstalled();
|
||||
const expected = Object.keys(MODEL_PROFILES);
|
||||
|
||||
output({
|
||||
agents_dir: agentStatus.agents_dir,
|
||||
agents_found: agentStatus.agents_installed,
|
||||
installed: agentStatus.installed_agents,
|
||||
missing: agentStatus.missing_agents,
|
||||
expected,
|
||||
}, raw);
|
||||
}
|
||||
|
||||
module.exports = {
|
||||
cmdVerifySummary,
|
||||
cmdVerifyPlanStructure,
|
||||
@@ -848,4 +884,5 @@ module.exports = {
|
||||
cmdVerifyKeyLinks,
|
||||
cmdValidateConsistency,
|
||||
cmdValidateHealth,
|
||||
cmdValidateAgents,
|
||||
};
|
||||
|
||||
Reference in New Issue
Block a user