From f32ffc9fb80f9d6689940f824ba1097d6a4d2e36 Mon Sep 17 00:00:00 2001
From: Tom Boucher <trekkie@nomorestars.com>
Date: Tue, 21 Apr 2026 20:33:43 -0400
Subject: [PATCH] fix(quick): include deferred-items.md in final commit file
 list (closes #2523) (#2542)

Step 8 file list omitted deferred-items.md, leaving executor out-of-scope
findings untracked after final commit even with commit_docs: true.

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 get-shit-done/workflows/quick.md             |  1 +
 tests/bug-2523-quick-deferred-items.test.cjs | 56 ++++++++++++++++++++
 2 files changed, 57 insertions(+)
 create mode 100644 tests/bug-2523-quick-deferred-items.test.cjs

diff --git a/get-shit-done/workflows/quick.md b/get-shit-done/workflows/quick.md
index 19265176d..e59f0bda2 100644
--- a/get-shit-done/workflows/quick.md
+++ b/get-shit-done/workflows/quick.md
@@ -892,6 +892,7 @@ Build file list:
 - If `$DISCUSS_MODE` and context file exists: `${QUICK_DIR}/${quick_id}-CONTEXT.md`
 - If `$RESEARCH_MODE` and research file exists: `${QUICK_DIR}/${quick_id}-RESEARCH.md`
 - If `$VALIDATE_MODE` and verification file exists: `${QUICK_DIR}/${quick_id}-VERIFICATION.md`
+- If `${QUICK_DIR}/${quick_id}-deferred-items.md` exists: `${QUICK_DIR}/${quick_id}-deferred-items.md`
 
 ```bash
 # Explicitly stage all artifacts before commit — PLAN.md may be untracked
diff --git a/tests/bug-2523-quick-deferred-items.test.cjs b/tests/bug-2523-quick-deferred-items.test.cjs
new file mode 100644
index 000000000..ca7e65c49
--- /dev/null
+++ b/tests/bug-2523-quick-deferred-items.test.cjs
@@ -0,0 +1,56 @@
+/**
+ * Regression test for bug #2523
+ *
+ * workflows/quick.md Step 8 ("Build file list") listed PLAN.md, SUMMARY.md,
+ * STATE.md, and mode-conditional CONTEXT.md / RESEARCH.md / VERIFICATION.md —
+ * but omitted deferred-items.md. When an executor logs out-of-scope findings
+ * to ${QUICK_DIR}/${quick_id}-deferred-items.md during task execution, that
+ * file was left untracked after the final commit even with commit_docs: true.
+ *
+ * Fix: add a file-existence-gated entry for deferred-items.md to Step 8.
+ */
+
+'use strict';
+
+const { test, describe } = require('node:test');
+const assert = require('node:assert/strict');
+const fs = require('fs');
+const path = require('path');
+
+const WORKFLOW_PATH = path.join(__dirname, '..', 'get-shit-done', 'workflows', 'quick.md');
+
+describe('bug #2523: quick-task final commit includes deferred-items.md', () => {
+  const content = fs.readFileSync(WORKFLOW_PATH, 'utf-8');
+
+  test('workflow file exists', () => {
+    assert.ok(fs.existsSync(WORKFLOW_PATH), 'get-shit-done/workflows/quick.md must exist');
+  });
+
+  test('Step 8 file list references deferred-items.md', () => {
+    const step8Idx = content.indexOf('Step 8: Final commit');
+    assert.notEqual(step8Idx, -1, 'Step 8 section must exist in quick.md');
+
+    const step8Section = content.slice(step8Idx, step8Idx + 2000);
+    assert.ok(
+      step8Section.includes('deferred-items.md'),
+      'Step 8 file list must include deferred-items.md. ' +
+      'Without this, any out-of-scope findings logged by the executor to ' +
+      '${QUICK_DIR}/${quick_id}-deferred-items.md are left untracked after commit (bug #2523).'
+    );
+  });
+
+  test('deferred-items.md entry is conditional on file existence', () => {
+    const deferredIdx = content.indexOf('deferred-items.md');
+    assert.notEqual(deferredIdx, -1, 'deferred-items.md must be mentioned in the workflow');
+
+    const surroundingContext = content.slice(Math.max(0, deferredIdx - 200), deferredIdx + 200);
+    const isConditional =
+      surroundingContext.toLowerCase().includes('exist') ||
+      surroundingContext.toLowerCase().includes('if ');
+    assert.ok(
+      isConditional,
+      'The deferred-items.md entry must be gated on file existence (not a mode flag). ' +
+      'deferred-items.md can be created in any quick-task run, regardless of mode.'
+    );
+  });
+});