From f656dcbd6ff244a8ac7d5886da864c5f08514009 Mon Sep 17 00:00:00 2001 From: Tom Boucher Date: Wed, 18 Mar 2026 23:43:28 -0400 Subject: [PATCH] =?UTF-8?q?chore:=20update=20CI=20matrix=20to=20Node=2020,?= =?UTF-8?q?=2022,=2024=20=E2=80=94=20drop=20EOL=20Node=2018?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Node 18 reached EOL April 2025. Node 24 is the current LTS target. Changes: - CI matrix: [18, 20, 22] → [20, 22, 24] - package.json engines: >=16.7.0 → >=20.0.0 - Removed Node 18 conditional in CI (c8 coverage works on all 20+) - Simplified CI to single test:coverage step for all versions 797/797 tests pass on Node 24. --- .github/workflows/test.yml | 10 +--------- package.json | 2 +- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 94fb64bb4..efda73dff 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -22,7 +22,7 @@ jobs: fail-fast: true matrix: os: [ubuntu-latest, macos-latest, windows-latest] - node-version: [18, 20, 22] + node-version: [20, 22, 24] steps: - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4 @@ -37,13 +37,5 @@ jobs: run: npm ci - name: Run tests with coverage - # c8 v11 requires Node 20+ (engines: ^20.0.0 || >=22.0.0). Node 18 EOL April 2025. - # Use bash on all platforms so shell glob expansion works on Windows. - if: matrix.node-version != 18 shell: bash run: npm run test:coverage - - - name: Run tests (Node 18, coverage not supported) - if: matrix.node-version == 18 - shell: bash - run: npm test diff --git a/package.json b/package.json index 5a11cfb12..5d31df501 100644 --- a/package.json +++ b/package.json @@ -36,7 +36,7 @@ "url": "https://github.com/glittercowboy/get-shit-done/issues" }, "engines": { - "node": ">=16.7.0" + "node": ">=20.0.0" }, "devDependencies": { "c8": "^11.0.0",