golem15/msd-core
4
0
Fork 0
Code Issues 1 Pull Requests Actions 3 Packages Projects Releases Wiki Activity

fix(manager): address review — withProjectRoot, milestone filter, planningPaths

Browse Source 
Fixes from trek-e's review on PR #1282:

1. Add missing withProjectRoot() wrapper on output — all other cmdInit*
   functions include project_root in JSON, manager was the only one without it.

2. Add getMilestonePhaseFilter() to directory scan — prevents stale phase
   directories from prior milestones appearing as phantom dashboard entries.

3. Replace hardcoded .planning/ paths with planningPaths(cwd) — forward
   compatibility with workstream scoping (#1268).

4. Add 3 new tests:
   - Conflict filter blocks dependent phase execution when dep is active
   - Conflict filter allows independent phase execution in parallel
   - Output includes project_root field

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
marcus.salinas
2026-03-21 09:13:32 -05:00
parent 5e5abe0961
commit f7031e2f20
2 changed files with 66 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
get-shit-done/bin/lib/init.cjs
View File

@@ -5,7 +5,7 @@
const fs = require('fs');
const path = require('path');
const { execSync } = require('child_process');
const { loadConfig, resolveModelInternal, findPhaseInternal, getRoadmapPhaseInternal, pathExistsInternal, generateSlugInternal, getMilestoneInfo, getMilestonePhaseFilter, stripShippedMilestones, extractCurrentMilestone, normalizePhaseName, toPosixPath, output, error } = require('./core.cjs');
const { loadConfig, resolveModelInternal, findPhaseInternal, getRoadmapPhaseInternal, pathExistsInternal, generateSlugInternal, getMilestoneInfo, getMilestonePhaseFilter, stripShippedMilestones, extractCurrentMilestone, normalizePhaseName, planningPaths, toPosixPath, output, error } = require('./core.cjs');
function getLatestCompletedMilestone(cwd) {
const milestonesPath = path.join(cwd, '.planning', 'MILESTONES.md');
@@ -765,19 +765,20 @@ function cmdInitManager(cwd, raw) {
const config = loadConfig(cwd);
const milestone = getMilestoneInfo(cwd);
// Use planningPaths for forward-compatibility with workstream scoping (#1268)
const paths = planningPaths(cwd);
// Validate prerequisites
if (!pathExistsInternal(cwd, '.planning/ROADMAP.md')) {
if (!fs.existsSync(paths.roadmap)) {
error('No ROADMAP.md found. Run /gsd:new-milestone first.');
}
if (!pathExistsInternal(cwd, '.planning/STATE.md')) {
if (!fs.existsSync(paths.state)) {
error('No STATE.md found. Run /gsd:new-milestone first.');
}
// Use roadmap analysis for rich phase data (depends_on, disk_status, has_context, etc.)
const roadmapPath = path.join(cwd, '.planning', 'ROADMAP.md');
const rawContent = fs.readFileSync(roadmapPath, 'utf-8');
const rawContent = fs.readFileSync(paths.roadmap, 'utf-8');
const content = extractCurrentMilestone(rawContent, cwd);
const phasesDir = path.join(cwd, '.planning', 'phases');
const phasesDir = paths.phases;
const isDirInMilestone = getMilestonePhaseFilter(cwd);
const phasePattern = /#{2,4}\s*Phase\s+(\d+[A-Z]?(?:\.\d+)*)\s*:\s*([^\n]+)/gi;
const phases = [];
@@ -810,7 +811,7 @@ function cmdInitManager(cwd, raw) {
try {
const entries = fs.readdirSync(phasesDir, { withFileTypes: true });
const dirs = entries.filter(e => e.isDirectory()).map(e => e.name);
const dirs = entries.filter(e => e.isDirectory()).map(e => e.name).filter(isDirInMilestone);
const dirMatch = dirs.find(d => d.startsWith(normalized + '-') || d === normalized);
if (dirMatch) {
@@ -1004,7 +1005,7 @@ function cmdInitManager(cwd, raw) {
state_exists: true,
};
output(result, raw);
output(withProjectRoot(cwd, result), raw);
}
function cmdInitProgress(cwd, raw) {