Part 1 of 2 of the n/no-process-exit cleanup (umbrella #738): convert every process.exit() call in standalone scripts/** CLIs to the rule-compliant pattern. - New shared helper scripts/lib/cli-exit.cjs: ExitError(code,message) + runMain() which translates a thrown ExitError / returned number into process.exitCode (never process.exit()), flushing output and still firing process.on('exit'). - main()-based entrypoints: throw new ExitError(code) for errors, return <code> for verdicts; invoked via runMain(main). Child exit codes preserved via return. - top-level-only scripts: imperative body extracted into main() so mid-flow aborts (throw ExitError) actually halt; pure consts/helpers stay at module scope. - diff-touches-shipped-paths.cjs: stdin event handling restructured to an async read so the whole flow runs under runMain; uncaughtException/unhandledRejection nets replaced by an in-band catch that preserves EXIT_ERROR=2. Exit codes verified unchanged for every converted script (success/error/help and the 0/1/2 semantic codes in diff-touches). Rule stays warn here; flipped to error in part 2 (#738) once gsd-core/bin/** is also clean. Refs #739 Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
@@ -33,6 +33,7 @@
|
||||
const { execFileSync } = require('child_process');
|
||||
const fs = require('fs');
|
||||
const path = require('path');
|
||||
const { ExitError, runMain } = require('./lib/cli-exit.cjs');
|
||||
|
||||
// Constructed with split to avoid self-match when this script is scanned.
|
||||
const FORBIDDEN = 'get-shit' + '-done';
|
||||
@@ -90,67 +91,70 @@ function isBinary(fullPath) {
|
||||
}
|
||||
}
|
||||
|
||||
// Enumerate tracked files via git ls-files so only committed/staged source is checked.
|
||||
let trackedFiles;
|
||||
try {
|
||||
trackedFiles = execFileSync('git', ['ls-files'], { cwd: REPO_ROOT, encoding: 'utf8' })
|
||||
.split('\n')
|
||||
.map((f) => f.trim())
|
||||
.filter(Boolean);
|
||||
} catch (err) {
|
||||
process.stderr.write('ERROR lint-legacy-dir-name: git ls-files failed: ' + err.message + '\n');
|
||||
process.exit(1);
|
||||
}
|
||||
|
||||
const violations = [];
|
||||
|
||||
for (const relPath of trackedFiles) {
|
||||
if (isAllowlisted(relPath)) continue;
|
||||
|
||||
const fullPath = path.join(REPO_ROOT, relPath);
|
||||
|
||||
// Skip this guard script itself.
|
||||
if (path.resolve(fullPath) === SELF_PATH) continue;
|
||||
|
||||
if (isBinary(fullPath)) continue;
|
||||
|
||||
let content;
|
||||
function main() {
|
||||
// Enumerate tracked files via git ls-files so only committed/staged source is checked.
|
||||
let trackedFiles;
|
||||
try {
|
||||
content = fs.readFileSync(fullPath, 'utf8');
|
||||
} catch {
|
||||
// Unreadable files (permissions, etc.) — skip silently.
|
||||
continue;
|
||||
trackedFiles = execFileSync('git', ['ls-files'], { cwd: REPO_ROOT, encoding: 'utf8' })
|
||||
.split('\n')
|
||||
.map((f) => f.trim())
|
||||
.filter(Boolean);
|
||||
} catch (err) {
|
||||
throw new ExitError(1, 'ERROR lint-legacy-dir-name: git ls-files failed: ' + err.message);
|
||||
}
|
||||
|
||||
const lines = content.split('\n');
|
||||
for (let i = 0; i < lines.length; i++) {
|
||||
const line = lines[i];
|
||||
// Skip lines that carry the explicit allow marker.
|
||||
if (line.includes(ALLOW_MARKER)) continue;
|
||||
const violations = [];
|
||||
|
||||
FORBIDDEN_RE.lastIndex = 0;
|
||||
let match;
|
||||
while ((match = FORBIDDEN_RE.exec(line)) !== null) {
|
||||
violations.push({
|
||||
file: relPath,
|
||||
line: i + 1,
|
||||
col: match.index + 1,
|
||||
text: match[0],
|
||||
});
|
||||
for (const relPath of trackedFiles) {
|
||||
if (isAllowlisted(relPath)) continue;
|
||||
|
||||
const fullPath = path.join(REPO_ROOT, relPath);
|
||||
|
||||
// Skip this guard script itself.
|
||||
if (path.resolve(fullPath) === SELF_PATH) continue;
|
||||
|
||||
if (isBinary(fullPath)) continue;
|
||||
|
||||
let content;
|
||||
try {
|
||||
content = fs.readFileSync(fullPath, 'utf8');
|
||||
} catch {
|
||||
// Unreadable files (permissions, etc.) — skip silently.
|
||||
continue;
|
||||
}
|
||||
|
||||
const lines = content.split('\n');
|
||||
for (let i = 0; i < lines.length; i++) {
|
||||
const line = lines[i];
|
||||
// Skip lines that carry the explicit allow marker.
|
||||
if (line.includes(ALLOW_MARKER)) continue;
|
||||
|
||||
FORBIDDEN_RE.lastIndex = 0;
|
||||
let match;
|
||||
while ((match = FORBIDDEN_RE.exec(line)) !== null) {
|
||||
violations.push({
|
||||
file: relPath,
|
||||
line: i + 1,
|
||||
col: match.index + 1,
|
||||
text: match[0],
|
||||
});
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
if (violations.length === 0) {
|
||||
process.stdout.write('ok lint-legacy-dir-name: ' + trackedFiles.length + ' tracked file(s) checked, 0 violations\n');
|
||||
return 0;
|
||||
}
|
||||
|
||||
process.stderr.write('\nERROR lint-legacy-dir-name: ' + violations.length + ' violation(s) found\n\n');
|
||||
for (const v of violations) {
|
||||
process.stderr.write(' ' + v.file + ':' + v.line + ':' + v.col + ' — ' + JSON.stringify(v.text) + '\n');
|
||||
}
|
||||
process.stderr.write('\n');
|
||||
process.stderr.write('Fix: rename to gsd-core, or add `gsd-allow-legacy-name` marker on the line if the\n');
|
||||
process.stderr.write(' use is intentional (migration modules, tests, guard, changeset).\n\n');
|
||||
return 1;
|
||||
}
|
||||
|
||||
if (violations.length === 0) {
|
||||
process.stdout.write('ok lint-legacy-dir-name: ' + trackedFiles.length + ' tracked file(s) checked, 0 violations\n');
|
||||
process.exit(0);
|
||||
}
|
||||
|
||||
process.stderr.write('\nERROR lint-legacy-dir-name: ' + violations.length + ' violation(s) found\n\n');
|
||||
for (const v of violations) {
|
||||
process.stderr.write(' ' + v.file + ':' + v.line + ':' + v.col + ' — ' + JSON.stringify(v.text) + '\n');
|
||||
}
|
||||
process.stderr.write('\n');
|
||||
process.stderr.write('Fix: rename to gsd-core, or add `gsd-allow-legacy-name` marker on the line if the\n');
|
||||
process.stderr.write(' use is intentional (migration modules, tests, guard, changeset).\n\n');
|
||||
process.exit(1);
|
||||
runMain(main);
|
||||
|
||||
Reference in New Issue
Block a user