51
tests/workstream-name-policy.test.cjs
Normal file
51
tests/workstream-name-policy.test.cjs
Normal file
@@ -0,0 +1,51 @@
|
||||
const { describe, test } = require('node:test');
|
||||
const assert = require('node:assert/strict');
|
||||
|
||||
const {
|
||||
normalizeWorkstreamNameInput,
|
||||
validateActiveWorkstreamName,
|
||||
assertValidActiveWorkstreamName,
|
||||
isValidActiveWorkstreamName,
|
||||
INVALID_ACTIVE_WORKSTREAM_NAME_MESSAGE,
|
||||
} = require('../get-shit-done/bin/lib/workstream-name-policy.cjs');
|
||||
|
||||
describe('workstream-name-policy', () => {
|
||||
test('normalizeWorkstreamNameInput trims and nulls empty input', () => {
|
||||
assert.equal(normalizeWorkstreamNameInput(' alpha '), 'alpha');
|
||||
assert.equal(normalizeWorkstreamNameInput(' '), null);
|
||||
assert.equal(normalizeWorkstreamNameInput(null), null);
|
||||
});
|
||||
|
||||
test('validateActiveWorkstreamName returns structured validation', () => {
|
||||
assert.deepEqual(
|
||||
validateActiveWorkstreamName('alpha_1'),
|
||||
{ ok: true, reason: null, value: 'alpha_1' }
|
||||
);
|
||||
assert.deepEqual(
|
||||
validateActiveWorkstreamName('alpha beta'),
|
||||
{ ok: false, reason: 'invalid', value: 'alpha beta' }
|
||||
);
|
||||
assert.deepEqual(
|
||||
validateActiveWorkstreamName('../alpha'),
|
||||
{ ok: false, reason: 'invalid', value: '../alpha' }
|
||||
);
|
||||
assert.deepEqual(
|
||||
validateActiveWorkstreamName(' '),
|
||||
{ ok: false, reason: 'empty', value: null }
|
||||
);
|
||||
});
|
||||
|
||||
test('assertValidActiveWorkstreamName returns normalized value and throws canonical error', () => {
|
||||
assert.equal(assertValidActiveWorkstreamName(' alpha '), 'alpha');
|
||||
assert.throws(
|
||||
() => assertValidActiveWorkstreamName('alpha/beta'),
|
||||
new RegExp(INVALID_ACTIVE_WORKSTREAM_NAME_MESSAGE.replace(/[.*+?^${}()|[\]\\]/g, '\\$&'))
|
||||
);
|
||||
});
|
||||
|
||||
test('isValidActiveWorkstreamName accepts canonical and rejects invalid names', () => {
|
||||
assert.equal(isValidActiveWorkstreamName('alpha-1'), true);
|
||||
assert.equal(isValidActiveWorkstreamName('ws..traversal'), false);
|
||||
assert.equal(isValidActiveWorkstreamName('alpha beta'), false);
|
||||
});
|
||||
});
|
||||
@@ -795,6 +795,26 @@ describe('path traversal rejection', () => {
|
||||
}
|
||||
});
|
||||
|
||||
describe('cmdWorkstreamStatus rejects invalid names consistently', () => {
|
||||
for (const name of maliciousNames) {
|
||||
test(`rejects status ${name}`, () => {
|
||||
const result = runGsdTools(['workstream', 'status', name, '--raw'], tmpDir);
|
||||
assert.ok(!result.success, `status should reject invalid name: ${name}`);
|
||||
assert.ok(result.error.includes('Invalid workstream name'), `error should mention invalid name for: ${name}`);
|
||||
});
|
||||
}
|
||||
});
|
||||
|
||||
describe('cmdWorkstreamComplete rejects invalid names consistently', () => {
|
||||
for (const name of maliciousNames) {
|
||||
test(`rejects complete ${name}`, () => {
|
||||
const result = runGsdTools(['workstream', 'complete', name, '--raw'], tmpDir);
|
||||
assert.ok(!result.success, `complete should reject invalid name: ${name}`);
|
||||
assert.ok(result.error.includes('Invalid workstream name'), `error should mention invalid name for: ${name}`);
|
||||
});
|
||||
}
|
||||
});
|
||||
|
||||
describe('getActiveWorkstream rejects poisoned active-workstream file', () => {
|
||||
for (const name of maliciousNames) {
|
||||
test(`rejects poisoned file containing ${name}`, () => {
|
||||
|
||||
Reference in New Issue
Block a user