fix(#892): parse checklist-style roadmap phases in validate/verify (#908)

buildRoadmapPhaseVariants() only matched heading-style phases (## Phase N:),
silently skipping the supported checklist format (- [x] **Phase N: name**).
This caused W007 false-positives for every on-disk phase dir when the project
uses a checklist ROADMAP. Fix adds a second regex pass (mirroring the existing
buildNotStartedPhaseVariants() approach). Also refactors the duplicate
inline heading-only regex in cmdValidateConsistency() to delegate to
buildRoadmapPhaseVariants() (DRY). Regression test in
tests/bug-892-validate-checklist-roadmap-phases.test.cjs covers both paths.

Closes #892

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
(cherry picked from commit 808df9110c)
This commit is contained in:
Tom Boucher
2026-06-08 22:52:19 -04:00
committed by github-actions[bot]
parent de632addd4
commit fe5c9c0527
5 changed files with 316 additions and 22 deletions

View File

@@ -130,6 +130,14 @@
"install.test.cjs"
],
"issue": "TBD"
},
"validate": {
"files": [
"bug-3129-validate-commit-git-bypass.test.cjs",
"bug-892-validate-checklist-roadmap-phases.test.cjs",
"validate-context.test.cjs"
],
"issue": "892"
}
}
}