From fee72d55604461b86176ee970357f358e8b05cc9 Mon Sep 17 00:00:00 2001 From: Tom Boucher Date: Thu, 6 Aug 2026 11:34:31 -0400 Subject: [PATCH] fix(#3044): add zh-CN verification-patterns.md to secret-scan exclusions (#3122) * fix(#3044): add zh-CN verification-patterns.md to secret-scan exclusions The translated document carries the same illustrative placeholder examples (Stripe test-key, database-URL, API-key) as the English source, which is already excluded. The exclusion was never extended to the zh-CN translation, causing the strict-mode scan to fail. No other locale has a translation of this file (verified: ja-JP, ko-KR, pt-BR do not have it). * chore(#3044): backfill changeset PR number 3122 --------- Co-authored-by: sim --- .changeset/rapid-cranes-wander.md | 5 +++++ .secretscanignore | 2 ++ 2 files changed, 7 insertions(+) create mode 100644 .changeset/rapid-cranes-wander.md diff --git a/.changeset/rapid-cranes-wander.md b/.changeset/rapid-cranes-wander.md new file mode 100644 index 000000000..b8badd8f2 --- /dev/null +++ b/.changeset/rapid-cranes-wander.md @@ -0,0 +1,5 @@ +--- +type: Fixed +pr: 3122 +--- +**Secret-scan no longer reports a false positive on the zh-CN verification-patterns translation** — the translated document carries the same illustrative placeholder examples as its English source, but the exclusion was never extended to the translation. The strict-mode scan now passes. (#3044) diff --git a/.secretscanignore b/.secretscanignore index a5abbde12..00fa12e1f 100644 --- a/.secretscanignore +++ b/.secretscanignore @@ -28,3 +28,5 @@ gsd-core/workflows/plan-phase.md # allow: gsd-core/references/verification-patterns.md reason="documents stub/placeholder RED-FLAG examples for env vars (illustrative Stripe test-key, database-URL and API-key placeholders shown as what NOT to ship) — not real credentials" owner="@open-gsd/maintainers" expires="2027-06-30" gsd-core/references/verification-patterns.md +# allow: docs/zh-CN/references/verification-patterns.md reason="translated copy of the English verification-patterns.md — carries the same illustrative placeholder examples (Stripe test-key, database-URL, API-key) as what NOT to ship" owner="@open-gsd/maintainers" expires="2027-06-30" +docs/zh-CN/references/verification-patterns.md