* chore(#2994): fragmentize progress.md forensic audit onto the fragment model Extract the --forensic-gated forensic_audit step to workflows/progress/steps/forensic-audit.md behind a section marker, and repair progress.md's init line to forward --forensic so the atom is actually true in production rather than only under direct CLI tests. progress.md shrinks 32630 -> 27207 bytes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * chore(#2994): fragmentize the four manifest-wired workflows new-project, quick, new-milestone and progress each already had a dedicated cmdInit* entry point but zero marked sections. Extract nine gated bodies to workflows/<wf>/steps/ behind section markers and repair each init line to forward its flags. Fold --full into the discuss/research/validate facts inside cmdInitQuick so the when= grammar never sees an OR, per the chunked-mode precedent. Fixes found while working, per the no-defer rule: - cmdInitProgress passed no phase info to buildSectionManifestField, so state:phase-mvp-mode was permanently false — an atom in the vocabulary whose fact could never be computed. - the quick init router folded flag tokens into the free-text description, which the new forwarding would have corrupted. - a #2508 dispatch note was nested inside quick.md's Agent(prompt=) fence, leaking orchestrator guidance into the subagent prompt. - progress.md had a 3-vs-4 backtick outer-fence imbalance. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * chore(#2994): fragmentize verify-work.md and admit state:ui-phase-active Wire cmdInitVerifyWork to buildSectionManifestField — it was a dedicated entry point that never emitted a manifest — and mark two sections. state:ui-phase-active folds (plan:pre hooks include an active ui step) OR (the phase dir holds a *-UI-SPEC.md) into one boolean in init.cts, so the grammar still sees a single operator-free atom. The inner Playwright-MCP check stays as prose inside the fragment: it is live session state and no init seam can precompute it. The MVP false-branch note is a real fallback, not redundant prose, so it sits outside the marker — gating it away would delete the text needed precisely when MVP mode is off. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * test(#2994): follow moved workflow content in drift guards Retarget every guard that asserted on content this branch moved into workflows/<wf>/steps/, mirroring 815b3d897. Each retargeted assertion was verified to still fail when its step file is blanked, so none was weakened into vacuity. Three assertions in verify-mvp-uat were genuinely red. Three more were worse than red — passing for the wrong reason: - quick-commit-boundary and worktree-cleanup anchored on indexOf('Step 5.6'), which matched a later cross-reference and sliced 16069 chars that coincidentally held the asserted substrings. Replaced with an expandWorkflowSections helper that splices step content back in place. - phase6-review-capabilities lost its end boundary and widened to EOF. - playwright-ui-verify matched 'UI' in an unrelated bullet and 'fall back' in a subagent-dispatch line after the real content moved. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * chore(#2994): fragmentize code-review and complete-milestone, admit three atoms Add dedicated cmdInitCodeReview and cmdInitCompleteMilestone entry points alongside the shared generic ones rather than modifying them — init.phase-op and init.manager carry a CRITICAL blast radius (179 dependents, 24 processes) and stay byte-identical for their other callers. Admit flag:--fix, state:fallow-enabled and state:git-create-tag, each with a consuming section and a fact its own entry point computes. Both sections had the resolver-in-body hazard: the fallow config-gate and the git.create_tag check each sat inside the very block being gated, so gating would have disabled the resolver that decides the gate. Both are hoisted into init and the bodies now consume the resolved fact. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * test(#2994): retarget code-review and milestone drift guards, fix two red tests Retarget guards that asserted on content moved into steps/, proving non-vacuity by blanking each step file and confirming failure. Also fixes two genuinely red tests found while working, per the no-defer rule: - workflow-fragments' frozen-vocabulary lock was missing state:ui-phase-active, so commit 7ef7f8336 shipped red. Lint and build both passed over it, which is why neither is sufficient verification. - code-review's quick.md capability-hook assertion carried a stale delimiter after the 18ff35d20 extraction. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * chore(#2994): fragmentize autonomous.md and admit state:plan-strategy-converge Five sections share one atom, the pattern plan-phase already uses for flag:--research-phase. The atom folds --converge OR --cross-ai into a single boolean in cmdInitAutonomous so the grammar stays operator-free. cmdInitAutonomous is additive; init.milestone-op, init.manager and init.phase-op are untouched and still consumed. The $PLAN_STRATEGY bash resolver is deliberately retained — ungated local-planning bullets still read it, so the init-side fact supplements it rather than replacing it. converge-fail-fast required splitting one bash fence so the always-run CONVERGENCE_ARGS construction stays outside the marker. All three flag-absent fallbacks were left outside their markers. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * chore(#2994): fragmentize review and discuss-phase-assumptions Admit state:reviewer-instances-configured (two peripheral notes share it; the core reviewer-lane dispatch stays unmarked — it is the workflow's primary always-evaluated logic, not an optional branch) and state:auto-advance-active, which folds --auto OR two config keys into one boolean so the grammar stays operator-free. discuss-phase-assumptions was the highest-risk edit in this PR. Its auto_advance step is a full if/elif/else; gating it whole would have deleted the flag-absent fallback needed exactly when --auto is off. Split verified exact: resolvers 636-651 and the 'End here' fallback 668-669 both stay outside the marker; only 653-667 is gated. Adds emitted-drift acks for the two files that grew — review.md (+55 B) and autonomous.md (+737 B from 80799211c, which had none and would have red-gated the push. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * chore(#2994): fragmentize docs-update, update, transition and new-milestone Part A Completes the 13-workflow rollout. Three of these had no init call at all and gained a dedicated entry point plus their first gsd_run query line. Admits state:is-monorepo and adds state:next-channel, state:workstream-active and state:flat-mode. Vocabulary 26 -> 30 atoms. Part A of new-milestone applies when NO workstream is active — the negation of state:workstream-active. Rather than teach the grammar negation, which is the Greenspun drift the frozen list exists to prevent, it gets a separate positively-phrased atom whose fact is the inverse. Part B, which always runs, stays outside the marker. flag:--verify-only is deliberately NOT admitted: docs-update has no contiguous purely-additive region for it, and an atom without a consuming section is dead vocabulary. Evidence recorded in the slice report. update.md reuses its existing resolved $GSD_TOOLS rather than prepending the canonical preamble, which would have clobbered it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix(#2994): stop automated-ui-verification re-resolving its own gate, retire dead vocabulary Two defects the new tests caught. The automated-ui-verification step re-ran gsd_run loop render-hooks and recomputed UI_PHASE_ACTIVE inside a body that is only read when that fact is already true — the circular self-disabling pattern this design forbids, introduced by 3c654b168. cmdInitVerifyWork now exposes ui_phase_active and the step consumes it. Its launcher preamble goes too: no gsd_run remains. The Playwright-MCP check stays as prose — that is live session state. Dead vocabulary predating this PR: flag:--full and state:needs-codebase-map were admitted with a gate-1 claim that never materialized. flag:--full is removed, redundant once quick folds it into discuss/research/validate. state:needs-codebase-map gets the real consumer it always lacked, gating new-project's codebase-map offer. Vocabulary 30 -> 29, and no atom is now without a consuming section. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * test(#2994): add the atom-admission, inversion and resolver-hoist gates The two existing parity guards prove vocabulary/predicate symmetry but never that a fact is computed — an atom no cmdInit* assembles evaluates false forever. These close that hole: - per-atom satisfiability for all 29 atoms, plus an anti-vacuity assertion so the loop cannot silently cover zero atoms - dead-vocabulary check against the shipped manifest - inversion guard: the flag-absent fallbacks in discuss-phase-assumptions and verify-work must stay outside their markers - data-driven resolver-hoist guard over the shipped manifest, so a future extraction cannot reintroduce the circular class - compound-fold coverage (--full, --cross-ai, --rc, config-only --auto) - null-vs-[] degraded/computed distinction, and flag value shapes Also repairs the frozen-vocabulary lock, which was stale and red for the seven atoms earlier commits on this branch shipped. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * docs(#2994): add changeset for the fragment-model rollout Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * test(#2994): cite the issue on the two new allow-test-rule exemptions ADR-456 requires an issue ref on the same line as the annotation. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * docs(#2994): correct the atom-count claims after retiring flag:--full The vocabulary doc comments still said 30 entries; it is 29 since flag:--full was removed as dead vocabulary. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix(#2994): dedupe the phase-fallback block and harden --ws parsing Review findings. MAJOR: the three new init entry points each pasted a verbatim copy of the guardedFindPhase/guardedGetRoadmapPhase fallback, taking the repo from four copies to seven — DEFECT.GENERATIVE-FIX. Extracted applyRoadmapFallback and folded six of the seven; each call site keeps its own field-set via a closure. Duplication removed rather than papered over with a parity test. cmdInitPhaseOp stays out: its fallback omits has_reviews, so it is not a byte-identical copy, and it is CRITICAL-radius. LOW, pre-existing: GSD_WS captured [^[:space:]]+ and expands unquoted, so a workstream name holding glob metacharacters would expand against the filesystem. Narrowed to [A-Za-z0-9._-]+. The unquoted expansion is kept — it must word-split into two args and vanish when empty. Also restores the vocabulary ordering convention, and fixes a masked test bug the mandated run surfaced: the flag-forwarding guard checked only the first init line per workflow, but new-milestone has two, so a real failure was reporting exit 0. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix(#2994): drop the stale new-milestone emitted-drift ack new-milestone.md was acked for a +406 B growth measured against an intermediate commit. Net against origin/next it SHRANK by 8 bytes, so nothing needed the ack and it explained nothing — which the differential attribution check reports as a stale acknowledgment, not a pass. update.md's entry stays: it genuinely grew +703 B. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix(#2994): resolve the 15 failures from the full matrix run All 15 were real and identical on both lanes. REAL REGRESSION: autonomous.md hit 41479 chars against the #2196 guard's 40960 cap — a CHARS cap distinct from the LARGE tier byte cap, which the five section stubs pushed it over. Extracted the 3a.5 UI Design Contract body to references/; now 39968 chars, and the file nets -795 B vs base, so its growth ack is deleted rather than left stale. REAL DEFECT: docs referenced /gsd-transition, which is not a live registered command. Reworded. STALE FIXTURE: the emission byte-identity test hardcoded two marked workflows; this branch legitimately marks fifteen. Fixture corrected — the source was right. The rest were drift guards over the eight workflows the earlier sweep did not cover, retargeted at where the content now lives with non-vacuity proven by blanking each step file and confirming failure. The GSD_WS forwarding guard was checked as a possible real break and is not one: the charclass narrowing is intact and forwarding works end to end. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix(#2994): drop the ack for a newly-added reference file A new file's emitted ripple is attributable to the diff that adds it, so the acknowledgment explained nothing and the differential check reports it as stale. Removing the last entry removes the fragment — an empty one signals nothing. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix(#2994): retarget the UI-contract guards and clear two transitive advisories The §3a.5 extraction that brought autonomous.md under the #2196 char cap moved its body to references/autonomous-ui-design-contract.md, so ten guards in autonomous-ui-steps and check-ui-safety-gate were asserting it against the host. Retargeted via a combined read, each proven non-vacuous by blanking the reference file and confirming failure. This class had already bitten twice on this branch because each sweep was scoped to the workflows touched at that moment, so this one was exhaustive: ~70 test files across all 13 workflows, zero further broken or vacuous assertions found. Also clears two high transitive advisories the matrix flagged on one lane — fast-uri GHSA-7p8r-x3mc-p8w7 and three ip-address SSRF/trust-boundary issues. Both pre-date this branch: package-lock.json was untouched until now, so the production tree was byte-identical to the base. Lockfile-only, package.json unchanged, verified against a real npm ci install. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * chore(#2994): backfill changeset pr number to 3030 --------- Co-authored-by: sim <sim@local> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Tom Boucher
@@ -46,9 +46,22 @@ gap fragment and composes back byte-identical to its source.
|
||||
|
||||
## The frozen `when=` vocabulary
|
||||
|
||||
`when=` takes exactly one of 19 atoms (widened from 4 to 14 via the ADR-1671
|
||||
`when=` takes exactly one of 29 atoms (widened from 4 to 14 via the ADR-1671
|
||||
amendment for #2992, epic #1671 Phase 6.1, then from 14 to 19 via the
|
||||
ADR-1671 amendment for #2993, epic #1671 Phase 6.2):
|
||||
ADR-1671 amendment for #2993, epic #1671 Phase 6.2, then from 19 to 20 via
|
||||
the ADR-1671 amendment for #2994, epic #1671 Phase 6.3, then from 20 to 23
|
||||
via a further #2994 amendment fragmentizing `code-review.md` and
|
||||
`complete-milestone.md`, then from 23 to 24 via a still further #2994
|
||||
amendment fragmentizing `autonomous.md`, then from 24 to 26 via a still
|
||||
further #2994 amendment fragmentizing `review.md` and
|
||||
`discuss-phase-assumptions.md`, then from 26 to 30 via the FINAL #2994
|
||||
amendment fragmentizing `docs-update.md`, `update.md`, `transition.md`, and
|
||||
`new-milestone.md` — the last four of the 13 workflows targeted by
|
||||
ADR-1671 — then from 30 to 29 via a dead-vocabulary cleanup: `flag:--full`
|
||||
was removed (no `when=` marker ever consumed it — `quick.md` folds `--full`
|
||||
into the `--discuss`/`--research`/`--validate` facts before evaluation) and
|
||||
`state:needs-codebase-map` gained its first real consumer,
|
||||
`new-project.md`'s `codebase-map-offer` section):
|
||||
|
||||
| Value | Meaning |
|
||||
|---|---|
|
||||
@@ -58,8 +71,8 @@ ADR-1671 amendment for #2993, epic #1671 Phase 6.2):
|
||||
| `state:has-prior-phases` | Applicable when prior phases (and their `VERIFICATION.md` files) exist. |
|
||||
| `flag:--auto` | Applicable when the workflow runs with `--auto`. |
|
||||
| `flag:--discuss` | Applicable when the workflow runs with `--discuss`. |
|
||||
| `flag:--fix` | Applicable when the workflow runs with `--fix` (`code-review.md`'s resolved fix decision — `--fix` itself, or `--all`/`--auto` implying it via `code-review-flags.cjs`). |
|
||||
| `flag:--forensic` | Applicable when the workflow runs with `--forensic`. |
|
||||
| `flag:--full` | Applicable when the workflow runs with `--full`. |
|
||||
| `flag:--ingest` | Applicable when the workflow runs with `--ingest <path-or-glob>`. |
|
||||
| `flag:--prd` | Applicable when the workflow runs with `--prd <file>`. |
|
||||
| `flag:--research` | Applicable when the workflow runs with `--research`. |
|
||||
@@ -67,9 +80,19 @@ ADR-1671 amendment for #2993, epic #1671 Phase 6.2):
|
||||
| `flag:--reset-phase-numbers` | Applicable when the workflow runs with `--reset-phase-numbers`. |
|
||||
| `flag:--reviews` | Applicable when the workflow runs with `--reviews`. |
|
||||
| `flag:--validate` | Applicable when the workflow runs with `--validate`. |
|
||||
| `state:auto-advance-active` | Applicable when `discuss-phase-assumptions.md`'s `auto_advance` step should dispatch — `--auto` flag OR a consolidated auto-mode config fact (see [Compound conditions are resolved in the fact, never the grammar](#compound-conditions-are-resolved-in-the-fact-never-the-grammar) below). |
|
||||
| `state:chunked-mode` | Applicable when chunked planning mode is active — see [Compound conditions are resolved in the fact, never the grammar](#compound-conditions-are-resolved-in-the-fact-never-the-grammar) below. |
|
||||
| `state:fallow-enabled` | Applicable when `.planning/config.json`'s `code_quality.fallow.enabled` is `true` (fail-closed default `false`). |
|
||||
| `state:flat-mode` | Applicable when NO workstream is active — the positively-phrased inverse of `state:workstream-active` (the grammar has no negation operator). |
|
||||
| `state:git-create-tag` | Applicable when `.planning/config.json`'s `git.create_tag` is not `false` (fail-OPEN default `true`). |
|
||||
| `state:is-monorepo` | Applicable when the project's `monorepo_workspaces` list is non-empty. |
|
||||
| `state:needs-codebase-map` | Applicable when a codebase map is needed (init-computed). |
|
||||
| `state:next-channel` | Applicable when `update.md`'s release channel is `next` — the workflow runs with `--next`, or its documented alias `--rc`. |
|
||||
| `state:phase-mvp-mode` | Applicable when the current phase's `ROADMAP.md` entry declares `**Mode:** mvp`. |
|
||||
| `state:plan-strategy-converge` | Applicable when `autonomous.md`'s planning step should route through plan-review convergence instead of `gsd-plan-phase` — the workflow runs with `--converge`, or its documented alias `--cross-ai` (`autonomous.md`'s own `PLAN_STRATEGY` resolver folds both). |
|
||||
| `state:reviewer-instances-configured` | Applicable when `.planning/config.json`'s `review.reviewer_instances` is present AND non-empty. |
|
||||
| `state:ui-phase-active` | Applicable when the phase's active `plan:pre` loop hooks include the `ui-phase` step, OR the phase directory already contains a `*-UI-SPEC.md` file — see [Compound conditions are resolved in the fact, never the grammar](#compound-conditions-are-resolved-in-the-fact-never-the-grammar) below. |
|
||||
| `state:workstream-active` | Applicable when a workstream is active — `GSD_WORKSTREAM` env, falling back to the stored active-workstream pointer. |
|
||||
| `state:worktrees-enabled` | Applicable when `.planning/config.json`'s `workflow.use_worktrees` is enabled. |
|
||||
|
||||
This list is **closed by design** (Greenspun's Tenth Rule): left open-ended,
|
||||
@@ -97,13 +120,44 @@ required:
|
||||
section marked with it would silently never include: the exact
|
||||
silent-wrong-answer class this gate exists to prevent.
|
||||
|
||||
Six further atoms (`flag:--converge`, `flag:--fix`, `flag:--verify-only`,
|
||||
`state:fallow-enabled`, `state:git-create-tag`, `state:is-monorepo`) satisfy
|
||||
gate 1 but not yet gate 2 — their workflows (`autonomous`, `code-review`,
|
||||
`complete-milestone`, `docs-update`) route through shared generic init entry
|
||||
points invoked by 20+ other workflows, so a dedicated `cmdInit*` seam does
|
||||
not yet exist to compute their facts. They are withheld pending that seam,
|
||||
not rejected.
|
||||
One further atom, `flag:--verify-only`, is surveyed but NOT admitted even now
|
||||
that `docs-update` has its own dedicated `cmdInit*` entry point
|
||||
(`cmdInitDocsUpdate`) — it fails gate 1, not gate 2: the flag's control flow
|
||||
is INTERLEAVED across three non-contiguous touch-points in `docs-update.md`
|
||||
(an inline early-exit check in `init_context`, a "Skip condition" note
|
||||
embedded in another step's body, and the `verify_only_report` step itself)
|
||||
rather than a single contiguous, whole-line, purely-additive region.
|
||||
Admitting the atom to gate only the `verify_only_report` step would leave
|
||||
the other two touch-points as un-migrated raw `$ARGUMENTS` checks — an atom
|
||||
whose consuming section covers only PART of the flag's real behavior is not
|
||||
a clean win. `state:is-monorepo` IS admitted (`dispatch-monorepo-packages`
|
||||
section, `cmdInitDocsUpdate`) — see [Piloted on execute-phase.md, then rolled
|
||||
out across the wired
|
||||
workflows](#piloted-on-execute-phasemd-then-rolled-out-across-the-wired-workflows)
|
||||
below. `flag:--fix`, `state:fallow-enabled`, and
|
||||
`state:git-create-tag` were withheld for the same reason until a further
|
||||
#2994 amendment gave `code-review` and `complete-milestone` their own
|
||||
dedicated `cmdInit*` entry points (`cmdInitCodeReview`,
|
||||
`cmdInitCompleteMilestone`) — see [Piloted on execute-phase.md, then rolled
|
||||
out across the wired
|
||||
workflows](#piloted-on-execute-phasemd-then-rolled-out-across-the-wired-workflows)
|
||||
below. A third atom, originally surveyed as `flag:--converge`, was withheld
|
||||
for the same reason and never shipped under that name: a still further
|
||||
#2994 amendment gave `autonomous` its own dedicated `cmdInit*` entry point
|
||||
(`cmdInitAutonomous`), and the atom that shipped is
|
||||
`state:plan-strategy-converge` instead — `--cross-ai` is a documented alias
|
||||
for `--converge` (`autonomous.md`'s own `PLAN_STRATEGY` resolver folds
|
||||
both), so a `flag:--converge`-only atom would have left a `--cross-ai`-only
|
||||
invocation silently excluded from the same sections. `state:reviewer-instances-configured`
|
||||
and `state:auto-advance-active` were withheld the same way until a still
|
||||
further #2994 amendment gave `review` and `discuss-phase-assumptions` their
|
||||
own dedicated `cmdInit*` entry points (`cmdInitReview`,
|
||||
`cmdInitDiscussPhaseAssumptions`). The FINAL #2994 amendment gives
|
||||
`docs-update`, `update`, `transition`, and `new-milestone` their own atoms —
|
||||
`state:is-monorepo`, `state:next-channel`, `state:workstream-active`, and
|
||||
`state:flat-mode` — backed by three brand-new dedicated entry points
|
||||
(`cmdInitDocsUpdate`, `cmdInitUpdate`, `cmdInitTransition`) plus an extension
|
||||
of the pre-existing `cmdInitNewMilestone`.
|
||||
|
||||
### Compound conditions are resolved in the fact, never the grammar
|
||||
|
||||
@@ -130,6 +184,35 @@ Greenspun's Tenth Rule drift [The frozen `when=`
|
||||
vocabulary](#the-frozen-when-vocabulary) above exists to prevent, regardless
|
||||
of how reasonable a single compound condition looks in isolation.
|
||||
|
||||
`state:ui-phase-active` (#2994) is the same shape: `verify-work.md`'s
|
||||
`automated_ui_verification` step originally computed its own OR at RUNTIME
|
||||
(`UI_PHASE_ACTIVE` from `gsd_run loop render-hooks plan:pre` OR a `*-UI-SPEC.md`
|
||||
file check). `cmdInitVerifyWork` now resolves the identical disjunction ahead
|
||||
of time — `resolveLoopHooks({point: 'plan:pre', ...}).activeHooks` filtered to
|
||||
`kind === 'step' && ref.skill === 'ui-phase'`, OR'd with a `*-UI-SPEC.md`
|
||||
existence check under the phase directory — into `InvocationFacts.uiPhaseActive`,
|
||||
so `WHEN_PREDICATES['state:ui-phase-active']` again reads only that one field.
|
||||
|
||||
`state:plan-strategy-converge` (#2994) is the same shape again:
|
||||
`autonomous.md`'s own bash `PLAN_STRATEGY` resolver already folds `--converge`
|
||||
OR its documented alias `--cross-ai` into a single `"converge"`/`"local"`
|
||||
value at the top of the `initialize` step. `cmdInitAutonomous` mirrors that
|
||||
identical disjunction — `flags.has('--converge') || flags.has('--cross-ai')`
|
||||
— into `InvocationFacts.planStrategyConverge`, so
|
||||
`WHEN_PREDICATES['state:plan-strategy-converge']` reads only that one field,
|
||||
never `--converge`/`--cross-ai` separately.
|
||||
|
||||
`state:auto-advance-active` (#2994) is the same shape once more:
|
||||
`discuss-phase-assumptions.md`'s own `auto_advance` step already resolves
|
||||
`--auto` OR a consolidated `check auto-mode --pick active` fact (itself
|
||||
`workflow._auto_chain_active` OR `workflow.auto_advance`) via a runtime
|
||||
`gsd_run` call before deciding whether to dispatch. `cmdInitDiscussPhaseAssumptions`
|
||||
mirrors that identical disjunction — `options['auto'] === true ||
|
||||
readConfigJsonBoolean(cwd, ['workflow', '_auto_chain_active']) ||
|
||||
readConfigJsonBoolean(cwd, ['workflow', 'auto_advance'])` — into
|
||||
`InvocationFacts.autoAdvanceActive`, so `WHEN_PREDICATES['state:auto-advance-active']`
|
||||
reads only that one field, never the flag and the two config keys separately.
|
||||
|
||||
## Fails closed
|
||||
|
||||
An authoring mistake throws at parse time, naming the source file and 1-based
|
||||
@@ -223,14 +306,19 @@ At init time, a separate pure evaluator, `src/section-manifest.cts`
|
||||
(`selectSections`), partitions a workflow's manifest sections into
|
||||
`included`/`excluded` id lists against one invocation's
|
||||
`InvocationFacts` — `{flags, phaseNumber, hasPriorPhases, needsCodebaseMap?,
|
||||
phaseMvpMode?, worktreesEnabled?, chunkedMode?}`. Only a workflow with a **dedicated
|
||||
phaseMvpMode?, worktreesEnabled?, chunkedMode?, uiPhaseActive?, fallowEnabled?,
|
||||
gitCreateTag?, planStrategyConverge?, reviewerInstancesConfigured?,
|
||||
autoAdvanceActive?, isMonorepo?, nextChannel?, workstreamActive?, flatMode?}`.
|
||||
Only a workflow with a **dedicated
|
||||
`cmdInit*` entry point** in `src/init.cts` can have this evaluation run for
|
||||
it, because only that entry point can assemble `InvocationFacts` from its own
|
||||
parsed CLI options and `.planning/` state reads — this is admission gate 2
|
||||
from [The frozen `when=` vocabulary](#the-frozen-when-vocabulary) above,
|
||||
applied per-workflow rather than per-atom. Six entry points are wired today:
|
||||
`execute-phase`, `plan-phase`, `new-project`, `new-milestone`, `quick`, and
|
||||
`progress`.
|
||||
applied per-workflow rather than per-atom. Fifteen entry points are wired
|
||||
today: `execute-phase`, `plan-phase`, `new-project`, `new-milestone`,
|
||||
`quick`, `progress`, `verify-work`, `code-review`, `complete-milestone`,
|
||||
`autonomous`, `review`, `discuss-phase-assumptions`, `docs-update`, `update`,
|
||||
and `transition`.
|
||||
|
||||
`InvocationFacts.flags` is a `ReadonlySet<string>` of the literal `--<name>`
|
||||
tokens seen on the invocation, and **membership is token-presence, not
|
||||
@@ -245,13 +333,27 @@ own `false` into `undefined` (`namedArgs['wave'] || undefined`) before
|
||||
handing options to the facts builder, so `flags` only ever contains tokens
|
||||
that were actually seen.
|
||||
|
||||
## Piloted on execute-phase.md, then rolled out to plan-phase.md
|
||||
## Piloted on execute-phase.md, then rolled out across the wired workflows
|
||||
|
||||
Two workflows carry markers today: `gsd-core/workflows/execute-phase.md` (the
|
||||
#2930/Phase-3 pilot) and `gsd-core/workflows/plan-phase.md` (#2993, epic
|
||||
#1671 Phase 6.2). The marker grammar and composer seam are general-purpose
|
||||
across any workflow file; rollout to further LARGE/XL workflows remains
|
||||
sequenced as later work.
|
||||
Fifteen workflows carry markers today, all of them the workflows with a
|
||||
dedicated `cmdInit*` entry point (see [The manifest artifact](#the-manifest-artifact-and-per-workflow-keying)
|
||||
above): `gsd-core/workflows/execute-phase.md` (the #2930/Phase-3 pilot),
|
||||
`gsd-core/workflows/plan-phase.md` (#2993, epic #1671 Phase 6.2),
|
||||
`gsd-core/workflows/progress.md`, `gsd-core/workflows/new-project.md`,
|
||||
`gsd-core/workflows/quick.md`, `gsd-core/workflows/new-milestone.md` (those
|
||||
four, #2994, epic #1671 Phase 6.3), `gsd-core/workflows/verify-work.md`
|
||||
(also #2994, epic #1671 Phase 6.3), `gsd-core/workflows/code-review.md` /
|
||||
`gsd-core/workflows/complete-milestone.md` (a further #2994 amendment, epic
|
||||
#1671 Phase 6.3), `gsd-core/workflows/autonomous.md` (a still further
|
||||
#2994 amendment, epic #1671 Phase 6.3), `gsd-core/workflows/review.md` /
|
||||
`gsd-core/workflows/discuss-phase-assumptions.md` (a still further #2994
|
||||
amendment, epic #1671 Phase 6.3), and finally
|
||||
`gsd-core/workflows/docs-update.md` / `gsd-core/workflows/update.md` /
|
||||
`gsd-core/workflows/transition.md` (the LAST #2994 amendment, epic #1671
|
||||
Phase 6.3 — none of these three carried a `gsd_run query init.*` call before
|
||||
this slice). Every one of the 13 workflows ADR-1671 targeted is now on the
|
||||
fragment model; the marker grammar and composer seam remain general-purpose
|
||||
across any future workflow file, but no further rollout is scheduled.
|
||||
|
||||
`execute-phase.md` marks three `<step>` blocks: `partial-wave`
|
||||
(`flag:--wave`), `gap-closure-artifacts` (`state:gap-closure-phase`), and
|
||||
@@ -264,6 +366,233 @@ sequenced as later work.
|
||||
`RESEARCH_ONLY` condition, so they include/exclude together), and
|
||||
`chunked-planning-mode` (`state:chunked-mode`).
|
||||
|
||||
`progress.md` marks two sections: `forensic-audit` (`flag:--forensic`, #2994
|
||||
forensic audit) and `mvp-display` (`state:phase-mvp-mode`). `mvp-display`'s
|
||||
own body used to re-resolve its own gating fact via a `gsd_run query
|
||||
phase.mvp-mode` call — circular, since a section's body re-deriving the exact
|
||||
condition that gated its own inclusion is self-disabling the moment the init
|
||||
seam's computation and the body's computation drift. `cmdInitProgress` now
|
||||
computes `phaseMvpMode` for the CURRENT phase directly (threading a real
|
||||
`phase_number` into `buildSectionManifestField`, where before it passed
|
||||
`null` and the fact was permanently `false`) and exposes it as a top-level
|
||||
`phase_mvp_mode` init-bundle field, so the step body consumes an
|
||||
already-resolved fact instead of recomputing it.
|
||||
|
||||
`new-project.md` marks two sections, both `flag:--auto`: `auto-mode-detection`
|
||||
(the `<auto_mode>` tag itself stays outside the marker — only its body is
|
||||
extracted) and `auto-mode-config` (`## 2a. Auto Mode Config`).
|
||||
|
||||
`quick.md` marks five sections: `discussion-phase` (`flag:--discuss`),
|
||||
`research-phase` (`flag:--research`), `plan-checker-loop` and
|
||||
`quick-verification` (both `flag:--validate` — two consumers sharing one
|
||||
atom, mirroring `plan-phase.md`'s `research-only-*` pair), and
|
||||
`worktree-pre-dispatch-commit` (`state:worktrees-enabled`). `quick.md`'s
|
||||
`--full` flag IMPLIES `--discuss`/`--research`/`--validate` — folded into the
|
||||
facts inside `cmdInitQuick` (mirroring `state:chunked-mode`'s disjunction
|
||||
fold) before `buildSectionManifestField` builds its flags Set, so a bare
|
||||
`--full` invocation still includes the three flag-gated sections without the
|
||||
grammar ever seeing an OR.
|
||||
|
||||
`new-milestone.md` marks two sections: `reset-phase-safety`
|
||||
(`flag:--reset-phase-numbers`) and, from the final #2994 slice,
|
||||
`project-md-milestone-write` (`state:flat-mode`) — Step 4's "Part A"
|
||||
milestone-state write, which must run ONLY when NO workstream is active
|
||||
(#2308: an active workstream's own `.planning/workstreams/<name>/STATE.md`/
|
||||
`ROADMAP.md`/`REQUIREMENTS.md` already carry this milestone's state, so
|
||||
writing the shared `## Current Milestone` heading here would clobber it).
|
||||
Part A's true condition is the NEGATION of "a workstream is active", and the
|
||||
grammar has no negation operator, so `state:flat-mode` is a SEPARATE,
|
||||
positively-phrased atom (fact `= !workstreamActive`) rather than a negated
|
||||
`state:workstream-active` — see `transition.md` below for the atom this one
|
||||
inverts. Part B ("Evolution structural repair", always runs regardless of
|
||||
workstream mode) stays OUTSIDE the marker, directly after it, for the same
|
||||
reason every other flag-absent/state-false fallback in this document does.
|
||||
`cmdInitNewMilestone` computes both `workstreamActive` and `flatMode` from
|
||||
the SAME authoritative source `cmdInitProgress` already established
|
||||
(`GSD_WORKSTREAM` env, falling back to the stored active-workstream
|
||||
pointer). Because Step 4 (where the marker lives) runs well before
|
||||
`new-milestone.md`'s pre-existing `init.new-milestone` call (Step 7, kept
|
||||
AFTER Step 6's phase archival so its `phase_dir_count`/`roadmap_exists`
|
||||
fields reflect POST-archival state), a SECOND, section-manifest-only
|
||||
`init.new-milestone` call is added early in Step 1 — `init.new-milestone`
|
||||
is a pure read with no mutation, so calling it twice is side-effect-free.
|
||||
|
||||
`verify-work.md` marks two sections: `automated-ui-verification`
|
||||
(the new `state:ui-phase-active`, #2994 — see [Compound conditions are
|
||||
resolved in the fact, never the grammar](#compound-conditions-are-resolved-in-the-fact-never-the-grammar)
|
||||
above) and `mvp-uat-framing` (`state:phase-mvp-mode`, sharing the atom
|
||||
already computed for `progress.md`'s `mvp-display`). `mvp-uat-framing`'s
|
||||
extraction is narrower than `progress.md`'s `mvp-display`: only the
|
||||
true-branch prose (the three ordered UAT sections plus the User Story format
|
||||
guard) moves into the step file — the false-branch note ("When `MVP_MODE=false`
|
||||
… fall back to the standard UAT generation path") stays OUTSIDE the marker,
|
||||
directly after it, because gating it away with the rest of the section would
|
||||
delete the exact text needed on every invocation where the atom is `false`
|
||||
(the common, non-MVP case). Unlike `progress.md`'s `mvp-display`, `verify-work.md`
|
||||
keeps its own `MVP_MODE=$(gsd_run query phase.mvp-mode ...)` runtime resolver
|
||||
(in the unconditional `initialize` step, not inside the gated section) — it is
|
||||
not circular/self-disabling the way `progress.md`'s inline resolver was,
|
||||
because the un-marked false-branch note and the step-file prose both still
|
||||
reference `$MVP_MODE` as a runtime variable, so the resolver keeps a live
|
||||
consumer outside the gate.
|
||||
|
||||
`code-review.md` marks two sections: `structural-pre-pass` (`state:fallow-enabled`)
|
||||
and `dispatch-fix` (`flag:--fix`). `structural-pre-pass`'s own body used to
|
||||
re-resolve its own gating fact via four `gsd_run query config-get
|
||||
code_quality.fallow.*` calls — circular, for the same reason `progress.md`'s
|
||||
pre-hoist `mvp-display` was: a section's body re-deriving the exact condition
|
||||
that gated its own inclusion is self-disabling the moment the init seam's
|
||||
computation and the body's computation drift. `cmdInitCodeReview` now resolves
|
||||
`code_quality.fallow.{enabled,scope,profile,mcp}` once (`detectFallowConfig`,
|
||||
`src/init.cts`) and exposes them as top-level `fallow_enabled`/`fallow_scope`/
|
||||
`fallow_profile`/`fallow_mcp`/`fallow_max_crap` init-bundle fields; the
|
||||
unconditional part of the `structural_pre_pass` step now just parses those
|
||||
fields, and only the fallow-binary-resolve-and-execute portion (which produces
|
||||
`FALLOW.json`) is gated behind the marker — the `FALLOW_JSON_PATH=""`
|
||||
disabled-path fallback stays OUTSIDE the marker, directly after it, for the
|
||||
same reason `verify-work.md`'s MVP false-branch note does (deleting it would
|
||||
break the common, fallow-disabled case). `dispatch-fix` moves the entire
|
||||
`--fix`-gated step wholesale (mirroring `progress.md`'s `forensic-audit`
|
||||
extraction) — `code-review.md`'s `initialize` step now resolves the RESOLVED
|
||||
fix decision (`--fix` itself, or `--all`/`--auto` implying it, via
|
||||
`code-review-flags.cjs`) before the `init.code-review` call, so the
|
||||
section-manifest gate matches the flags module's own implication logic rather
|
||||
than a raw `--fix` token scan.
|
||||
|
||||
`complete-milestone.md` marks one section: `git-tag` (`state:git-create-tag`).
|
||||
The `git_tag` step's own `<config-check>` sub-tag used to re-resolve
|
||||
`git.create_tag` via `gsd-tools.cjs query config-get` to decide whether to
|
||||
skip the step — again a section (here, a whole step) gating its own inclusion
|
||||
on a fact its own body computed. `cmdInitCompleteMilestone` now resolves it
|
||||
once (`detectGitCreateTag`, `src/init.cts`, fail-OPEN default `true` — an
|
||||
unset key means "create the tag", the inverse polarity of `detectFallowConfig`'s
|
||||
fail-closed default, mirroring the two source resolvers' own opposite
|
||||
defaults) and exposes it as the init-bundle's `git_create_tag` field; the
|
||||
entire `git_tag` step moves to its step file wholesale, with no
|
||||
`<config-check>` left to re-derive. `complete-milestone.md` gains an
|
||||
ADDITIVE `init.complete-milestone` call (in the `handle_branches` step,
|
||||
alongside its pre-existing `init.manager` and `init.execute-phase` calls,
|
||||
neither of which is removed) purely to carry `git_create_tag` and
|
||||
`section_manifest` — it has no phase-listing logic of its own to delegate.
|
||||
|
||||
`autonomous.md` marks five sections, all sharing the single
|
||||
`state:plan-strategy-converge` atom (legal and precedented — `plan-phase.md`'s
|
||||
`research-only-*` pair already shares `flag:--research-phase`): `converge-fail-fast`
|
||||
(the `workflow.plan_review_convergence` feature-gate check, split out of the
|
||||
surrounding `CONVERGENCE_ARGS` bash block — that block's reviewer-flag/`--max-cycles`
|
||||
parsing stays UNGATED, directly before the marker, because it always needs to
|
||||
run regardless of `PLAN_STRATEGY`, and only the `if [ "$PLAN_STRATEGY" =
|
||||
"converge" ]` fail-fast check moves into the step file), `converge-banner`
|
||||
(a single display line — still a legitimate section per [Marker
|
||||
syntax](#marker-syntax) above; `scripts/gen-section-manifest.cjs`'s
|
||||
`FAIL_MISSING_STEP_FILE` check requires a step file for every explicit marker
|
||||
regardless of body size, so the stub+step-file round trip is not optional
|
||||
here even though the body is trivially small), `converge-dispatch-bg` and
|
||||
`converge-dispatch-inline` (the `PLAN_STRATEGY=converge` branch of step 3b's
|
||||
background/inline `FLATTEN` dispatch — an ORTHOGONAL condition interleaved in
|
||||
the same list; each converge branch is independently contiguous and the
|
||||
sibling `- Otherwise, print: ...`/`- Otherwise (local planning):` fallback
|
||||
bullets stay OUTSIDE the marker, immediately after it, because they are the
|
||||
`PLAN_STRATEGY=local` default that must always render), and `converge-loop`
|
||||
(the unconditional-`INTERACTIVE` bottom-of-3b convergence dispatch, with the
|
||||
`PLAN_STRATEGY=local` regular-planner fallback again staying outside).
|
||||
`autonomous.md` keeps its own bash `PLAN_STRATEGY` resolver (`"local"` vs.
|
||||
`"converge"`, folding `--converge` OR `--cross-ai`) in the UNCONDITIONAL
|
||||
`initialize` step — never moved or removed — because ungated content later
|
||||
in the same step (the "local" planning bullets) still references
|
||||
`$PLAN_STRATEGY` as a runtime variable, same discipline as
|
||||
`verify-work.md`'s retained `$MVP_MODE` resolver. `cmdInitAutonomous` mirrors
|
||||
the identical disjunction into `InvocationFacts.planStrategyConverge`, and
|
||||
`autonomous.md` gains an ADDITIVE `init.autonomous` call (in the
|
||||
`initialize` step, alongside its pre-existing `init.milestone-op`,
|
||||
`init.manager`, and `init.phase-op` calls — CRITICAL blast radius, none
|
||||
removed, none modified) purely to carry `section_manifest`; like
|
||||
`complete-milestone.md`'s entry point, it has no phase-listing logic of its
|
||||
own to delegate.
|
||||
|
||||
`review.md` marks two sections, both sharing the single
|
||||
`state:reviewer-instances-configured` atom (legal and precedented —
|
||||
`plan-phase.md`'s `research-only-*` pair already shares
|
||||
`flag:--research-phase`): `reviewer-instances-note-1` and
|
||||
`reviewer-instances-note-2`, two peripheral additive notes in the
|
||||
`detect_clis` and `invoke_reviewers` steps respectively. Neither note is
|
||||
part of the workflow's core reviewer-lane dispatch — that dispatch is the
|
||||
workflow's primary always-evaluated logic and is never gated. `review.md`
|
||||
previously routed through the shared, 20+-caller `init.phase-op`, reading
|
||||
only 3 of its ~60 fields (`phase_dir`, `phase_number`, `padded_phase`);
|
||||
`cmdInitReview` now resolves those 3 fields itself via the same
|
||||
`guardedFindPhase`/`guardedGetRoadmapPhase` primitives, plus the
|
||||
`review.reviewer_instances` config-presence fact (reusing
|
||||
`readConfigJsonValue`, added for `detectFallowConfig` — no second config
|
||||
reader).
|
||||
|
||||
`discuss-phase-assumptions.md` marks one section: `auto-advance-dispatch`
|
||||
(`state:auto-advance-active`), inside the `auto_advance` step. The step's
|
||||
own `--auto`-flag parse, chain-flag sync, and consolidated `AUTO_MODE`
|
||||
resolver (all of which must always run) stay OUTSIDE the marker; only the
|
||||
flag-present display-banner-and-launch body is gated, and the flag-absent
|
||||
"End here" fallback stays OUTSIDE the marker too, directly after it — gating
|
||||
the whole step would delete the fallback text needed exactly when `--auto`
|
||||
is absent, the same class of hazard `verify-work.md`'s MVP false-branch note
|
||||
and `code-review.md`'s fallow-disabled fallback both document. `discuss-phase-assumptions.md`
|
||||
previously routed through `init.phase-op`, reading 14 of its fields;
|
||||
`cmdInitDiscussPhaseAssumptions` now resolves those 14 fields itself (via
|
||||
the same shared primitives, reproducing `cmdInitPhaseOp`'s archived/not-found
|
||||
fallback shape), plus `state:auto-advance-active` — `--auto` flag OR a
|
||||
consolidated auto-mode config fact, resolved to one boolean the same way
|
||||
`state:chunked-mode` is.
|
||||
|
||||
`docs-update.md` marks one section: `dispatch-monorepo-packages`
|
||||
(`state:is-monorepo`) — the whole `dispatch_monorepo_packages` `<step>`,
|
||||
which already carried a hand-written `condition="monorepo_workspaces is
|
||||
non-empty"` attribute identifying it as the gated region before this slice.
|
||||
`docs-update.md` previously called `docs-init` (`cmdDocsInit`, `src/docs.cts`)
|
||||
only — a SEPARATE, pre-existing entry point outside the `init.*` family,
|
||||
left untouched. The new `cmdInitDocsUpdate` is purely ADDITIVE, carrying only
|
||||
`section_manifest`; its `isMonorepo` fact reuses `detectMonorepoWorkspaces`
|
||||
(exported from `src/docs.cts` for this purpose) rather than a second,
|
||||
divergence-prone workspace-glob scan — the SAME detector that already backs
|
||||
`docs-init`'s own `monorepo_workspaces` field.
|
||||
|
||||
`update.md` marks one section: `channel-banner` (`state:next-channel`) — the
|
||||
"Only when `TAG=next`" channel-banner paragraph in `compare_versions`.
|
||||
`update.md` previously called NO `init.*` command at all; it resolves
|
||||
`gsd-tools.cjs` itself via a bespoke `PREFERRED_CONFIG_DIR`/
|
||||
`PREFERRED_RUNTIME`-aware `$GSD_TOOLS` cascade (`get_installed_version`,
|
||||
~lines 13-45) because the update workflow must run before any install can be
|
||||
assumed resolvable. The new `init.update` call REUSES that already-resolved
|
||||
`$GSD_TOOLS` (dual `.cjs`/PATH-shim invocation style, matching the
|
||||
pre-existing `update-context` call) rather than copying the canonical
|
||||
launcher preamble — both resolutions assign the identical `$GSD_TOOLS` shell
|
||||
variable, and the canonical preamble would silently clobber the value later
|
||||
steps (`backup_custom_files`, `restore_custom_files`) still depend on.
|
||||
`cmdInitUpdate`'s `nextChannel` fact (`--next` OR its documented alias
|
||||
`--rc`) is resolved in PARALLEL with, not in place of, `update.md`'s own
|
||||
`TAG="next"`/`TAG="latest"` case-statement in `parse_update_channel`, which
|
||||
stays byte-identical — issue #815's regression test
|
||||
(`tests/issue-815-update-next-channel.test.cjs`) asserts that literal
|
||||
case-statement text remains in the workflow, since the npm dist-tag
|
||||
selection has to run in the workflow's own shell before any `gsd_run`
|
||||
round-trip.
|
||||
|
||||
`transition.md` marks one section: `workstream-collision-check`
|
||||
(`state:workstream-active`) — an internal workflow (it has no user-facing
|
||||
slash command of its own) that previously called NO `init.*` command at
|
||||
all. It already establishes `gsd_run()` via the canonical launcher preamble
|
||||
in its `update_roadmap_and_state` step, before this call's insertion point
|
||||
in `offer_next_phase`, so no second preamble copy is needed. The section's
|
||||
body previously re-derived its own gating condition via an inline `gsd_run
|
||||
query workstream.list --raw` call wrapped in `if [ -n "$GSD_WORKSTREAM" ]`
|
||||
— the identical condition that now backs the section's own admission (the
|
||||
same resolver-in-body hazard `code-review.md`'s `structural-pre-pass` and
|
||||
`complete-milestone.md`'s `git-tag` documented). `cmdInitTransition` hoists
|
||||
this via `getOtherActiveWorkstreamInventories` (`src/workstream-inventory.cts`
|
||||
— the SAME primitive `workstream.list` itself calls), pre-filtered exactly
|
||||
as the step's own prose described (excludes the current workstream and any
|
||||
workstream whose status contains "milestone complete" or "archived",
|
||||
case-insensitively), exposed as `other_active_workstreams`; the step body is
|
||||
now a pure JSON consumer with no `gsd_run` call of its own.
|
||||
|
||||
**`plan-phase.md` was originally retargeted away from the #2930 pilot,
|
||||
then fragmentized here once the blocker cleared.** Issue #2930's own
|
||||
motivating mutually-exclusive branches (`--prd`, `--ingest`, `--mvp`,
|
||||
@@ -304,5 +633,5 @@ question 1's resolution for the full record.
|
||||
`InvocationFacts`) consumed by the init seam.
|
||||
- `scripts/gen-section-manifest.cjs` — generates the committed
|
||||
`gsd-core/workflows/section-manifest.json` artifact from markers.
|
||||
- `src/init.cts` — `buildSectionManifestField` and the six wired
|
||||
- `src/init.cts` — `buildSectionManifestField` and the fifteen wired
|
||||
`cmdInit*` entry points.
|
||||
|
||||
Reference in New Issue
Block a user