Commit Graph

3 Commits

Author SHA1 Message Date
Tom Boucher
45f3a2a5f9 fix(#2089): wire adapter into install path + address all review findings
MEDIUM fixes (code review):
- Wire resolveManagedHookEvents + resolveHookScripts + buildHookBusEntries
  from imperative-hook-bus.cts into writeCursorHooksJson — the install path
  is now truly descriptor-driven (reads hostBehaviors.managedHookEvents),
  not a hardcoded constant that happens to match the descriptor. bin/install.js
  passes the descriptor list via opts.managedHookEvents.
- buildHookBusEntries is now consumed (was dead code); entry-building is no
  longer duplicated inline.
- Remove try/finally from cursor-hook-bus-upgrade.test.cjs test bodies
  (violated CONTRIBUTING.md L342; redundant with t.after cleanup).

LOW fixes:
- Remove dead require('fs')/require('path') from gsd-cursor-pre-tool.js
- Fix resolveManagedHookEvents docstring (all-invalid fallback behavior)
- Add src/runtime-hooks-surface.cts to the AC2 source-guard file list

Security review: no CRITICAL/HIGH/MEDIUM findings (3 LOW are pre-existing
#777 baseline patterns, not regressions).
2026-07-09 13:17:04 -04:00
Tom Boucher
a53c5462e6 chore(#2089): gitignore compiled imperative-hook-bus adapter + fix Context7 typo
- Add /gsd-core/bin/lib/host-integration-adapters/imperative-hook-bus.cjs to
  .gitignore (tsc-emitted build artifact per ADR-457 convention; matches the
  sibling adapter entries at .gitignore:70-89). The subagent authored the
  .cts source but missed this entry, leaving the compiled output untracked.
- Fix cosmetic 'Context3' -> 'Context7' typo in test section header comment.
2026-07-09 02:07:08 -04:00
Tom Boucher
c5e5211db0 test(#2089): add cursor EoS migration test scaffolding (red) 2026-07-09 00:21:28 -04:00