Tom Boucher
78c794c016
test: remove dead registry wiring assertion
2026-05-04 21:49:41 -04:00
Tom Boucher
40acf1f02e
fix: address CodeRabbit findings on query/transport error handling
2026-05-04 21:49:41 -04:00
Tom Boucher
1642f47908
test: align registry wiring assertions with declarative assembly
2026-05-04 21:49:41 -04:00
Tom Boucher
38718e9d4b
fix: avoid unsafe Promise cast in execRaw
2026-05-04 21:49:40 -04:00
Tom Boucher
a441f96f37
chore: update changeset pr reference
2026-05-04 21:49:40 -04:00
Tom Boucher
0500bdf619
refactor: deepen query architecture seams with compatibility shims
2026-05-04 21:49:40 -04:00
Tom Boucher
c6a35d6398
refactor: deepen transport policy and output projection paths
2026-05-04 21:49:40 -04:00
Tom Boucher
969cfcf998
refactor: split native hotpath fallback and dispatch branches
2026-05-04 21:49:40 -04:00
Tom Boucher
e0c791a5d0
refactor: centralize native dispatch data projection
2026-05-04 21:49:40 -04:00
Tom Boucher
deb4477375
refactor: remove thin runtime and tools error wrappers
2026-05-04 21:49:40 -04:00
Tom Boucher
5aaf0dbea5
refactor: reduce query error factory public surface
2026-05-04 21:49:40 -04:00
Tom Boucher
ace241d0c2
refactor: fold query error seam types into factory module
2026-05-04 21:49:40 -04:00
Tom Boucher
0fffc7c055
refactor: centralize gsd-tools error wrapping path
2026-05-04 21:49:40 -04:00
Tom Boucher
6059a574f2
refactor: remove redundant native dispatch cast in runtime
2026-05-04 21:49:40 -04:00
Tom Boucher
b0e616288b
refactor: isolate native dispatch error projection
2026-05-04 21:49:40 -04:00
Tom Boucher
ed9d67c91b
refactor: deepen subprocess adapter with shared execution error path
2026-05-04 21:49:40 -04:00
Tom Boucher
97019d274e
refactor: keep classification constructors internal to GSDToolsError
2026-05-04 21:49:40 -04:00
Tom Boucher
7311e0a9ab
refactor: extract query error seam factory builders
2026-05-04 21:49:39 -04:00
Tom Boucher
c66ff96de8
test: use typed GSDToolsError constructors in cli output tests
2026-05-04 21:49:39 -04:00
Tom Boucher
a24de43f8b
test: consolidate tools error mapping coverage in factory tests
2026-05-04 21:49:39 -04:00
Tom Boucher
70faa0ff0f
refactor: remove query tools error mapper wrapper
2026-05-04 21:49:39 -04:00
Tom Boucher
b9e3979fc1
refactor: introduce explicit query error seam contracts
2026-05-04 21:49:39 -04:00
Tom Boucher
c7d3f83b8b
refactor: reduce failure-classification API surface
2026-05-04 21:49:39 -04:00
Tom Boucher
bc289fad4a
refactor: type native adapter error seam to GSDToolsError
2026-05-04 21:49:39 -04:00
Tom Boucher
9bee4dce4a
test: adopt typed GSDToolsError constructors across failure tests
2026-05-04 21:49:39 -04:00
Tom Boucher
9a469fa05c
refactor: centralize query tools error construction in factory
2026-05-04 21:49:39 -04:00
Tom Boucher
abf7779088
test: cover typed timeout mapping in query dispatch
2026-05-04 21:49:39 -04:00
Tom Boucher
16bf552037
test: lock typed timeout no-fallback transport behavior
2026-05-04 21:49:39 -04:00
Tom Boucher
009cfb1562
refactor: split native adapter timeout and failure seams
2026-05-04 21:49:39 -04:00
Tom Boucher
6fe4af2546
refactor: split subprocess timeout and failure error seams
2026-05-04 21:49:39 -04:00
Tom Boucher
41683b2f53
refactor: centralize typed GSDToolsError construction
2026-05-04 21:49:38 -04:00
Tom Boucher
7dcafbc211
refactor: consolidate failure classification constructors
2026-05-04 21:49:38 -04:00
Tom Boucher
ccda572ade
refactor: default typed failure classification across query errors
2026-05-04 21:49:38 -04:00
Tom Boucher
1ca7f58831
test: cover tools error mapping and unify timeout fallback check
2026-05-04 21:49:38 -04:00
Tom Boucher
7298a76b20
refactor: centralize dispatch error projection from failure signals
2026-05-04 21:49:38 -04:00
Tom Boucher
5cfd874058
refactor: add typed query failure signals
2026-05-04 21:49:38 -04:00
Tom Boucher
ba6100c548
refactor: deepen query failure classification module
2026-05-04 21:49:38 -04:00
Tom Boucher
9f5b011b35
refactor: use internal gsdtools error type import
2026-05-04 21:49:38 -04:00
Tom Boucher
1037b82a98
test: address remaining coderabbit findings and notes
2026-05-04 21:49:38 -04:00
Tom Boucher
ac883f8150
fix: address coderabbit query seam findings
2026-05-04 21:49:38 -04:00
Tom Boucher
3e22c70fac
docs: fix changeset summary text
2026-05-04 21:49:38 -04:00
Tom Boucher
12fc34689e
docs: add changeset for query seam deepening
2026-05-04 21:49:37 -04:00
Tom Boucher
9d096b9925
refactor: deepen gsdtools query execution seams
2026-05-04 21:49:37 -04:00
Fabio
6664190888
fix(hooks): execFileSync 'npm' needs shell:true on Windows
...
Without shell:true, execFileSync('npm', ...) on Windows fails with
ENOENT because npm is distributed as npm.cmd, not as a literal 'npm'
binary. The silent try/catch swallows the error, latest stays null,
update_available becomes null, and the statusline never shows
"⬆ /gsd-update" — Windows users miss every release.
Adding shell:true makes execFileSync route through cmd.exe which
resolves npm.cmd via PATHEXT, identical behavior on POSIX.
Repro on Windows:
$env:GSD_CACHE_FILE = "$env:USERPROFILE\.cache\gsd\gsd-update-check.json"
node ~\.claude\hooks\gsd-check-update-worker.js
Get-Content "$env:USERPROFILE\.cache\gsd\gsd-update-check.json"
Before: {"update_available":null,"installed":"1.40.0","latest":"unknown",...}
After: {"update_available":false,"installed":"1.40.0","latest":"1.40.0",...}
2026-05-04 22:53:29 +02:00
Tom Boucher
42ed7cee8d
refactor: deepen GSDTools query execution seams ( #3085 )
...
* refactor: deepen gsdtools query execution seams
* docs: add changeset for query seam deepening
* docs: fix changeset summary text
* fix: address coderabbit query seam findings
* test: address remaining coderabbit findings and notes
* refactor: use internal gsdtools error type import
2026-05-03 18:56:41 -04:00
Tom Boucher
5e21bf7567
Deepen query dispatch seam with Command Topology Module ( #3078 )
...
* Deepen query dispatch seam with command topology module
* Stabilize SDK parity defaults and integration test gating
* docs(architecture): record pre-project config policy and e2e gate
* refactor(query): stop injecting native adapter in CLI dispatch path
* fix(config): align workflow auto-chain typing and docs
2026-05-03 18:11:38 -04:00
Tom Boucher
9c92c32f6e
refactor(query): deepen runtime context/native adapter/output seams ( #3076 )
...
* refactor(query): deepen runtime context, native adapter, and cli output seams
* chore(changeset): add fragment for query seam deepening continuation
* refactor(query): converge internal command-resolution imports on canonical seam
* refactor(query): remove dead seam wrappers and converge on canonical modules
* docs(architecture): update context and adr for query seam completion
* fix(query): preserve gsd-tools stderr in cli output and clarify static ws test scope
* test(query): cover whitespace stderr and null exitCode fallback
2026-05-03 16:31:48 -04:00
Tom Boucher
5c9f34bd31
refactor(cli): extract Query CLI Adapter Module seam ( #3074 )
...
* refactor(cli): extract query adapter seam from cli entrypoint
* test: update ws forwarding guard for query-cli-adapter seam
* fix(query): close remaining CodeRabbit findings on cli adapter
* test: address remaining CodeRabbit nitpicks on ws forwarding coverage
2026-05-03 15:57:01 -04:00
Tom Boucher
b6c401dc90
refactor(query): deepen command/dispatch seams and resolve coderabbit findings
...
* refactor(query): deepen command definition seam and fold fallback mapping cleanup
* refactor(query): add shared dispatch formatting module seam
* fix(query): restore QueryResult type import in dispatch deps
* test/query: align raw-output policy and definition normalization contracts
* refactor(query): deepen diagnosis, invariant report, and error taxonomy seams
* refactor(query): deepen dispatch plan, fallback bridge, policy snapshot, and hints seams
* refactor(query): deepen validation, fallback policy, capability, and result builder seams
* refactor(query): deepen resolution strategy, output classifier, observability, and policy-capability seams
* refactor(query): finalize deep strategy/classifier/observability/capability seams
* test/query: address coderabbit inline and out-of-diff dispatch nits
* fix(query): address remaining coderabbit input-validation and bridge stderr threads
* fix(query): address remaining coderabbit dispatch and strategy/output nits
2026-05-03 15:29:34 -04:00
Tom Boucher
c3f896f311
docs(contributing): codify CONTEXT + ADR contribution and testing standards
2026-05-03 14:54:14 -04:00
