Commit Graph

2 Commits

Author SHA1 Message Date
Tom Boucher
9ed8c7d574 feat(#1026): §5.6/ui-phase cutover — first gate dispatch (plan:pre step + blocking gate) (#1028)
Replace plan-phase.md §5.6 (a 6-branch inline UI gate) with a capability-driven
loop.render-hooks plan:pre dispatch — the FIRST gate dispatch in any workflow.
A step (ui-phase, when:workflow.ui_phase) + a new blocking gate
(when:workflow.ui_safety_gate). New ui.plan-gate check verb returns
{frontend, hasUiSpec, block}; the dispatch runs it unconditionally then fires
the active step (pipeline) or halts on the active blocking gate (manual). The
gate-handling (run check.query; halt if blocking+block) is the reusable
phase-6 template for blocking-gate cutovers.

Config semantics fixed per #1022 + maintainer call: ui_phase gates plan-time
UI-SPEC generation, ui_safety_gate gates the planning block. Common case + all
ui_phase=false cases are equivalence-preserving; the one intended change is
{ui_phase:true, ui_safety_gate:false} now auto-generating in pipelines.

Review found it broken twice (non-generic dispatch, phase-lookup divergence,
then the step-only check nested in a gate loop) — fixed; final Codex pass
verified all 8 (ui_phase,ui_safety_gate)x{pipeline,manual} cases correct.
gsd-ui-phase skill + autonomous §3a.5 untouched (§3a.5 deferred).
getRoadmapPhaseWithFallback mirrors cmdRoadmapGetPhase for lookup parity.

Closes #1026

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-11 00:58:21 -04:00
Tom Boucher
7eea991884 test(#1018): hook-firing de-risk spike — structural off-means-off proof + cutover contract (#1020)
Spike disposition (a): prove the loop.render-hooks mechanism at the data level
and document the cutover-shape finding, without touching plan-phase.md §5.6.

- tests/loop-hook-firing-spike.test.cjs: makes "off means off" executable — a
  host-computed aggregate (hostConsume) that is a pure function of the active
  hook set; UI active-by-default → 1, off → 0 == independently-computed base
  (not tautological); synthetic 2-hook ordering; second point verify:post.
- CONTEXT.md RULESET.CAPABILITY.cutover-self-gating: the loop hook is coarse;
  phase-context detection + mode self-gate in the skill (ADR-894); §5.6 UI gate
  is the worked example of what must move into gsd-ui-phase before cutover.

Finding: the UI plan:pre hook is already inlined (§5.6) — cutover is move
host-logic-into-skill, not a 1:1 swap. Live LLM-execution of injected hook
markdown is the residual, carried into the first phase-6 cutover acceptance.

Closes #1018

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-10 21:40:30 -04:00