* test: reproduce phase.add dry-run + flag validation gaps (#3226)
Add failing tests for:
- --dry-run silently absorbed into description (symptom A)
- Unknown --flag should return validation error (symptom C)
- ### Phase N: ROADMAP heading scan verification (symptom B)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix(sdk): phase.add honors --dry-run; rejects unknown flags (#3226)
- Add flag parser to phaseAdd: strip recognized flags (--dry-run) from
args before positional parsing so they never silently become description
or customId values
- --dry-run computes the next phase number and roadmap_entry string but
skips mkdir, writeFile, and readModifyWriteRoadmapMd; returns
{ dry_run: true, roadmap_entry } alongside normal fields
- Any unrecognized --flag throws a Validation GSDError naming the flag
- ROADMAP ### Phase N: heading scan for numbering (symptom B) was already
correct; verified with new regression test
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* changeset: pr=3246 for #3226
* fix(sdk): phase.add scans disk AND roadmap (union, not fallback)
Address CodeRabbit finding: the conditional `if (maxPhase === 0)` guard
around the filesystem scan meant that if ROADMAP had any phases but disk
was ahead (e.g. ROADMAP max=10, dirs include 12-*), phase.add would
pick 11 and collide with the existing directory.
Remove the guard: always scan on-disk phase directories and take the
max across both ROADMAP and filesystem (union semantics).
All 57 phase-lifecycle tests pass.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* test: reproduce phase.add concurrent ID collision (CR finding)
Two concurrent phase.add calls against the same project observe
maxPhase before the lock is held, producing duplicate phase IDs.
Adds a Promise.all regression test that asserts both calls succeed
with distinct phase numbers {11, 12}.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix(sdk): compute phase number under roadmap lock (CR finding)
Move maxPhase/newPhaseId/dirName computation inside the
readModifyWriteRoadmapMd callback so the entire read → compute → write
cycle is serialised under the lock. Previously, two concurrent
phase.add calls could both observe maxPhase=N before either acquired
the lock, then both write with phase ID N+1 — producing duplicate IDs.
In dry-run mode (no write, no race) the computation still happens
outside the lock to avoid unnecessary contention.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
