Commit Graph

2 Commits

Author SHA1 Message Date
Tom Boucher
48f84e12ca fix(changeset): add missing pr: 3102 field to windows-npm-shell-fix
The changeset parser hard-fails on fragments without a `pr:` field.
Closes #3102 (changeset schema violation identified in review).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-06 20:53:57 -04:00
Fabio
ad0747ccac fix(hooks): scope shell:true to Windows + add changeset
Address adversarial review feedback on PR #3102:

1. shell:true is now conditional (process.platform === 'win32')
   - POSIX path unchanged: no shell spawn, no overhead, original
     signal/exit-code semantics and windowsHide effect preserved
   - Windows path: still routes through cmd.exe to resolve npm.cmd
     via PATHEXT (the actual fix for ENOENT)

2. Added .changeset/windows-npm-shell-fix.md (Fixed type)

Reviewed feedback resolved:
- Cross-platform regression risk → shell now Windows-only
- Missing changeset → added
2026-05-05 21:16:36 +02:00