Tom Boucher
8ad2e3877f
fix(sdk): address CodeRabbit runtime bridge and docs findings
2026-05-05 19:59:56 -04:00
Tom Boucher
8adfe4de01
docs(context): add ADR-0002 PR review learnings (CodeRabbit findings synthesis)
2026-05-05 16:07:08 -04:00
Tom Boucher
519de8a91d
docs(context): add workflow learnings from 2026-05-05 triage + PR cycle
...
- Skill consolidation gap class: missing workflow files, detection via regression test
- CodeRabbit stale thread resolution pattern after allow-test-rule fixes
- PR discipline: split unrelated changes, one concern per PR
- INVENTORY.md must stay in sync with workflow filesystem on every add/remove
- README: storyline-only target, MD001/MD040 markdownlint rules to watch
- Issue triage: always check local branches for crash-recovery before re-implementing
- SDK-only verbs: golden-policy NO_CJS_SUBPROCESS_REASON exemption required
2026-05-05 15:03:38 -04:00
Tom Boucher
48f09d34af
docs(context): add recurring PR mistakes distilled from CodeRabbit reviews
2026-05-05 13:59:27 -04:00
Tom Boucher
42ed7cee8d
refactor: deepen GSDTools query execution seams ( #3085 )
...
* refactor: deepen gsdtools query execution seams
* docs: add changeset for query seam deepening
* docs: fix changeset summary text
* fix: address coderabbit query seam findings
* test: address remaining coderabbit findings and notes
* refactor: use internal gsdtools error type import
2026-05-03 18:56:41 -04:00
Tom Boucher
5e21bf7567
Deepen query dispatch seam with Command Topology Module ( #3078 )
...
* Deepen query dispatch seam with command topology module
* Stabilize SDK parity defaults and integration test gating
* docs(architecture): record pre-project config policy and e2e gate
* refactor(query): stop injecting native adapter in CLI dispatch path
* fix(config): align workflow auto-chain typing and docs
2026-05-03 18:11:38 -04:00
Tom Boucher
9c92c32f6e
refactor(query): deepen runtime context/native adapter/output seams ( #3076 )
...
* refactor(query): deepen runtime context, native adapter, and cli output seams
* chore(changeset): add fragment for query seam deepening continuation
* refactor(query): converge internal command-resolution imports on canonical seam
* refactor(query): remove dead seam wrappers and converge on canonical modules
* docs(architecture): update context and adr for query seam completion
* fix(query): preserve gsd-tools stderr in cli output and clarify static ws test scope
* test(query): cover whitespace stderr and null exitCode fallback
2026-05-03 16:31:48 -04:00
Tom Boucher
b6c401dc90
refactor(query): deepen command/dispatch seams and resolve coderabbit findings
...
* refactor(query): deepen command definition seam and fold fallback mapping cleanup
* refactor(query): add shared dispatch formatting module seam
* fix(query): restore QueryResult type import in dispatch deps
* test/query: align raw-output policy and definition normalization contracts
* refactor(query): deepen diagnosis, invariant report, and error taxonomy seams
* refactor(query): deepen dispatch plan, fallback bridge, policy snapshot, and hints seams
* refactor(query): deepen validation, fallback policy, capability, and result builder seams
* refactor(query): deepen resolution strategy, output classifier, observability, and policy-capability seams
* refactor(query): finalize deep strategy/classifier/observability/capability seams
* test/query: address coderabbit inline and out-of-diff dispatch nits
* fix(query): address remaining coderabbit input-validation and bridge stderr threads
* fix(query): address remaining coderabbit dispatch and strategy/output nits
2026-05-03 15:29:34 -04:00
Tom Boucher
f104dab332
refactor(query): deepen dispatch policy seam with structured result contract ( #3066 )
...
* refactor(query): deepen dispatch policy seam with structured result contract
Closes #3065 .
- unify query dispatch outcome as typed success/failure union
- include error kind/details + final exit_code in failure path
- align native and fallback paths under one dispatch policy seam
- make CLI query path consume seam result (thin adapter)
- add ADR + context term for Dispatch Policy Module
* refactor(query): strengthen dispatch seam with shared error mapper and typed details
- add query-dispatch-error-mapper module shared by native/fallback paths
- remove ad-hoc inline mapping in dispatch/fallback executors
- lock error-details schema in mapper + dispatch tests
- document structured dispatch contract in QUERY-HANDLERS.md
* fix(query): return structured fallback failure when path resolution throws
- guard resolveGsdToolsPath in cjs dispatch path
- map thrown resolution errors to fallback_failure result
- add regression test for structured failure contract
2026-05-03 14:30:27 -04:00
