3 Commits

Author	SHA1	Message	Date
Jeremy McSpadden	00c6a5ea68	fix(install): preserve non-array hook entries during uninstall (#1824) ... * fix(install): preserve non-array hook entries during uninstall Uninstall filtering returned null for hook entries without a hooks array, silently deleting user-owned entries with unexpected shapes. Return the entry unchanged instead so only GSD hooks are removed. * test(install): add regression test for non-array hook entry preservation (#1825) Fix mirrored filterGsdHooks helper to match production code and add test proving non-array hook entries survive uninstall filtering.	2026-04-05 23:07:59 -04:00
Jeremy McSpadden	175d89efa9	fix(install): uninstall hook safety — per-hook granularity, legacy migration, workflow-guard cleanup ... Addresses three findings from Codex adversarial review of #1768: - Uninstall settings cleanup now filters at per-hook granularity instead of per-entry. User hooks that share an entry with a GSD hook are preserved instead of being removed as collateral damage. - Add gsd-workflow-guard to PreToolUse/BeforeTool uninstall settings filter so opt-in users don't get dangling references after uninstall. - Codex install now strips legacy gsd-update-check.js hook entries before appending the corrected gsd-check-update.js, preventing duplicate hooks on upgrade from affected versions. - 8 new regression tests covering per-hook filtering, legacy migration regex. Fixes #1755	2026-04-05 10:46:40 -05:00
Jeremy McSpadden	84de0cc760	fix(install): comprehensive audit cleanup of hook copy, uninstall, and manifest (#1755) (#1768) ... - Add chmod +x for .sh hooks during install (fixes #1755 permission denied) - Fix Codex hook: wrong path (get-shit-done/hooks/) and inverted filename (gsd-update-check.js → gsd-check-update.js) - Fix cache invalidation path from ~/cache/ to ~/.cache/gsd/ - Track .sh hooks in writeManifest so saveLocalPatches detects modifications - Add gsd-workflow-guard.js to uninstall file cleanup list - Add community hooks (session-state, validate-commit, phase-boundary) to uninstall settings.json cleanup - Remove phantom gsd-check-update.sh from uninstall list - Remove dead isCursor/isWindsurf branches in uninstall (already handled by combined branch) - Warn when expected .sh hooks are missing after verifyInstalled - Add 15 regression tests in install-hooks-copy.test.cjs - Update codex-config.test.cjs assertions for corrected hook filename Fixes #1755	2026-04-05 11:37:27 -04:00