Commit Graph

3 Commits

Author SHA1 Message Date
0xdhx
dbbbd7e89d chore(#3156): re-point the changeset at the successor issue
#2665 was closed by #3134 (the narrow three-variable scrub) while this PR was
open, so the changeset's issue refs pointed at resolved work. Re-pointed to
#3156, which is the class this PR actually closes. Fragment content is
otherwise unchanged; changeset-lint returns ok_fragment_present.
2026-08-08 05:57:42 -05:00
0xdhx
209f2fe983 fix(#2665): exclude the test-instrumentation chain from the npm tarball
Review round 4, Major 1: scripts/live-config-guard.cjs is pure test
instrumentation and was shipping to every npm install. The repo already
carries the exclusion convention (gen-emitted-baseline, qa-smell-ratchet)
in the same files[] array.

Excluding the guard alone would trip the #2858 shipped-requires-only-shipped
gate: run-tests.cjs (shipped) requires it at load time, and
affected-tests-lib.cjs / run-affected-tests.cjs sit on the same chain. The
four files are one closed require chain of test instrumentation, so the
exclusion covers the chain, not one link. The guard's LOCATION header cited
affected-tests-lib.cjs as "the precedent for a non-shipped helper", which
npm pack disproves — rewritten to the tarball-exclusion fact.
2026-08-08 05:50:49 -05:00
0xdhx
fb02fa5722 chore(#2665): add the changeset fragment this PR now needs
Caught by CI on the round-3 push, not by review: `changeset-lint` went from
OK_NO_USER_FACING_CHANGES to FAIL_MISSING_FRAGMENT.

Both prior rounds passed that gate because the diff was tests/ + scripts/ only,
and neither is a USER_FACING_PREFIX. Round 3 is the first commit in this PR to
touch src/ — the descriptor hoist in src/runtime-homes.cts — and src/ is on the
list. So the fragment requirement is a direct consequence of the remedy shape,
not something the earlier rounds missed.

src/runtime-homes.cts is the ONLY user-facing file in the whole PR diff
(23 changed files); everything else is tests/, scripts/, CONTEXT.md, the two
generated CONTEXT-INDEX.json artifacts, and examples/.

Typed `Added` rather than `Fixed` because that is what actually reaches a user:
new exported constants on a shipped module. The fix itself (#2665) is test
hermeticity, which changes no shipped behaviour — resolveKimiHooksTomlDir()
resolves identically before and after.

Worth noting the local lint disagreed with CI and was wrong: it diffs
`origin/main...HEAD`, which sweeps in the base's own committed fragments and
returns a false ok_fragment_present. CI diffs `origin/$GITHUB_BASE_REF...HEAD`
(next) and sees only this PR's files, which is the correct question.
2026-08-08 05:50:49 -05:00