* test(#3337): fold the manifest & package-identity issue-* cluster — Wave 5
Folds 6 legacy issue-*.test.cjs regression files (120 test() blocks) into
their module's main suite, per H3 (#3315) of the test-hygiene epic (#3053).
Second of 4 issue-* waves.
- issue-766-plugin-manifest.test.cjs (50 tests): pure rename (git mv) into
plugin-manifest.test.cjs, sole comprehensive suite for its module.
- issue-844-manifest-version-sync.test.cjs (14 tests, rename basis) +
issue-1855-marketplace-manifest.test.cjs (17 tests, merged in): both
target scripts/sync-manifest-versions.cjs via non-overlapping describe
blocks (generic engine vs. marketplace.json-specific), now
manifest-version-sync.test.cjs, 31 tests, 0 dropped.
- issue-498-identity-drift-lint.test.cjs (8 tests, rename basis) +
issue-498-package-identity.test.cjs (17 tests, merged in): both target
package-identity.cjs's surface from different angles (lint-side drift
detection vs. derive/slugify), now package-identity.test.cjs, 25 tests,
0 dropped.
- issue-607-cache-lineage.test.cjs (14 tests) merged into the existing
gsd-statusline.test.cjs, matching its already-established fold-wrapper
convention from prior waves.
Learned from Wave 4: fold agents checked src/** (not just docs/ and
gsd-core/references/) for stale filename references — found and fixed 5
across 3 ADR docs (766, 2121, 457), zero in src/ this time.
Zero net test-coverage loss. No production code changed.
* test(#3337): fix orthogonal-review findings — Wave 5 fold
Standards-axis review found real issues in the just-folded
manifest-version-sync.test.cjs, both fixed here:
- The folded:issue-1855-marketplace-manifest block omitted its own
test/describe/assert/fs/path/os requires, silently closing over the
#844 basis section's outer-scope bindings instead of declaring its own
dependencies — inconsistent with every other fold block in this wave.
Restored the local requires the original issue-1855 file declared.
- Merging two independently-lettered legacy files (each A-F) left
duplicate top-level describe() labels (two "A:", two "B:", two "C:").
Renamed the folded-in #1855 labels (A2/B4/C2) to make every top-level
label in the file unique.
No test() count changed (31). No production code touched.
---------
Co-authored-by: sim <sim@local>
