2 Commits

Author	SHA1	Message	Date
Tom Boucher	0062f6d033	fix(#2845): stop the dimension parity guard counting a back-reference (#3752) ... next went red on dacae9273 against documentation that was correct. parseDeclaredCounts read any '<numeral> ... dimensions' collocation as a claim about the gsd-ui-checker dimension TOTAL. The how-to sentence 'Dimension 7 is a rule gsd-ui-checker follows, the same as the other six dimensions' refers to the other members of a seven-member set; the guard counted it as that document declaring six, and reported a count-mismatch on prose that was accurate. A drift guard that fires on correct prose is a false positive, which is how guards end up switched off. A negative lookbehind now excludes a numeral introduced by 'other' or 'remaining'. It is declared once as NOT_A_BACK_REFERENCE and shared by both English scans rather than written at each site — the same two-surface divergence class this suite exists to catch. Both scans apply it case-insensitively; the first cut of this fix had the digit scan case-sensitive and the word scan not, so a sentence-initial 'Other 6 dimensions' still slipped through. The exclusion is word-anchored, so 'another six dimensions' — a real claim about a second set — still counts. parseDeclaredCounts takes an excludeBackReferences opt-out so a test can prove against the REAL shipped how-to that the exclusion is load-bearing: with it off the file reports [6,7], with it on [7]. That replaces a raw substring match on prose, which the suite's own header forbids, with a typed before/after. The docs prose is deliberately unchanged. It is the only instance of the pattern in the tree, so keeping it means the real-tree assertion exercises the path this fix exists for instead of asserting only on fixtures. Regression tests cover both polarities: eight back-reference shapes including all four sentence-initial cases, five real count claims that must still count, the 'another' word-boundary case, and the shipped how-to itself. Known limits recorded in the code: the exclusion is English-only, because translated docs here are corrected to match English rather than authored, so there is no instance to model the grammar on; and it cannot distinguish a back-reference from a genuine total opening with the same word ('Other 6 dimensions were added'), where the false negative is the safer side of the trade. Why it reached next at all: the docs PR (#3746) was green. A doc-only diff inert-skips the test matrix in the PR lane, so the guard that reads docs never ran against the docs change that broke it — it fired on push to next, after merge. Co-authored-by: sim <sim@local>	2026-08-22 06:39:48 -04:00
Tom Boucher	4918c62d76	feat(#2845): require provenance for UI-SPEC component inventories (#3745) ... * test(#2845): failing-first suite for UI-SPEC inventory provenance Binds two shared formats before either exists, so the suite is RED against next: the gsd-ui-checker dimension roster (asserted independently on twelve surfaces, eight English and four translated) and the provenance-line grammar the UI-SPEC template emits and Dimension 7 consumes. Every parity assertion is paired with a synthetic mutation case, so the guard's failure branch executes rather than only reading a correct tree: limit-1 (a surface still declaring 6), limit (7), limit+1 (8), a dropped dimension, a label that drifts on one surface only, a non-contiguous roster, a duplicated number, and a surface that stops declaring a count at all. A seeded fast-check property renders the roster under formatting noise (CRLF, padding, interleaved sections) and asserts the parse round-trips and is strictly sensitive to a dropped heading. Assertions are on parsed typed records, never raw substrings. * docs: normalize design-a-ui-phase how-to to American English House style for docs/ is American English (CLAUDE.md). This file carried colour/initialisation/initialise/artefact throughout. Spelling only — no content change; kept separate from the #2845 feature commit so the release-notes classifier and the hotfix cherry-pick filter see it for what it is. * feat(#2845): require provenance for UI-SPEC component inventories A UI-SPEC's component inventory was treated downstream as a closed allowlist while the document recorded nothing about whether the list had been enumerated from the installed design system or recalled from memory. A recalled inventory is indistinguishable from an enumerated one, so an executor complying with the spec builds against a fraction of what the package offers, and every gate stays green because they assert semantics rather than composition. The UI-SPEC template gains a Component Inventory slot carrying one of two provenance lines: the command that enumerated the list, the count it returned, the resolved package@version and the date; or a Could not enumerate record with a real reason. gsd-ui-researcher gains an enumeration ladder and must record the line rather than write the list from recall. gsd-ui-checker gains Dimension 7. An inventory with no provenance line, a count with no command, an empty could-not-enumerate reason, or a line still carrying the template's unfilled placeholders BLOCKs; a partial line, a line placed below its table, or an honest negative record FLAGs; a complete line passes, and so does a spec carrying no inventory at all, which keeps every UI-SPEC predating the dimension validating unchanged. Whatever the verdict, an unsourced inventory is reported as a non-exhaustive list of known-good components rather than a closed allowlist, so the executor is never blocked from a component the spec merely failed to mention. The checker never runs the recorded command. The dimension count moved on all thirteen surfaces that assert it, across five languages. Also corrects the claim in the English, Korean and Portuguese how-tos that this checker applies a scored six-pillar rubric — that rubric belongs to /gsd-ui-review's retroactive audit. * chore(#2845): backfill changeset pr number to 3745 --------- Co-authored-by: sim <sim@local>	2026-08-21 11:59:56 -04:00