'use strict'; /** * Tests for `src/pattern.cts` — the pattern-construction seam (#3212 Phase 1, #3412). * * Design: .msd/phase/chore-3412-pattern-seam/40-design.md * Test matrix: .msd/phase/chore-3412-pattern-seam/50-test-matrix.md * ADR: docs/adr/3212-lexical-seam-consolidation.md §1, §2, §7 * * TDD RED: `src/pattern.cts` does not exist yet — this file's * `require('../msd-core/bin/lib/pattern.cjs')` throws MODULE_NOT_FOUND until * the implementing phase adds it. That is the intended starting state (mirrors * tests/planning-snapshot.test.cjs's RED convention). * * Covers test-matrix sections 1 (escapeRegex, rows 1-10), 2 (literalPattern, * rows 11-14), and 3 (migration equivalence, rows 15-17). */ const { test, describe } = require('node:test'); const assert = require('node:assert/strict'); // Seeded fast-check convention: require the shared setup helper (NOT // 'fast-check' directly) so numRuns/seed are configured globally before any // fc.assert() call — mirrors tests/frontmatter.property.test.cjs and every // other *.property.test.cjs file. seed: 42, overridable via MSD_FC_SEED. const fc = require('./helpers/fast-check-setup.cjs'); const { escapeRegex, literalPattern, compileUserPattern, MAX_USER_PATTERN_LEN } = require('../msd-core/bin/lib/pattern.cjs'); /** * A single `node -e` inline probe script testing RegExp.escape fallback * semantics -- one subprocess, no fan-out. Coincides numerically with * tests/helpers/timeouts.cjs's MSD_TOOLS_CLI_MODERATE_TIMEOUT_MS but * describes a different operation (an inline node -e probe, not a * msd-tools.cjs CLI subcommand spawn) -- kept local. */ const REGEXP_ESCAPE_PROBE_TIMEOUT_MS = 30_000; // ─── Section 1: escapeRegex — rows 1-10 ─────────────────────────────────── describe('escapeRegex', () => { test('row 1: "" returns ""', () => { assert.strictEqual(escapeRegex(''), ''); }); test('row 2: ordinary chars only ("_x") are unchanged', () => { assert.strictEqual(escapeRegex('_x'), '_x'); }); test('row 3: each metacharacter is escaped and the result matches its own literal form', () => { const metachars = ['.', '*', '+', '?', '^', '$', '{', '}', '(', ')', '|', '[', ']', '\\']; for (const ch of metachars) { const escaped = escapeRegex(ch); const re = new RegExp(escaped); assert.ok(re.test(ch), `escapeRegex(${JSON.stringify(ch)}) -> ${JSON.stringify(escaped)} must match its own literal char`); } }); test('row 4: leading ASCII letter locks the MEASURED hex-escape ("abc" -> "\\x61bc", Node v26.5.1)', () => { assert.strictEqual(escapeRegex('abc'), '\\x61bc'); }); test('row 5: leading digit locks the MEASURED hex-escape ("5abc" -> "\\x35abc", Node v26.5.1)', () => { assert.strictEqual(escapeRegex('5abc'), '\\x35abc'); }); test('row 6: hyphen anywhere locks the MEASURED hex-escape ("a-b" -> "\\x61\\x2db", Node v26.5.1)', () => { assert.strictEqual(escapeRegex('a-b'), '\\x61\\x2db'); }); test('row 7: whitespace / newline / control chars are escaped and the result still constructs', () => { const values = [' ', '\n', '\t', '\r', 'a\nb', 'a\tb\rc']; for (const v of values) { const escaped = escapeRegex(v); assert.doesNotThrow(() => new RegExp(escaped)); assert.ok(new RegExp(escaped).test(v)); } }); // #3212 Spec-axis review correction: this throw behavior matches MOST of the // deleted copies' `.replace` throw, but NOT ALL of them — `src/phase-id.cts`'s // original `escapeRegex(value: unknown)` did `String(value).replace(...)` and // never threw (`escapeRegex(42) === '42'`, `escapeRegex(null) === 'null'`, per // the deleted `tests/phase-id.test.cjs` assertions). That is a deliberate, // disclosed behavior change for phase-id's former callers: the seam's locked // signature (`escapeRegex(value: string): string`, ADR §1) does not coerce, so // a non-string reaching it now throws instead of silently stringifying. // Mitigated by an explicit `String(...)` wrap at the one former phase-id call // site that genuinely needed it (phaseMarkdownRegexSource's fallback branch, // src/phase-id.cts) — the seam's throw itself is intentional and stays. test('row 8: non-string input throws TypeError (matches 11 of the 12 deleted copies\' .replace throw — phase-id.cts\'s copy coerced instead, see comment above)', () => { for (const bad of [null, undefined, 42, {}, [], true]) { assert.throws(() => escapeRegex(bad), TypeError, `escapeRegex(${JSON.stringify(bad)}) must throw TypeError`); } }); test('row 9: a 10,000-char value does not throw and completes without catastrophic time', () => { const big = 'a-b.c*d'.repeat(1429); // ~10,001 chars let escaped; assert.doesNotThrow(() => { escaped = escapeRegex(big); }); assert.doesNotThrow(() => new RegExp(escaped)); }); test('row 10: RegExp.escape availability — the ADR §2 floor-vs-capability assertion', () => { assert.strictEqual(typeof RegExp.escape, 'function'); }); }); // ─── Section 2: literalPattern — rows 11-14 ─────────────────────────────── describe('literalPattern', () => { test('row 11: value + no flags produces a RegExp matching the value literally', () => { const re = literalPattern('abc'); assert.ok(re instanceof RegExp); assert.ok(re.test('abc')); }); test('row 12: value + valid flags ("gi") applies the flags', () => { const re = literalPattern('abc', 'gi'); assert.strictEqual(re.flags, 'gi'); assert.ok(re.test('ABC')); }); test('row 13: invalid flags ("qq") throws SyntaxError from RegExp', () => { assert.throws(() => literalPattern('abc', 'qq'), SyntaxError); }); test('row 14: metacharacter-heavy value matches literally, not by its metacharacter interpretation', () => { const re = literalPattern('a.b*c'); assert.ok(re.test('a.b*c'), 'must match the literal string'); // If '.' and '*' were left live, this would ALSO match (any-char + zero-or-more) assert.ok(!re.test('aXbYYYc'), 'must NOT match the metacharacter interpretation'); }); }); // ─── Section 3: migration equivalence — rows 15-17 (load-bearing) ───────── describe('migration equivalence (row-9 sweep)', () => { test('row 15: property — hand oracle and escapeRegex are match-equivalent for all (s, probe) pairs (seeded)', () => { // `hand` is the historical oracle: the deleted pre-migration implementation, // byte-identical across all twelve copies before this seam existed (design // doc "Ground truth" #1; ADR §7 Class 1 census). It is inlined here ONLY as // a test oracle for this equivalence sweep — this is NOT a 13th production // copy of the escape helper (design doc Notes: "not a 13th production copy"). // eslint-disable-next-line local/no-adhoc-regex-escape -- historical oracle for the row-15 equivalence sweep, not a production copy (#3412) const hand = (s) => s.replace(/[.*+?^${}()|[\]\\]/g, '\\$&'); fc.assert( fc.property( fc.string({ maxLength: 200 }), fc.string({ maxLength: 50 }), (s, probe) => { const handResult = new RegExp(hand(s)).test(probe); const seamResult = new RegExp(escapeRegex(s)).test(probe); assert.strictEqual( seamResult, handResult, `match divergence for s=${JSON.stringify(s)} probe=${JSON.stringify(probe)}` ); } ) ); }); test('row 16: the real corpus — phase tokens, milestone versions, STATE field names, runtime ids are match-equivalent', () => { // eslint-disable-next-line local/no-adhoc-regex-escape -- historical oracle for the row-16 equivalence sweep, not a production copy (#3412) const hand = (s) => s.replace(/[.*+?^${}()|[\]\\]/g, '\\$&'); const corpus = [ '1A', 'PROJ-05', '999.1', 'v1.2', '**Current Phase:**', 'claude-code', 'gemini-cli', ]; const probes = ['1A', 'PROJ-05', '999.1', 'v1.2', '**Current Phase:**', 'claude-code', 'gemini-cli', 'no-match-here']; for (const s of corpus) { for (const probe of probes) { const handResult = new RegExp(hand(s)).test(probe); const seamResult = new RegExp(escapeRegex(s)).test(probe); assert.strictEqual( seamResult, handResult, `corpus divergence for s=${JSON.stringify(s)} probe=${JSON.stringify(probe)}` ); } } }); test('row 17: latent-bug fix — a hyphen interpolated into a character class no longer forms a range', () => { // Pre-migration (hand-rolled, verified): new RegExp('[' + hand('a-z') + ']').test('m') === true // — the unescaped '-' formed an unintended a-through-z RANGE that happened // to match 'm'. This is design row 10's confirmed latent bug. // eslint-disable-next-line local/no-adhoc-regex-escape -- historical oracle for the row-17 latent-bug check, not a production copy (#3412) const hand = (s) => s.replace(/[.*+?^${}()|[\]\\]/g, '\\$&'); assert.strictEqual( new RegExp('[' + hand('a-z') + ']').test('m'), true, 'sanity check: pre-migration hand-rolled behavior was true (verified)' ); // Post-migration (the seam): the fix. 'a', '-', 'z' are all escaped as // discrete literal characters, so '[...]' no longer forms a range and 'm' // (interior to the would-be range) must NOT match. assert.strictEqual( new RegExp('[' + escapeRegex('a-z') + ']').test('m'), false, 'deliberate fix, not an accident: the seam must not let a value form a character-class range' ); }); }); // ─── Section 4: #3498 — Node-22 fallback (no RegExp.escape) ───────────────── describe('escapeRegex without RegExp.escape (#3498 Node-22 fallback)', () => { // `RegExp.escape` is ES2026 (first shipped in Node 24). The msd-test matrix // runs a linux-node22 lane and the BUILD consumes this module // (scripts/gen-loop-host-contract.cjs), so the seam must work when the // builtin is absent. Simulated in a child process: neuter RegExp.escape // BEFORE require (module-load capture must select the fallback), then assert // match-behavior correctness — this file's doctrine (pattern TEXT differs // between builtin and fallback; match behavior must not). const { runNode, OUTCOME } = require('./helpers/process-seam.cjs'); const path = require('node:path'); const LIB = path.join(__dirname, '..', 'msd-core', 'bin', 'lib', 'pattern.cjs'); const PROBE = [ "RegExp.escape = undefined;", "const { escapeRegex, literalPattern } = require(" + JSON.stringify(LIB) + ");", "const corpus = ['a.b*c', '^dollar$', '(group|alt)', '[b]{1,2}', 'back\\\\slash', 'plain', 'q+x?y', 'a-b-c', ''];", "for (const v of corpus) {", " if (!new RegExp(escapeRegex(v)).test(v)) { console.error('self-match fail: ' + JSON.stringify(v)); process.exit(1); }", " if (!literalPattern(v).test(v)) { console.error('literalPattern fail: ' + JSON.stringify(v)); process.exit(1); }", "}", "if (new RegExp(escapeRegex('a.b*c')).test('aXbZc')) { console.error('metachar reinterpreted'); process.exit(1); }", "if (new RegExp(escapeRegex('(a|b)')).test('a')) { console.error('alternation reinterpreted'); process.exit(1); }", "console.log('fallback-ok');", ].join('\n'); test('builds and escapes correctly when RegExp.escape is absent (Node 22 semantics)', () => { const r = runNode(['-e', PROBE], { timeoutMs: REGEXP_ESCAPE_PROBE_TIMEOUT_MS }); assert.strictEqual(r.outcome, OUTCOME.EXITED, `probe must run: ${r.stderr}`); assert.strictEqual(r.exitCode, 0, `fallback path failed: ${r.stdout}\n${r.stderr}`); assert.match(r.stdout, /fallback-ok/); }); test('neutering AFTER require must not flip the path mid-process (capture at load)', () => { const PROBE2 = [ "const { escapeRegex } = require(" + JSON.stringify(LIB) + ");", "RegExp.escape = undefined;", "if (!new RegExp(escapeRegex('a.b')).test('a.b')) { console.error('post-load neuter broke escaping'); process.exit(1); }", "console.log('capture-ok');", ].join('\n'); const r = runNode(['-e', PROBE2], { timeoutMs: REGEXP_ESCAPE_PROBE_TIMEOUT_MS }); assert.strictEqual(r.outcome, OUTCOME.EXITED, `probe must run: ${r.stderr}`); assert.strictEqual(r.exitCode, 0, `post-load capture failed: ${r.stdout}\n${r.stderr}`); }); }); // ─── Section 5: compileUserPattern — RE2 linear-time engine (#3477) ──────── // // re2js guarantees match time linear in input length — there is no // backtracking engine to exploit, so the vulnerability class is closed by // the engine rather than detected by a heuristic scan of the pattern text // (the hand-rolled `hasRiskyBacktrackingGroup` scanner this seam used to run // is deleted). Assertions here are BEHAVIORAL ONLY — never against // `RegExp.source` or any RegExp-shaped property, because the result is no // longer a RegExp at all. describe('compileUserPattern', () => { test('a plain safe pattern compiles and reports neutralized: null', () => { const { test: matches, neutralized } = compileUserPattern('fetch.*api/feed'); assert.strictEqual(matches('do a fetch of the api/feed endpoint'), true); assert.strictEqual(matches('completely unrelated text'), false); assert.strictEqual(neutralized, null); }); test('boundary: a pattern at MAX_USER_PATTERN_LEN - 1 compiles', () => { const p = 'a'.repeat(MAX_USER_PATTERN_LEN - 1); const { test: matches, neutralized } = compileUserPattern(p); assert.strictEqual(matches(p), true); assert.strictEqual(matches('b'.repeat(MAX_USER_PATTERN_LEN - 1)), false); assert.strictEqual(neutralized, null); }); test('boundary: a pattern at exactly MAX_USER_PATTERN_LEN compiles', () => { const p = 'a'.repeat(MAX_USER_PATTERN_LEN); const { test: matches, neutralized } = compileUserPattern(p); assert.strictEqual(matches(p), true); assert.strictEqual(matches('b'.repeat(MAX_USER_PATTERN_LEN)), false); assert.strictEqual(neutralized, null); }); test('boundary: a pattern at MAX_USER_PATTERN_LEN + 1 (513 chars) is refused, never matches', () => { const p = 'a'.repeat(MAX_USER_PATTERN_LEN + 1); assert.strictEqual(p.length, 513); const { test: matches, neutralized } = compileUserPattern(p); assert.strictEqual(matches(p), false); assert.strictEqual(matches(p.slice(0, MAX_USER_PATTERN_LEN)), false); assert.strictEqual(neutralized, 'too-long'); }); test('empty string input is refused, never matches', () => { const { test: matches, neutralized } = compileUserPattern(''); assert.strictEqual(matches(''), false); assert.strictEqual(matches('anything'), false); assert.strictEqual(neutralized, 'empty'); }); test('non-string input is refused, never matches', () => { for (const bad of [null, undefined, 42, {}, []]) { const { test: matches, neutralized } = compileUserPattern(bad); assert.strictEqual(matches(''), false); assert.strictEqual(matches('anything'), false); assert.strictEqual(neutralized, 'empty'); } }); test('property: for any string input, compileUserPattern returns a well-shaped result and never throws', () => { // maxLength: 600 straddles MAX_USER_PATTERN_LEN (512) so fast-check actually // exercises the >512 'too-long' branch. A neutralized result must never be // able to report a match against arbitrary input — the security invariant. const validNeutralizations = new Set(['empty', 'too-long', 'unsupported', null]); fc.assert( fc.property(fc.string({ maxLength: 600 }), fc.string({ maxLength: 50 }), (s, probe) => { let result; assert.doesNotThrow(() => { result = compileUserPattern(s); }); assert.strictEqual(typeof result.test, 'function'); assert.ok(validNeutralizations.has(result.neutralized)); if (result.neutralized !== null) { let matched; assert.doesNotThrow(() => { matched = result.test(probe); }); assert.strictEqual(matched, false, `neutralized (${result.neutralized}) result must never match: s=${JSON.stringify(s)} probe=${JSON.stringify(probe)}`); } }) ); }); test('a known-valid regex round-trips through the >512-length property test unmangled', () => { // Companion assertion for the property test above: a legitimate long-ish // regex must still compile (neutralized: null), not just "didn't throw" — // pins that the length straddle doesn't accidentally neutralize everything // under 512 chars too. const p = 'fetch\\(.*\\)\\.then\\(' + 'x'.repeat(400) + '\\)'; assert.ok(p.length < MAX_USER_PATTERN_LEN, 'sanity: fixture must stay under the length threshold'); const { test: matches, neutralized } = compileUserPattern(p); assert.strictEqual(neutralized, null); assert.strictEqual(matches('fetch(url).then(' + 'x'.repeat(400) + ')'), true); assert.strictEqual(matches('unrelated text'), false); }); }); // ─── Section 6: RE2 engine acceptance table (#3477 follow-up) ───────────── // // The prior hand-rolled screen either hung (patterns it missed, run live // through the JS backtracking engine) or wrongly refused (patterns it // flagged as risky-shaped that are actually linear) on the rows below. RE2 // closes both failure modes: every MUST_COMPILE row below is evaluated for // real, in linear time, with a correct match verdict — no heuristic, // no false refusal. describe('compileUserPattern — RE2 engine acceptance table', () => { // [pattern, subjectA, subjectB, expectedA, expectedB]. Every one of these // patterns is plain JS-valid ERE syntax (no backreferences/look-around), so // the expected/expectedB booleans are exactly what `new RegExp(p).test(...)` // would report — computed offline rather than hand-assumed, since a // `*`/`?`-quantified pattern with nothing required outside the optional // part (e.g. `(a|a)*$`, `(abc)?`, `(abc)*`) trivially matches an unanchored // `.test()` against ANY subject (zero-width match), which is correct // JS-regex semantics, not a defect. The expectations are hardcoded rather // than oracle-derived because running these patterns through the JS // backtracking engine (`new RegExp(p).test(...)`) is the exact // catastrophic-backtracking vulnerability this issue is about — the suite // must never execute that engine against them, even with short subjects. const MUST_COMPILE = [ ['(a+)+$', 'aaaa', 'bbbb', true, false], ['(a|a)*$', 'aaaa', 'aaab', true, true], ['((a+))+$', 'aaaa', 'aaab', true, false], ['(a+){2,}$', 'aaaa', 'a', true, false], ['(a{1,3})+$', 'aaaaaa', 'bbbbbb', true, false], ['^(\\s*\\w+)+$', 'foo bar baz', 'foo, bar', true, false], ['fetch.*api/feed', 'do a fetch of the api/feed endpoint', 'completely unrelated text', true, false], ['prisma\\.message\\.(find|create)', 'call prisma.message.find(x)', 'call prisma.other.find(x)', true, false], ['(abc)?', 'abc', '', true, true], ['(abc)*', 'abcabc', 'xyz', true, true], ['^\\s*export\\s+function\\s+\\w+', ' export function foo() {}', 'const foo = 1', true, false], ]; const MUST_REFUSE = ['(\\w+)\\1', '(?!x)a']; for (const [p, subjectA, subjectB, expectedA, expectedB] of MUST_COMPILE) { test(`compiles and evaluates correctly: ${JSON.stringify(p)}`, () => { const { test: matches, neutralized } = compileUserPattern(p); assert.strictEqual(neutralized, null, `expected null for ${JSON.stringify(p)}, got ${JSON.stringify(neutralized)}`); assert.strictEqual( matches(subjectA), expectedA, `expected ${JSON.stringify(p)} against ${JSON.stringify(subjectA)} to match real regex semantics` ); assert.strictEqual( matches(subjectB), expectedB, `expected ${JSON.stringify(p)} against ${JSON.stringify(subjectB)} to match real regex semantics` ); }); } for (const p of MUST_REFUSE) { test(`is refused (unsupported RE2 syntax): ${JSON.stringify(p)}`, () => { const { test: matches, neutralized } = compileUserPattern(p); assert.strictEqual(neutralized, 'unsupported', `expected 'unsupported' for ${JSON.stringify(p)}, got ${JSON.stringify(neutralized)}`); assert.strictEqual(matches('anything'), false); }); } });