'use strict'; process.env.MSD_TEST_MODE = '1'; // Issue #498 (candidate 3): resolveUpdateContext ports update.md's ~280-line // get_installed_version bash into a pure, injected-fs function. It returns the // same 4-field contract the workflow emits: { installedVersion, scope, runtime, // msdDir }. The fs is injected (exists/readFile) so the precedence cascade is // finally testable without a live multi-runtime install. const { test, describe } = require('node:test'); const assert = require('node:assert/strict'); const path = require('node:path'); const nodeFs = require('node:fs'); const os = require('node:os'); const { runNode } = require('./helpers/process-seam.cjs'); const { throwIfFailed } = require('./helpers/git-fixture.cjs'); const { PROBE_TIMEOUT_MS } = require('./helpers/timeouts.cjs'); const ROOT = path.join(__dirname, '..'); const MSD_TOOLS = path.join(ROOT, 'msd-core', 'bin', 'msd-tools.cjs'); const { cleanup } = require('./helpers.cjs'); const { RUNTIME_DIRS, inferPreferredRuntime, resolveUpdateContext } = require( path.join(ROOT, 'msd-core', 'bin', 'lib', 'update-context.cjs'), ); // Normalize a path to a platform-agnostic key: resolve to absolute, then // lowercase forward-slash form. This makes the fake fs match the resolver's // path.join/path.resolve lookups on Windows (backslash + drive letter) as well // as POSIX, so these unit tests are not OS-coupled. function normKey(p) { return path.resolve(p).replace(/\\/g, '/').toLowerCase(); } // Build an injected fs from a map of absolute path -> contents. Marker files // (VERSION, workflows/update.md) just need to "exist". function fakeFs(files) { const set = new Map(); for (const [k, v] of Object.entries(files)) set.set(normKey(k), v); return { exists: (p) => set.has(normKey(p)), readFile: (p) => { const k = normKey(p); return set.has(k) ? set.get(k) : null; }, }; } // Compare resolved-dir results without coupling to OS path style. function sameDir(a, b) { return normKey(a) === normKey(b); } const HOME = '/home/u'; const CWD = '/work/proj'; function ver(dir) { return `${dir}/msd-core/VERSION`; } function marker(dir) { return `${dir}/msd-core/workflows/update.md`; } test('unknown preferred config does not infer Claude', () => { assert.equal(inferPreferredRuntime({ fs: fakeFs({}), env: {}, preferredConfigDir: '/opt/unknown' }), ''); }); test('known runtime directories infer their table runtime without config markers', () => { for (const [runtime, relativeDir] of RUNTIME_DIRS) { const preferredConfigDir = path.resolve(HOME, relativeDir); assert.equal( inferPreferredRuntime({ fs: fakeFs({}), env: {}, preferredConfigDir }), runtime, preferredConfigDir, ); } }); describe('resolveUpdateContext: scope cascade', () => { test('GLOBAL claude install under $HOME/.claude', () => { const fs = fakeFs({ [ver(`${HOME}/.claude`)]: '1.40.0\n', [marker(`${HOME}/.claude`)]: 'x' }); const r = resolveUpdateContext({ home: HOME, cwd: CWD, env: {}, fs }); assert.equal(r.installedVersion, '1.40.0'); assert.equal(r.scope, 'GLOBAL'); assert.equal(r.runtime, 'claude'); assert.ok(sameDir(r.msdDir, `${HOME}/.claude`), `msdDir was ${r.msdDir}`); }); test('LOCAL install under ./.claude takes priority over global', () => { const fs = fakeFs({ [ver(`${CWD}/.claude`)]: '1.39.0\n', [marker(`${CWD}/.claude`)]: 'x', [ver(`${HOME}/.claude`)]: '1.40.0\n', [marker(`${HOME}/.claude`)]: 'x', }); const r = resolveUpdateContext({ home: HOME, cwd: CWD, env: {}, fs }); assert.equal(r.scope, 'LOCAL'); assert.equal(r.installedVersion, '1.39.0'); assert.ok(sameDir(r.msdDir, `${CWD}/.claude`), `msdDir was ${r.msdDir}`); }); test('cwd === home does NOT misdetect as LOCAL (dedup)', () => { const fs = fakeFs({ [ver(`${HOME}/.claude`)]: '1.40.0\n', [marker(`${HOME}/.claude`)]: 'x' }); const r = resolveUpdateContext({ home: HOME, cwd: HOME, env: {}, fs }); assert.equal(r.scope, 'GLOBAL'); }); test('runtime detected but VERSION missing -> 0.0.0, keep scope/runtime', () => { const fs = fakeFs({ [marker(`${HOME}/.codex`)]: 'x' }); const r = resolveUpdateContext({ home: HOME, cwd: CWD, env: {}, fs }); assert.equal(r.installedVersion, '0.0.0'); assert.equal(r.scope, 'GLOBAL'); assert.equal(r.runtime, 'codex'); }); test('no install anywhere -> UNKNOWN / empty runtime / empty msdDir', () => { const r = resolveUpdateContext({ home: HOME, cwd: CWD, env: {}, fs: fakeFs({}) }); assert.deepEqual(r, { installedVersion: '0.0.0', scope: 'UNKNOWN', runtime: '', msdDir: '' }); assert.deepEqual( resolveUpdateContext({ home: HOME, cwd: CWD, env: {}, fs: fakeFs({}) }), r, 'unresolved resolution must remain deterministic', ); }); test('multiple installs honor an explicit preferred runtime', () => { const claude = `${HOME}/.claude`; const codex = `${HOME}/.codex`; const fs = fakeFs({ [ver(claude)]: '1.40.0\n', [marker(claude)]: 'x', [ver(codex)]: '1.41.0\n', [marker(codex)]: 'x', }); const r = resolveUpdateContext({ home: HOME, cwd: CWD, env: {}, fs, preferredRuntime: 'codex', }); assert.equal(r.runtime, 'codex'); assert.equal(r.scope, 'GLOBAL'); assert.ok(sameDir(r.msdDir, codex), `msdDir was ${r.msdDir}`); }); }); describe('resolveUpdateContext: runtime probing + env overrides', () => { test('opencode global under $HOME/.config/opencode', () => { const dir = `${HOME}/.config/opencode`; const fs = fakeFs({ [ver(dir)]: '1.40.0\n', [marker(dir)]: 'x' }); const r = resolveUpdateContext({ home: HOME, cwd: CWD, env: {}, fs }); assert.equal(r.runtime, 'opencode'); assert.ok(sameDir(r.msdDir, dir), `msdDir was ${r.msdDir}`); }); test('CLAUDE_CONFIG_DIR env override locates a custom global dir', () => { const custom = '/opt/claude-home'; const fs = fakeFs({ [ver(custom)]: '1.40.0\n', [marker(custom)]: 'x' }); const r = resolveUpdateContext({ home: HOME, cwd: CWD, env: { CLAUDE_CONFIG_DIR: custom }, fs }); assert.equal(r.scope, 'GLOBAL'); assert.equal(r.runtime, 'claude'); assert.ok(sameDir(r.msdDir, custom), `msdDir was ${r.msdDir}`); }); test('preferredConfigDir fast-path: trusts a validated custom dir as GLOBAL', () => { const custom = '/opt/msd-x'; const fs = fakeFs({ [ver(custom)]: '1.41.0\n', [marker(custom)]: 'x' }); const r = resolveUpdateContext({ home: HOME, cwd: CWD, env: {}, fs, preferredConfigDir: custom, preferredRuntime: 'opencode', }); assert.equal(r.scope, 'GLOBAL'); assert.equal(r.runtime, 'opencode'); assert.ok(sameDir(r.msdDir, custom), `msdDir was ${r.msdDir}`); assert.equal(r.installedVersion, '1.41.0'); }); test('preferredConfigDir fast-path: unknown dir with no preferredRuntime resolves runtime empty (#4153)', () => { const custom = '/opt/custom-msd'; const fs = fakeFs({ [ver(custom)]: '1.0.0\n', [marker(custom)]: 'x' }); const r = resolveUpdateContext({ home: HOME, cwd: CWD, env: {}, fs, preferredConfigDir: custom }); assert.equal(r.scope, 'GLOBAL'); assert.equal(r.runtime, '', 'a dir matching no RUNTIME_DIRS suffix, marker, or env must fail closed, not default to claude'); }); }); describe('resolveUpdateContext: preferredConfigDir fast-path dedup (#4197)', () => { test('cwd === home does NOT misdetect as LOCAL on the preferredConfigDir fast path (dedup)', () => { // #4197: the fast path derived scope from a cwd-relative match alone, so a // global install probed with cwd === $HOME answered LOCAL. The cascade's // same-path dedup (update.md: "local-over-global with same-path dedup (so // CWD=$HOME does not misdetect as LOCAL)") must hold on the fast path too. const fs = fakeFs({ [ver(`${HOME}/.claude`)]: '1.40.0\n', [marker(`${HOME}/.claude`)]: 'x' }); const r = resolveUpdateContext({ home: HOME, cwd: HOME, env: {}, fs, preferredConfigDir: `${HOME}/.claude`, preferredRuntime: 'claude', }); assert.equal(r.scope, 'GLOBAL'); }); test('same global install resolves identically from home and elsewhere on the fast path', () => { const fs = fakeFs({ [ver(`${HOME}/.claude`)]: '1.40.0\n', [marker(`${HOME}/.claude`)]: 'x' }); const inputs = { home: HOME, env: {}, fs, preferredConfigDir: `${HOME}/.claude`, preferredRuntime: 'claude', }; const fromElsewhere = resolveUpdateContext({ ...inputs, cwd: CWD }); assert.equal(fromElsewhere.scope, 'GLOBAL'); assert.deepEqual( resolveUpdateContext({ ...inputs, cwd: HOME }), fromElsewhere, 'scope must not depend on which directory the shell is sitting in', ); }); test('genuine project-local install stays LOCAL on the fast path', () => { // Control: the dedup must not over-correct into GLOBAL-always. A preferred // dir that is the cwd-relative install and NOT the selected global is LOCAL. const fs = fakeFs({ [ver(`${CWD}/.claude`)]: '1.39.0\n', [marker(`${CWD}/.claude`)]: 'x' }); const r = resolveUpdateContext({ home: HOME, cwd: CWD, env: {}, fs, preferredConfigDir: `${CWD}/.claude`, preferredRuntime: 'claude', }); assert.equal(r.scope, 'LOCAL'); assert.equal(r.installedVersion, '1.39.0'); assert.ok(sameDir(r.msdDir, `${CWD}/.claude`), `msdDir was ${r.msdDir}`); }); test('genuine project-local install stays LOCAL even with a global install also present', () => { const fs = fakeFs({ [ver(`${CWD}/.claude`)]: '1.39.0\n', [marker(`${CWD}/.claude`)]: 'x', [ver(`${HOME}/.claude`)]: '1.40.0\n', [marker(`${HOME}/.claude`)]: 'x', }); const r = resolveUpdateContext({ home: HOME, cwd: CWD, env: {}, fs, preferredConfigDir: `${CWD}/.claude`, preferredRuntime: 'claude', }); assert.equal(r.scope, 'LOCAL'); assert.equal(r.installedVersion, '1.39.0'); }); test('env-directed global elsewhere: $HOME/.claude is LOCAL and the fast path agrees with the cascade', () => { // The dedup must compare against the SELECTED global candidate (env-ranked), // not the $HOME pathname: with CLAUDE_CONFIG_DIR pointing the global at // /opt/claude-global, $HOME/.claude probed from cwd === $HOME is a genuine // cwd-local install, and the cascade already answers LOCAL for it. const custom = '/opt/claude-global'; const fs = fakeFs({ [ver(`${HOME}/.claude`)]: '1.39.0\n', [marker(`${HOME}/.claude`)]: 'x', [ver(custom)]: '1.40.0\n', [marker(custom)]: 'x', }); const env = { CLAUDE_CONFIG_DIR: custom }; const cascade = resolveUpdateContext({ home: HOME, cwd: HOME, env, fs }); const fast = resolveUpdateContext({ home: HOME, cwd: HOME, env, fs, preferredConfigDir: `${HOME}/.claude`, preferredRuntime: 'claude', }); assert.equal(cascade.scope, 'LOCAL'); assert.equal(fast.scope, cascade.scope); assert.equal(fast.installedVersion, cascade.installedVersion); assert.equal(fast.runtime, cascade.runtime); assert.ok(sameDir(fast.msdDir, cascade.msdDir), `fast msdDir ${fast.msdDir} vs cascade ${cascade.msdDir}`); }); test('env candidate IS the preferred dir: fast path answers GLOBAL, matching the cascade', () => { // A preferred dir that is also the env-directed global is the selected // global — the cascade answers GLOBAL, and the fast path must agree. const fs = fakeFs({ [ver(`${HOME}/.claude`)]: '1.40.0\n', [marker(`${HOME}/.claude`)]: 'x' }); const env = { CLAUDE_CONFIG_DIR: `${HOME}/.claude` }; const cascade = resolveUpdateContext({ home: HOME, cwd: HOME, env, fs }); const fast = resolveUpdateContext({ home: HOME, cwd: HOME, env, fs, preferredConfigDir: `${HOME}/.claude`, preferredRuntime: 'claude', }); assert.equal(cascade.scope, 'GLOBAL'); assert.equal(fast.scope, cascade.scope); assert.equal(fast.installedVersion, cascade.installedVersion); assert.equal(fast.runtime, cascade.runtime); assert.ok(sameDir(fast.msdDir, cascade.msdDir), `fast msdDir ${fast.msdDir} vs cascade ${cascade.msdDir}`); }); }); describe('msd-tools update-context (CLI): emits the JSON contract', () => { test('--config-dir fixture resolves to the documented 4-field JSON', () => { const tmp = nodeFs.mkdtempSync(path.join(os.tmpdir(), 'msd-uc-')); try { nodeFs.mkdirSync(path.join(tmp, 'msd-core', 'workflows'), { recursive: true }); nodeFs.writeFileSync(path.join(tmp, 'msd-core', 'VERSION'), '1.42.0\n'); nodeFs.writeFileSync(path.join(tmp, 'msd-core', 'workflows', 'update.md'), 'x'); const r = runNode( [MSD_TOOLS, 'update-context', '--config-dir', tmp, '--runtime', 'opencode', '--json'], { env: { ...process.env, MSD_TEST_MODE: '1' }, timeoutMs: PROBE_TIMEOUT_MS }, ); throwIfFailed(r, 'msd-tools update-context --json'); const ctx = JSON.parse(r.stdout); assert.deepEqual(Object.keys(ctx).sort(), ['installedVersion', 'msdDir', 'runtime', 'scope']); assert.equal(ctx.installedVersion, '1.42.0'); assert.equal(ctx.scope, 'GLOBAL'); assert.equal(ctx.runtime, 'opencode'); } finally { cleanup(tmp); } }); }); describe('resolveUpdateContext: parity with the old inline bash (adversarial-review)', () => { test('preferredConfigDir with a leading ~/ is expanded before the fast path', () => { // The old inline bash ran `expand_home "$PREFERRED_CONFIG_DIR"` first, so a // custom --config-dir like ~/custom-msd must resolve, not fall to UNKNOWN. const fs = fakeFs({ [ver(`${HOME}/custom-msd`)]: '1.41.0\n', [marker(`${HOME}/custom-msd`)]: 'x', }); const r = resolveUpdateContext({ home: HOME, cwd: CWD, env: {}, fs, preferredConfigDir: '~/custom-msd', }); assert.equal(r.installedVersion, '1.41.0'); assert.equal(r.scope, 'GLOBAL'); assert.ok(sameDir(r.msdDir, `${HOME}/custom-msd`), `msdDir was ${r.msdDir}`); }); test('a VERSION-only dir (no update.md marker) is NOT trusted as a real version', () => { // The old cascade required BOTH VERSION and the update.md marker before // trusting the version; a partial dir falls to 0.0.0 but keeps scope. const fs = fakeFs({ [ver(`${HOME}/.claude`)]: '1.40.0\n' }); // marker absent const r = resolveUpdateContext({ home: HOME, cwd: CWD, env: {}, fs }); assert.equal(r.installedVersion, '0.0.0', 'VERSION-only dir must not be trusted'); assert.equal(r.scope, 'GLOBAL'); assert.equal(r.runtime, 'claude'); assert.ok(sameDir(r.msdDir, `${HOME}/.claude`), `msdDir was ${r.msdDir}`); }); test('fast path also requires the marker: VERSION-only preferredConfigDir -> 0.0.0', () => { // The "trust = VERSION + marker" rule is consistent across every path, not // just the cascade. A custom --config-dir with VERSION but no marker is a // partial install: keep the dir/scope, report 0.0.0. const custom = '/opt/msd-partial'; const fs = fakeFs({ [ver(custom)]: '1.41.0\n' }); // marker absent const r = resolveUpdateContext({ home: HOME, cwd: CWD, env: {}, fs, preferredConfigDir: custom, preferredRuntime: 'opencode', }); assert.equal(r.installedVersion, '0.0.0', 'VERSION-only fast path must not be trusted'); assert.equal(r.scope, 'GLOBAL'); assert.ok(sameDir(r.msdDir, custom), `msdDir was ${r.msdDir}`); }); test('partial install with cwd===home does NOT misdetect as LOCAL (fallback dedup)', () => { // Same same-path dedup the trusted path uses must apply to the 0.0.0 // fallback: a VERSION-only ~/.claude probed from cwd===home is GLOBAL. const fs = fakeFs({ [ver(`${HOME}/.claude`)]: '1.40.0\n' }); // marker absent const r = resolveUpdateContext({ home: HOME, cwd: HOME, env: {}, fs }); assert.equal(r.installedVersion, '0.0.0'); assert.equal(r.scope, 'GLOBAL', 'cwd===home partial must be GLOBAL, not LOCAL'); assert.ok(sameDir(r.msdDir, `${HOME}/.claude`), `msdDir was ${r.msdDir}`); }); });