msd-core/tests/opencode-imperative-reference.test.cjs

// allow-test-rule: structural-regression-guard — AC2 requires asserting no `runtime === 'opencode'` string-equality branch remains in bin/install.js/src — the descriptor-migration contract is a property of the source text, so a source-grep is the only faithful check (#2087)
'use strict';

/**
 * opencode imperative reference host — ADR-1239 Phase D / #2087 (EoS/opencode).
 *
 * Proves opencode is driven through the PUBLIC Host-Integration Interface (the
 * imperative adapter), that its negotiated axes classify + negotiate correctly,
 * that negotiation fails CLOSED on a corrupted descriptor, that opencode's
 * SYNCHRONOUS dispatch force-flattens (#2598 retracts #2087's background
 * "upgrade" — the capability is behind an opt-in flag, not default-on), and that
 * the migration retired the hardcoded
 * `runtime === 'opencode'` / `isOpencode` branches (folded into descriptor-driven
 * `runtime.hostBehaviors` + the combined-family engine install path).
 */

const { test, describe, beforeEach, afterEach } = require('node:test');
const assert = require('node:assert/strict');
const fs = require('node:fs');
const path = require('node:path');

const { createImperativeAdapter } = require('../msd-core/bin/lib/adapter-imperative.cjs');
const {
  profileOf,
  negotiateHostCapabilities,
  shouldFlattenDispatch,
  extensionEventSurfaceFor,
  PROFILE_BASELINES,
  UNDOCUMENTED,
} = require('../msd-core/bin/lib/host-integration.cjs');

const OC_CAP = JSON.parse(
  fs.readFileSync(path.join(__dirname, '..', 'capabilities', 'opencode', 'capability.json'), 'utf8'),
);
const OC_AXES = OC_CAP.runtime.hostIntegration;

// -- AC2: driven through the public interface (imperative adapter) -----------

test('createImperativeAdapter classifies opencode as imperative + composes the registry', () => {
  const adapter = createImperativeAdapter({ runtime: 'opencode' });
  assert.equal(adapter.kind, 'imperative');
  assert.equal(adapter.runtime, 'opencode');
  assert.ok(adapter.registry && typeof adapter.registry === 'object');
  assert.equal(typeof adapter.install, 'function');
  assert.equal(typeof adapter.uninstall, 'function');
});

test('opencode axes classify as the programmatic-cli reference profile', () => {
  assert.equal(profileOf(OC_AXES), 'programmatic-cli');
});

// -- AC4: dispatch is synchronous — the #2087 "upgrade" is retracted (#2598) --

test('opencode descriptor declares background dispatch false/false (#2598)', () => {
  // #2087 set these true, reading OpenCode v1.15/v1.17 as "background subagents
  // enabled by default in all modes". That reading does not hold against current
  // upstream `dev`, where the capability is opt-in:
  //   experimentalBackgroundSubagents: enabledByExperimental("OPENCODE_EXPERIMENTAL_BACKGROUND_SUBAGENTS")
  // `enabledByExperimental` falls back to the `experimental` flag and `bool()`
  // defaults false, so the Task tool's `background` parameter is hidden from the
  // model unless an operator opts in. Upstream #29638 (OPEN) confirms the session
  // loop still `tasks.pop()`s one subtask at a time.
  assert.equal(OC_AXES.dispatch.background, false,
    'background subagents are behind an opt-in experimental flag, not default-on');
  assert.equal(OC_AXES.dispatch.backgroundDispatch, false,
    'concurrent dispatch cannot be relied on, so it must not be declared');
});

test('synchronous dispatch force-flattens; the retracted axes would not have', () => {
  // Declaring a capability the host lacks is the failure mode #2598 closes:
  // negotiation is built to fail CLOSED, so an unavailable concurrency
  // capability must serialize rather than be trusted.
  assert.equal(shouldFlattenDispatch(OC_AXES.dispatch), true,
    'with background:false, MSD must force-flatten opencode dispatch (fail closed)');
  // #2939: pin the retracted contract so a silent re-flip is caught. Under the depth-aware
  // rule, flipping ONLY the two background booleans is no longer sufficient to background —
  // opencode's axes lack nested:true + subagentToolkit:"full" + a depth budget > 1, so even
  // the #2087 background values still flatten. A future accurate declaration would need to
  // establish the full nesting capability, not just the background booleans.
  const retracted = { ...OC_AXES.dispatch, background: true, backgroundDispatch: true };
  assert.equal(shouldFlattenDispatch(retracted), true,
    '#2939: the #2087 background-only values still flatten — opencode lacks nested + full toolkit + depth budget');
});

test('opencode extension-event surface includes the #2087 additions (permission + session.error)', () => {
  const surface = extensionEventSurfaceFor('opencode');
  assert.ok(surface, 'opencode is a consumed extensionEvents dialect');
  for (const ev of ['permission.asked', 'permission.replied', 'session.error']) {
    assert.ok(surface.includes(ev), `#2087 adds ${ev} to the opencode extension-event surface`);
  }
  // The engine still owns phase sequencing — no workflow-phase events on the bus.
  assert.ok(!surface.some((e) => /plan:|verify:|ship:/.test(e)));
});

// -- AC5: negotiation fails CLOSED on a corrupted descriptor ------------------

test('negotiateHostCapabilities never throws for opencode, even fully corrupted', () => {
  assert.doesNotThrow(() => negotiateHostCapabilities({}));
  assert.doesNotThrow(() => negotiateHostCapabilities({ ...OC_AXES, embeddingMode: UNDOCUMENTED }));
  assert.doesNotThrow(() => negotiateHostCapabilities({ ...OC_AXES, embeddingMode: 'future-unknown' }));
});

test('a partial/empty opencode descriptor degrades to the safe floor, not the programmatic-cli baseline', () => {
  const result = negotiateHostCapabilities({});
  assert.equal(result.effective.embeddingMode, 'declarative', 'omitted embeddingMode degrades closed');
  assert.equal(result.effective.hookBus, 'none');
  assert.notDeepEqual(result.effective, PROFILE_BASELINES['programmatic-cli']);
  assert.ok(result.warnings.length > 0);
});

// -- AC2: the hardcoded branches are retired ---------------------------------

test('opencode descriptor declares runtime.hostBehaviors (the folded-in behaviors)', () => {
  const hb = OC_CAP.runtime.hostBehaviors;
  assert.ok(hb && typeof hb === 'object');
  assert.equal(hb.combinedFamilyInstall, true, 'commands+skills+plugin install runs through the engine (adapter)');
  assert.equal(hb.reapplyCommand, '/msd-update --reapply');
  assert.equal(hb.attributionConfigResolver, 'opencode');
  // #2329: OpenCode discovers commands from the PLURAL `commands/` dir; the
  // singular `command/` made all /msd-* commands invisible to OpenCode.
  assert.equal(hb.flatCommandDir, 'commands');
  assert.equal(hb.frontmatterDialect, 'opencode');
  assert.equal(hb.skipHomePrefixSubstitution, true);
  assert.equal(hb.skipSettingsUi, true);
  assert.equal(hb.skipUpdateBannerCommand, true);
  // #4738: the skills-manifest exclusion is retired — opencode stages 72
  // converted skills and its manifest must record them (the flag was carried
  // verbatim from a pre-skills-layout era and flagged every staged skill as
  // user-added on every update).
  assert.equal(hb.skipCodexSkillsManifest, undefined);
  assert.equal(hb.nativePlugin.file, 'msd-core.js');
  assert.equal(hb.nativePlugin.source, '.opencode/plugins/msd-core.js');
});

test('no `runtime === "opencode"` string-equality branch remains in the install source (AC2)', () => {
  const strip = (src) => src
    .replace(/\/\*[\s\S]*?\*\//g, '')
    .replace(/\/\/[^\r\n]*/g, '')
    .replace(/`[^`]*`/g, '');
  for (const rel of ['bin/install.js', 'src/install-engine.cts', 'src/runtime-artifact-conversion.cts']) {
    const src = fs.readFileSync(path.join(__dirname, '..', rel), 'utf8');
    const offenders = strip(src).match(/runtime\s*[!=]==\s*'opencode'/g) || [];
    assert.deepEqual(offenders, [], `AC2: no hardcoded runtime==='opencode' branch may remain in ${rel}; found: ${offenders.join(', ')}`);
  }
});

// ─── #4738: the opencode manifest must record the skills it stages ───────────

const { cleanup, runMsdTools, createTempDir } = require('./helpers.cjs');
const { writeManifest } = require(path.join(__dirname, '..', 'bin', 'install.js'));
const { runMinimalInstall } = require('./helpers/install-shared.cjs');

describe('#4738: writeManifest records staged skills for opencode', () => {
  let tmpDir;

  beforeEach(() => {
    tmpDir = createTempDir('msd-4738-manifest-');
  });

  afterEach(() => {
    cleanup(tmpDir);
  });

  test('manifest includes skills/msd-xxx/SKILL.md entries for opencode', () => {
    // Stage the structure an opencode install creates: converted skills under
    // skills/msd-*/SKILL.md (convertClaudeCommandToOpencodeSkill) plus the
    // msd-core directory writeManifest always records.
    const skillDir = path.join(tmpDir, 'skills', 'msd-next');
    fs.mkdirSync(skillDir, { recursive: true });
    fs.writeFileSync(path.join(skillDir, 'SKILL.md'), 'skill content');
    const msdDir = path.join(tmpDir, 'msd-core');
    fs.mkdirSync(msdDir, { recursive: true });
    fs.writeFileSync(path.join(msdDir, 'test.md'), 'test');

    writeManifest(tmpDir, 'opencode');

    const manifest = JSON.parse(
      fs.readFileSync(path.join(tmpDir, 'msd-file-manifest.json'), 'utf8'),
    );
    const skillEntries = Object.keys(manifest.files).filter((k) => k.startsWith('skills/'));
    assert.ok(skillEntries.length > 0, 'manifest has skills/ entries for opencode');
    assert.ok(
      skillEntries.includes('skills/msd-next/SKILL.md'),
      'manifest records the staged skills/msd-next/SKILL.md',
    );
  });
});

describe('#4738: a clean opencode install is invisible to detect-custom-files', () => {
  test('real --opencode --global install: manifest records staged skills and the detector reports zero custom files', (t) => {
    const { manifest, configDir, root } = runMinimalInstall({ runtime: 'opencode', scope: 'global' });
    t.after(() => cleanup(root));

    const skillEntries = Object.keys(manifest.files).filter((k) => k.startsWith('skills/'));
    assert.ok(
      skillEntries.length > 0,
      `the manifest must record the staged skills (got ${skillEntries.length} skills/ keys)`,
    );
    // The on-disk side is unchanged by the fix: every manifested skill exists.
    for (const rel of skillEntries) {
      assert.ok(fs.existsSync(path.join(configDir, rel)), `staged file exists: ${rel}`);
    }

    const result = runMsdTools(['detect-custom-files', '--config-dir', configDir], root);
    assert.ok(result.success, `detector failed: ${result.error}`);
    const json = JSON.parse(result.output);
    assert.ok(Array.isArray(json.custom_files), 'the detector must emit a custom_files array');
    assert.deepEqual(
      json.custom_files.filter((f) => f.startsWith('skills/')),
      [],
      `no installer-staged skill may be flagged as user-added: ${JSON.stringify(json.custom_files)}`,
    );
    assert.equal(json.custom_count, 0, `a clean opencode install reports zero custom files: ${JSON.stringify(json.custom_files)}`);
  });
});