* chore(#604): rename get-shit-done/ runtime directory to gsd-core/ Renames the installed runtime directory `get-shit-done/` to `gsd-core/` so the on-disk name matches the package (`@opengsd/gsd-core`), repo, and binary (`gsd-tools`). The npm package name and binary are unchanged; npx/npm consumers are unaffected. Mechanical (bulk, ~90% of the diff): - `git mv get-shit-done gsd-core` - Swept path/identifier references across the repo via `perl -pe 's/get-shit-done(?!-\w)/gsd-core/g'`. The negative lookahead preserves the five legitimate slug variants that are NOT the directory: get-shit-done-{OLD,cc,classic,cli,redux} (old package/repo names). - Build/manifest wiring: package.json (bin, files, coverage globs), tsconfig.build.json (outDir), ~86 .gitignore build-output entries, stryker.config.mjs, scan-ignore files, install.js path strings. - Frozen (not rewritten): CHANGELOG.md history; translated docs (README.<locale>.md and docs/{ja-JP,ko-KR,pt-BR,zh-CN}/). New logic (review here): - src/installer-migrations/003-rename-get-shit-done-to-gsd-core.cts: a proper ADR-0008 installer migration. On upgrade it walks the legacy `~/.claude/get-shit-done/` tree, classifies each file via the prior install manifest, and emits remove-managed / backup-and-remove for managed files while PRESERVING unknown user-added files. Symlink-safe (skips a symlinked root and symlinked entries; bounds-checks every path under configDir). The framework rolls back on install failure. Emptied dirs may remain (framework has no recursive dir-removal primitive) — documented. - scripts/lint-legacy-dir-name.cjs: CI regression guard forbidding the bare `get-shit-done` directory token (split token to avoid self-match; case- insensitive; `(?!-\w)` lookahead allows the slug variants; allowlists CHANGELOG, translated docs, and `gsd-allow-legacy-name` marker lines). Wired into the lint-tests CI job. - Restored scripts/lint-package-identity-drift.cjs detection regexes (the mechanical sweep had wrongly rewritten the old-name patterns it exists to detect) and marked them as intentional legacy references. - TDD tests for the migration and the guard; do.md slash-command guard regex tightened so a `/gsd-core/bin` path segment is not mistaken for a command; changeset + docs/installer-migrations.md row added. Breaking: the installed runtime path moves `~/.claude/get-shit-done/` -> `~/.claude/gsd-core/`. Migration 003 removes the stale legacy dir's managed files (preserving user files) on upgrade. Users with custom hooks/configs hardcoding the old path must update them. Closes #604 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): unsweep pending changesets + allowlist injection-example docs CI fixes for the rename PR: - Do not sweep pending .changeset/*.md (ephemeral release-note fragments, like CHANGELOG); reverted those body edits so 5 pre-existing malformed fragments (missing type/pr) no longer enter the PR diff and trip docs-lint. Allowlisted .changeset/ in the legacy-name guard accordingly. - Allowlisted TEST-EXAMPLES.md and docs/explanation/security-model.md in prompt-injection-scan.sh: they contain intentional injection examples / security-model prose; the path-reference rewrites are kept. CodeQL alerts on this PR are pre-existing (alert lines unchanged by this PR; none in the new migration/guard) and are out of scope for the rename. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): resolve CodeQL alerts surfaced on this PR The rename diff touched files carrying pre-existing CodeQL findings; per the no-pre-existing-dismissal rule, fixing every surfaced alert rather than waving them off. All behavior-preserving: - scripts/ci-test-scope.cjs: build the config-path match from string .includes() instead of a RegExp over an arg-derived value (js/regex-injection). - src/profile-output.cts: escape backslashes before pipe-escaping desc/safeName so the table-cell escape is complete (js/incomplete-sanitization). - tests/{bug-2643,bug-2808,docs-parity-live-registry}: two-pass HTML-comment strip so a bare/unclosed `<!--` cannot survive (js/incomplete-multi-character-sanitization). - tests/inline-plan-threshold: drop the no-op `\s`->`\s` identity replace, keep the meaningful POSIX-class conversion (js/identity-replacement). Verified: build:lib green; the touched test files + ci-test-scope + profile-output suites pass; lint:legacy-name clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): correctly resolve remaining CodeQL alerts (regex-injection + sanitization) The prior commit's fixes for two alerts were ineffective: - ci-test-scope.cjs js/regex-injection: the alert is the CLI-arg-derived `file` reaching static regex `.test(file)` calls (not the config rule). Removed ALL regex over file/t — startsWith/includes/=== string checks + an isWindowsHint helper — so there is no regex sink for the tainted value. - js/incomplete-multi-character-sanitization (3 test files): a single `.replace(/<!--...-->/g,'')` can let `<!--` re-form. Replaced with a fixpoint loop (replace until stable) plus a final bare-opener strip. Verified: no regex over file/t remains; ci-test-scope + the 3 test suites pass; lint:legacy-name clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): make ci-test-scope + comment-strippers regex-free to clear CodeQL CodeQL flags the regex PATTERNS syntactically (regex-injection on the --files arg split; incomplete-multi-character-sanitization on the <!--...--> replace), so loop fixes do not satisfy it. Made these paths regex-free: - ci-test-scope.cjs splitFiles: char-by-char separator tokenizer (no /[,\\s]+/). - 3 test files: indexOf/slice HTML-comment stripper (no .replace(/<!--/)). Behavior preserved; ci-test-scope + the 3 suites pass; guard clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): unblock security base64 scan on the large rename diff The security job hit its 10m timeout: base64-scan.sh choked on the binary test fixture tests/feat-3594-parser-property-style.test.cjs (embedded NUL/ non-UTF8 bytes -> thousands of bogus blobs + "ignored null byte" warnings), and the ~800-file rename diff is slow to scan regardless. - scripts/base64-scan.sh: skip binary-by-content files (grep -Iq .) — they can't carry base64-obfuscated *text* and feeding NUL bytes through the per-line scanner is pathologically slow. collect_files already filtered binary *extensions*; this catches binary *content* in text extensions. - .github/workflows/security-scan.yml: raise the security job timeout 10m->30m to accommodate very large diffs (the scan itself is unchanged). Verified locally: scan skips the fixture, 0 "ignored null byte" warnings, 0 findings, exit 0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): sweep get-shit-done refs introduced by merging next The branch was updated with next (#614/#384/#618 etc.), which reference the get-shit-done/ dir (still named that on next). Swept the stale references in the merged files to gsd-core so the rename stays consistent and lint:legacy-name passes: - commands/gsd/discuss-phase.md (runtime-launcher shim paths) - src/core.cts (getAgentsDir layout comments) - tests/bug-384-agents-runtime-aware.test.cjs (require path to runtime lib) Verified: guard 0 violations; build green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): exclude gsd-core/ path segments from bug-3683 command cross-ref invariant The #614 runtime-launcher shim added to discuss-phase.md references `${_GSD_RUNTIME_ROOT}/gsd-core/bin/...`. bug-3683's REF_PATTERN excluded path-y refs only via lookbehind, but `}` precedes `/gsd-core/` in the shim, so it mis-read the directory path as a dangling `/gsd-core` command ref (same class as the #604 bug-2954 fix). Added a trailing `(?![\w-]*\/)` so `/gsd-<x>/...` path segments are not treated as slash-command references. Verified locally on BOTH platforms before pushing: - mac (node 26) full suite: 0 failures - gsd-test-runner (linux, node22 image) full suite: 0 failures - bug-3683 + bug-2954 pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): lazily resolve findProjectRoot in gsd-tools (harden flaky CI) CI intermittently failed state.test's gsd-tools subprocess with "findProjectRoot is not a function" (flip-flopping across legs; not reproducible on mac full suite, gsd-test linux full suite, test:unit, or state.test x8). findProjectRoot is a re-export from core.cjs (sourced from project-root.cjs); binding it via destructure at module-load can be undefined under a load-ordering edge. Resolve it lazily at call time via a small wrapper so the lookup happens after core.cjs is fully initialized. Verified green on BOTH platforms before pushing: - mac (node 26) full suite: 0 failures - gsd-test-runner (linux, node22) full suite: 0 failures - state.test.cjs: 106/106; gsd-tools loads cleanly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): allowlist verification-patterns.md placeholder examples in secret scan The rename git-mv'd references/verification-patterns.md into gsd-core/, pulling it into the secret-scan diff. It documents stub/placeholder RED-FLAG env-var examples (illustrative Stripe test-key / database-URL / API-key placeholders) — not real credentials. Added it to .secretscanignore with the strict annotation, mirroring the existing gsd-core/workflows/plan-phase.md exception. Verified locally: secret-scan-lint --strict OK; secret-scan --diff origin/next exits 0 with 0 findings. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
200 lines
6.0 KiB
JavaScript
200 lines
6.0 KiB
JavaScript
'use strict';
|
|
|
|
const cp = require('node:child_process');
|
|
const path = require('node:path');
|
|
|
|
const { parseFragment } = require('./parse.cjs');
|
|
const { packageName, repoSlug: defaultRepoSlug } = require('../../gsd-core/bin/lib/package-identity.cjs');
|
|
|
|
const SECTION_ORDER = ['Fixed', 'Added', 'Changed', 'Deprecated', 'Removed', 'Security'];
|
|
|
|
const FIXED_GROUPS = [
|
|
{
|
|
title: 'Verification, update & review safety',
|
|
pattern: /\b(verifier|verification|verify|probe|probes|debt|tbd|fixme|xxx|detect-custom-files|review|summary|blocker|critical)\b/i,
|
|
},
|
|
{
|
|
title: 'State, planning & execution',
|
|
pattern: /\b(state|planning|planner|plan-phase|phase|roadmap|execute|executor|worktree|worktrees|resolve-model|init\.progress|model override|human_needed|ship preflight)\b/i,
|
|
},
|
|
{
|
|
title: 'Install & runtime conversion',
|
|
pattern: /\b(install|installer|runtime|windows|powershell|codex|gemini|antigravity|hook|hooks|gsd-sdk|sdk readiness|cjs|model-catalog|path|shim)\b/i,
|
|
},
|
|
];
|
|
|
|
const REMOVED_GROUPS = [
|
|
{
|
|
title: 'Intel updater',
|
|
pattern: /\b(intel|gsd-intel-updater|layout detection)\b/i,
|
|
},
|
|
];
|
|
|
|
function runGit(repo, args) {
|
|
return cp.execFileSync('git', args, {
|
|
cwd: repo,
|
|
encoding: 'utf8',
|
|
stdio: ['ignore', 'pipe', 'pipe'],
|
|
});
|
|
}
|
|
|
|
function validateGitRef({ repo, ref, label }) {
|
|
if (typeof ref !== 'string' || ref.trim() !== ref || ref.length === 0) {
|
|
throw new Error(`Invalid git ref for ${label}: expected a non-empty trimmed string`);
|
|
}
|
|
if (
|
|
ref.startsWith('-') ||
|
|
ref.includes('..') ||
|
|
ref.includes('//') ||
|
|
!/^[A-Za-z0-9._/-]+$/.test(ref)
|
|
) {
|
|
throw new Error(`Invalid git ref for ${label}: ${ref}`);
|
|
}
|
|
runGit(repo, ['rev-parse', '--verify', `${ref}^{commit}`]);
|
|
return ref;
|
|
}
|
|
|
|
function changedFragmentPaths({ repo, fromRef, toRef }) {
|
|
const from = validateGitRef({ repo, ref: fromRef, label: 'fromRef' });
|
|
const to = validateGitRef({ repo, ref: toRef, label: 'toRef' });
|
|
const out = runGit(repo, ['diff', '--name-only', `${from}..${to}`, '--', '.changeset']);
|
|
return out
|
|
.split(/\r?\n/)
|
|
.filter(Boolean)
|
|
.filter((file) => /^\.changeset\/[^/]+\.md$/.test(file));
|
|
}
|
|
|
|
function readFileAtRef({ repo, ref, file }) {
|
|
return runGit(repo, ['show', `${ref}:${file}`]);
|
|
}
|
|
|
|
function loadFragmentsFromRange({ repo, fromRef, toRef }) {
|
|
const files = changedFragmentPaths({ repo, fromRef, toRef });
|
|
const fragments = [];
|
|
const failures = [];
|
|
|
|
for (const file of files) {
|
|
try {
|
|
const src = readFileAtRef({ repo, ref: toRef, file });
|
|
const parsed = parseFragment(src);
|
|
if (parsed.ok) {
|
|
fragments.push({
|
|
...parsed.fragment,
|
|
file,
|
|
slug: path.basename(file, '.md'),
|
|
});
|
|
} else {
|
|
failures.push({ file, reason: parsed.reason, detail: parsed.detail || null });
|
|
}
|
|
} catch (e) {
|
|
failures.push({ file, reason: 'read_failed', detail: e.message });
|
|
}
|
|
}
|
|
|
|
return { fragments, failures };
|
|
}
|
|
|
|
function classifyGroup(fragment) {
|
|
const haystack = `${fragment.slug || ''}\n${fragment.body || ''}`;
|
|
const groups = fragment.type === 'Removed' ? REMOVED_GROUPS : FIXED_GROUPS;
|
|
const match = groups.find((group) => group.pattern.test(haystack));
|
|
if (match) return match.title;
|
|
if (fragment.type === 'Removed') return 'Removed';
|
|
if (fragment.type === 'Fixed') return 'Other fixes';
|
|
return fragment.type;
|
|
}
|
|
|
|
function buildGithubReleaseNotesIr({ fragments }) {
|
|
const sections = [];
|
|
for (const type of SECTION_ORDER) {
|
|
const typed = fragments.filter((fragment) => fragment.type === type);
|
|
if (typed.length === 0) continue;
|
|
|
|
const groupMap = new Map();
|
|
for (const fragment of typed) {
|
|
const groupTitle = classifyGroup(fragment);
|
|
if (!groupMap.has(groupTitle)) groupMap.set(groupTitle, []);
|
|
groupMap.get(groupTitle).push(fragment);
|
|
}
|
|
|
|
sections.push({
|
|
type,
|
|
groups: Array.from(groupMap, ([title, bullets]) => ({ title, bullets })),
|
|
});
|
|
}
|
|
return { sections };
|
|
}
|
|
|
|
function formatBullet(fragment) {
|
|
if (!Number.isInteger(fragment.pr) || fragment.pr <= 0) {
|
|
throw new Error(`Fragment ${fragment.slug || fragment.file || '<unknown>'} missing valid pr field`);
|
|
}
|
|
const body = `${fragment.body.trim()} (#${fragment.pr})`;
|
|
const lines = body.split(/\r?\n/);
|
|
return lines.map((line, index) => (index === 0 ? `- ${line}` : ` ${line}`)).join('\n');
|
|
}
|
|
|
|
function compareUrl({ repoSlug, fromRef, toRef }) {
|
|
const normalizedSlug = String(repoSlug || '').trim();
|
|
if (!/^[A-Za-z0-9._-]+\/[A-Za-z0-9._-]+$/.test(normalizedSlug)) {
|
|
throw new Error(`Invalid repoSlug format: ${repoSlug} (expected "owner/repo")`);
|
|
}
|
|
return `https://github.com/${normalizedSlug}/compare/${fromRef}...${toRef}`;
|
|
}
|
|
|
|
function serializeGithubReleaseNotes({
|
|
ir,
|
|
fromRef,
|
|
toRef,
|
|
repoSlug = defaultRepoSlug,
|
|
installCommand = `npx ${packageName}@latest`,
|
|
}) {
|
|
if (installCommand.includes('`')) {
|
|
throw new Error('installCommand cannot contain backtick characters');
|
|
}
|
|
const lines = [];
|
|
for (const section of ir.sections) {
|
|
lines.push(`## ${section.type}`);
|
|
lines.push('');
|
|
for (const group of section.groups) {
|
|
lines.push(`### ${group.title}`);
|
|
for (const bullet of group.bullets) {
|
|
lines.push(formatBullet(bullet));
|
|
}
|
|
lines.push('');
|
|
}
|
|
}
|
|
lines.push('---');
|
|
lines.push('');
|
|
lines.push(`Install/upgrade: \`${installCommand}\``);
|
|
lines.push('');
|
|
lines.push(`**Full Changelog**: ${compareUrl({ repoSlug, fromRef, toRef })}`);
|
|
lines.push('');
|
|
return lines.join('\n');
|
|
}
|
|
|
|
function renderGithubReleaseNotes(options) {
|
|
const { fragments, failures } = loadFragmentsFromRange(options);
|
|
if (failures.length > 0) {
|
|
return { ok: false, fragments, failures, body: null };
|
|
}
|
|
const ir = buildGithubReleaseNotesIr({ fragments });
|
|
return {
|
|
ok: true,
|
|
fragments,
|
|
failures: [],
|
|
ir,
|
|
body: serializeGithubReleaseNotes({ ir, ...options }),
|
|
};
|
|
}
|
|
|
|
module.exports = {
|
|
changedFragmentPaths,
|
|
loadFragmentsFromRange,
|
|
buildGithubReleaseNotesIr,
|
|
serializeGithubReleaseNotes,
|
|
renderGithubReleaseNotes,
|
|
classifyGroup,
|
|
validateGitRef,
|
|
};
|