Files
msd-core/docs/adr/2719-emitted-artifact-attribution.md
Tom Boucher 1c1af70a4b refactor(#2724): delete the committed golden fixtures and size baselines (#2767)
* test(#2724): delete golden-install-parity fixtures, test, and generator

Removes the 19 committed path->hash manifests, the two per-file size
baselines, tests/golden-install-parity.test.cjs, and
scripts/gen-golden-install-parity-zcode.cjs. These were pure functions
of the source tree (ADR-2719); the differential attribution check
(tests/emitted-attribution.test.cjs + tests/emitted-provenance.test.cjs)
is now the sole gate for emitted-artifact propagation.

tests/fixtures/install-tree/*.json and tests/golden-install-tree.test.cjs
are unchanged (ADR-2719 section 7 exception).

Follow-up commits fix the resulting bookkeeping: scripts/ci-test-scope.cjs's
existence guard, .gitattributes, package.json scripts, the emitted-provenance
totality guard's IO, the differential check's baseline acquisition, CI
wiring to publish/restore the baseline artifact, and docs.

* refactor(#2724): make the differential attribution check self-sufficient

Three fixes required to delete the golden fixtures without breaking CI:

- scripts/ci-test-scope.cjs: remove tests/golden-install-parity.test.cjs
  from the three rules that named it. #2759's missingRuleTestFiles guard
  hard-throws at module load if a rule names a test file absent from
  disk, which would break the changes job on every PR the moment the
  fixture-deletion commit landed.

- tests/helpers/emitted-provenance.cjs: loadManifests() read the
  committed golden fixture directory. With that directory deleted at
  every future ref, this would throw at module load forever, taking
  the Phase 2 totality guard down with it. Rebuilt from real installer
  spawns (MANIFEST_FAMILIES + runMinimalInstall + buildParityManifest),
  the same shape emitted-runtime.cjs's currentManifests() already uses.

- tests/emitted-attribution.test.cjs / tests/helpers/emitted-runtime.cjs:
  the real-tree test's baseline acquisition swaps from
  baselineManifestsAtRef(base) (git show at a ref that no longer carries
  fixtures) to resolveBaseline()'s documented precedence: env, then the
  on-disk cache, then an in-job build. The build fallback
  (buildBaselineAtRef, new) checks out base into a throwaway git
  worktree and runs the new scripts/gen-emitted-baseline.cjs there --
  no npm ci needed, since bin/install.js and the test helper shells are
  Node-builtins-only. That script also publishes the baseline artifact
  from CI's push-to-next job (wired in a follow-up commit).

* refactor(#2724): retire the merge-driver bridge and per-file size baselines

The Phase 1 bridge (#2721) is retired now that the artifacts it guarded
are deleted: scripts/git-merge-regen-driver.cjs, its test, and the
'setup:merge-driver' npm script are removed, and the .gitattributes
merge=gsd-regen/linguist-generated block for the three deleted-path
globs is dropped. tests/fixtures/install-tree/*.json keeps its normal
merge behavior, unchanged (ADR-2719 section 7).

scripts/update-size-baseline.cjs and its test are removed: their sole
purpose was regenerating tests/workflow-size-baseline.json and
tests/agent-size-baseline.json, both deleted. The 'size:baseline' npm
script and its step in 'regen:derived' go with it. The per-file
baseline describe blocks in tests/workflow-size-budget.test.cjs and
tests/agent-size-budget.test.cjs are removed for the same reason; the
independent loose-tier hard caps are untouched. The differential
attribution check's size ratchet (tests/emitted-diff.cjs, already
shipped in #2723) is the replacement anti-creep mechanism.

'npm run gen:golden' is replaced by 'npm run gen:install-tree', which
keeps regenerating tests/fixtures/install-tree/*.json (the one artifact
family ADR-2719 section 7 keeps committed); tests/golden-install-tree.test.cjs's
error messages point at the new command name.

tests/golden-parity-single-source.test.cjs's anti-divergence guard
(#2266) is retargeted from the two deleted golden-parity consumers to
their two replacements (tests/helpers/emitted-runtime.cjs and
tests/helpers/emitted-provenance.cjs), which import buildParityManifest
the same way — the divergence risk the guard exists for is unchanged.

Also wires CI: a new publish-emitted-baseline job runs
scripts/gen-emitted-baseline.cjs after a push to next and caches the
result keyed on the sha; the test and test-full jobs restore that cache
on pull_request events, keyed on the PR's base sha, and export
GSD_EMITTED_BASELINE for tests/emitted-attribution.test.cjs's real-tree
test to pick up.

* docs(#2724): flip ADR-2719 to Accepted and update contributor docs

Status: Proposed -> Accepted. Regenerated docs/adr/README.md index.

CONTRIBUTING.md, docs/TESTING-SUITES.md, and CONTEXT.md (RULESET.
EMITTED_ATTRIBUTION, RULESET.WORKFLOW_SIZE_BUDGET, RULESET.
AGENT_SIZE_BUDGET, and the Emitted Artifact Provenance glossary entry)
no longer point at the deleted golden-install-parity fixtures, size
baselines, gen:golden, UPDATE_GOLDEN, or the setup:merge-driver /
git-merge-regen-driver.cjs bridge. Editing shipped content now
requires zero manual fixture regeneration, documented against the
differential attribution check instead of the deleted commands.

* docs(#2724): add changeset for removed golden-parity commands

* fix(#2724): drop stale scripts/update-size-baseline.cjs glossary ref

check-glossary-refs.cjs verifies every backtick-wrapped scripts/*.cjs
token in CONTEXT.md resolves to a real file. The RULESET.
EMITTED_ATTRIBUTION rewrite named the deleted script inside backticks,
which the checker reads as a live reference, not historical prose.

* test(#2724): retarget ci-test-scope tests off the deleted golden test

tests/ci-test-scope.test.cjs asserted specific RULES entries select
tests/golden-install-parity.test.cjs, and that every rule selecting it
also selects both emitted gates. Both premises broke when the golden
test was deleted (#2724): the deleted filename never re-appears in
targeted_tests, and there was no longer a third file for the gates to
travel alongside. Retargeted the two selection describe blocks to
assert tests/emitted-provenance.test.cjs directly (the drift guard the
golden gate's rules were retargeted to), and simplified the third block
to assert the two emitted gates always travel together, without
reference to the golden filename.

* docs(#2724): repoint two contributor how-to guides at the differential check

Both guides told contributors to regenerate a baseline against
tests/golden-install-parity.test.cjs, which #2724 deletes. Repointed
at the differential attribution check (tests/emitted-attribution.test.cjs,
ADR-2719), which needs no manual regeneration step.

* fix(#2724): repair phase6-capstone-conformance's deleted-baseline read

An independent orthogonal review caught a real regression this branch
introduced into a test file the branch's diff never touched:
tests/phase6-capstone-conformance.test.cjs read
tests/workflow-size-baseline.json (deleted earlier in this branch) with
no fallback, so the whole suite would throw ENOENT the moment this
branch landed. The test's actual intent — prove the host-loop workflow
files are real, tracked, non-empty docs — is preserved by asserting the
live byte count via the same shared counter (scripts/workflow-size.cjs)
the size guards already use, instead of a committed snapshot.

Also, from the same review: a stale doc comment in
scripts/workflow-size.cjs still named the deleted
scripts/update-size-baseline.cjs as a consumer, and
buildBaselineAtRef's cleanup in tests/helpers/emitted-runtime.cjs left
two fs.rmSync calls unguarded against masking the primary result/error,
inconsistent with the try/catch already wrapping the git cleanup beside
them. Both fixed. A doc comment was added to baselineFamilyNamesAtRef
explaining why it (and its siblings) are kept despite having no
production caller post-cutover — they still answer real questions
about refs that predate the cutover.

* fix(#2724): repair three real regressions found by remote verification

1. tests/emitted-provenance.test.cjs's two hostile-input tests
   (non-object manifest, unreadable fixture) drove loadManifests(tmp)
   and monkeypatched fs.readFileSync, both premised on the deleted
   fixture-directory read this branch already replaced with real
   installer spawns -- the negative assertions silently stopped firing.
   loadManifests() now accepts injected {families, install, build,
   clean} (defaulting to production values), giving the tests a real
   seam to drive a bad build result and a build failure through the
   ACTUAL loader instead of a reimplementation, and added coverage that
   clean() still runs on both paths.

2. .github/workflows/test.yml's two 'Export GSD_EMITTED_BASELINE'
   steps hardcoded shell: bash, which is wrong on windows-latest (native
   pwsh) and on test-full's macos-latest legs (native zsh per that job's
   own matrix) -- the repo's H1 shell policy (tests/policy-shell-pinning
   .test.cjs) caught it. Replaced the inline bash script with
   scripts/ci-export-emitted-baseline-env.cjs, a plain Node script: a
   bare 'node <path>' command line has no shell-specific syntax, so it
   runs correctly under bash, zsh, and pwsh without a shell override.

tests/phase6-capstone-conformance.test.cjs's deleted-baseline read
(caught by the same remote run, at a commit prior to this one) was
already fixed in d0c3b1242 and is not touched here; verified still
passing after these changes.

* fix(#2724): revive ADR-1610's new-file size cap inside the differential

An isolated review caught a real regression: deleting
tests/workflow-size-baseline.json silently dropped NEW_FILE_CAP
(ADR-1610 Decision point 3, the Codex project_doc_max_bytes anchor)
with no successor. tests/helpers/emitted-diff.cjs's size ratchet
already 'continue's past any file absent from sizeBaseline -- exactly
the files this cap exists to bound -- so a brand-new workflow file
sized 32,769-40,960 bytes passed CI clean and shipped, then risked
silent truncation at the Codex anchor at runtime. ADR-1610 is Accepted
and never referenced anywhere in this branch.

Fix: NEW_FILE_CAP=32768 revived inside emitted-diff.cjs's own
size-ratchet loop, keyed off the SAME hasOwnProperty(sizeBaseline,
name) signal the growth check already computes -- 'new' is exactly
'present in sizeCurrent, absent from sizeBaseline'. Not ack-able,
matching the tier hard caps it sits beside: the fix is extraction, not
an acknowledgment entry. Documented, disclosed narrowing: the pure
differential module cannot see XL_WORKFLOWS/LARGE_WORKFLOWS tiering
(tests/workflow-size-budget.test.cjs's classification), so a
legitimately large new file must extract rather than tier in, one
release earlier than an existing file would need to. ADR-1610 itself is
left unamended -- this restores its decision rather than re-litigating
it.

Also fixes a stale comment plus a redundant real 19-installer-spawn
assertion left over from the pre-injection-seam version of
tests/emitted-provenance.test.cjs's build-failure test, and annotates
3 of 4 stale golden-fixture citations in
docs/reference/host-integration-capability-matrix.md as superseded
(the 4th is an accurate historical PR narrative, left alone).

* fix(#2724): repair three red CI defects on the golden-fixture cutover

Windows-only provenance false attribution (defect A): the `hooks-built`
provenance rule attributed `hooks/<name>.cmd` to itself. Those shims are
Windows-only installer output (ensureCodexHooksJsonSessionStart /
ensureCodexHooksJsonEvent, both in src/runtime-hooks-surface.cts) wrapping
the same-named `.js` hook — no `.cmd` file is ever tracked in the repo, so
the self-attribution resolved to a path that exists on no platform. Only
windows-latest ever emits the key, so this only failed there. Fixed by
special-casing `.cmd` inside the SAME `hooks-built` rule (not a dedicated
rule) — a dedicated rule would match zero paths, and therefore report as a
dead rule, on every non-Windows lane of the same totality guard. `sources`
already supported per-match functions; `transforms` is extended to support
the same shape so the attribution can vary by match within one rule.

Baseline bootstrap was structurally impossible (defect B): `buildBaselineAtRef`
ran `scripts/gen-emitted-baseline.cjs` from INSIDE the base-ref worktree, but
that script is new in this PR and therefore absent at any base ref that
predates it — every call failed closed with "Cannot find module". Fixed by
running the PR checkout's own generator against the worktree via a new `--dir`
parameter, decoupling "which copy of the script runs" from "which tree it
measures" (`currentManifests`/`currentSizes` gained a `repoRoot` override,
threaded down to `runMinimalInstall`'s new `installScript` override). This is
not just a bootstrap fix: a differential needs ONE measurement schema applied
to both sides, or the two stop being comparable the moment that schema
evolves — running each side's own copy would silently reintroduce that risk.
Verified locally end-to-end against real origin/next: resolves a valid
{version, sha, manifests, sizes} artifact with the correct sha and no leaked
worktree.

Changeset placeholder (defect C): `pr: 0` -> `pr: 2767`, which is what let
docs-lint evaluate the fragment for the first time; it already passes
(docs/TESTING-SUITES.md and friends already document the removed scripts).

Also fixed while in this file: an eslint no-unused-vars warning surfaced by
the changed lint run (unused `cleanup` import in
tests/emitted-provenance.test.cjs).

Added regression coverage for both A and B: a cross-platform spot-check that
drives the real hooks-built rule against `.cmd` keys directly (not through a
real Windows install), and a real-tree test that drives buildBaselineAtRef
against a base ref verified (via git cat-file) to lack the generator, both
skipping honestly rather than false-passing when their precondition does not
hold.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W5kQs6ZufZDySC6zDJfYP6

* fix(#2724): repair false .cmd byte-provenance and a permanently-skipping regression test

Two isolated-review findings on PR #2767:

- `hooks-built`'s `.cmd` branch attributed the Windows shim's bytes to the
  wrapped `hooks/<name>.js` script, asserting a byte-provenance link that
  does not exist — traced against buildCodexHookWindowsShimIR
  (src/runtime-hooks-surface.cts), only the script's NAME (a literal in that
  same file) flows into the .cmd bytes, never its content. Point `sources`
  at HOOKS_WINDOWS_SHIM_SRC instead, matching the code-derived convention
  used elsewhere in the table. Since `sources` is checked before
  `transforms` in the differential, the wrong mapping silently excused any
  .cmd byte movement caused by editing the wrapped .js file.

- The `buildBaselineAtRef` regression test skipped unless a resolvable base
  ref still lacked scripts/gen-emitted-baseline.cjs — true only until this
  PR merges, after which every base ref carries the file and the test skips
  forever with zero ongoing coverage. Rebuilt hermetically: synthesize the
  missing-generator condition in-place via git plumbing (a throwaway commit,
  child of HEAD, with just that one file removed from a scratch index),
  never touching the real working tree, HEAD, or index, and never depending
  on ambient history or remotes.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W5kQs6ZufZDySC6zDJfYP6

* fix(#2724): tolerate the remote runner's dubious-ownership git mount in the emitted baseline path

The runner container mounts the repo at a path owned by a different uid than
the process running the suite, so git's dubious-ownership protection refuses
every git operation there. GitHub Actions never hits this because
actions/checkout registers the workspace as safe automatically; this
runner's container does not.

buildBaselineAtRef is the production build-fallback the sole remaining
emitted gate depends on (resolveBaseline's in-job-build leg), not just a
test helper, so the fix is in the shared git() wrapper (emitted-runtime.cjs)
that every caller — resolveChangedPaths, resolveBase, buildBaselineAtRef's
worktree add/remove/prune, and the hermetic regression test added in the
prior commit — funnels through, plus gen-emitted-baseline.cjs's own
rev-parse (now reusing that same wrapper instead of a second execFileSync,
so the fix has one source of truth). Each call declares -c
safe.directory=<the exact directory it already operates on>, never the *
wildcard.

Audited every other helper on this surface (emitted-diff.cjs,
emitted-baseline.cjs, install-shared.cjs) for the same gap: none of them
shell out to git at all.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W5kQs6ZufZDySC6zDJfYP6

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-07-28 15:41:43 -04:00

14 KiB
Raw Blame History

ADR-2719: Emitted-artifact attribution — replace the committed parity fixtures with a computed conservation law

  • Status: Accepted
  • Date: 2026-07-27
  • Issue: #2719 (epic); Phase 0 tracked by #2720
  • Supersedes: ADR-2264 (Redesign golden-install-parity) — replaces its Decision §2–§4 and its 2026-07-14 Amendment. ADR-2264 Phase 1 is retained and depended upon: the single-source buildParityManifest and the four exclusion constants in tests/helpers/install-shared.cjs are the foundation this design builds on, not something being reverted.
  • Relationship to prior work: Evolves the ADR-1239 Phase-B installer byte-parity harness. Related: ADR-3660 / ADR-1508 (Runtime Artifact Layout / Conversion / Install Plan), #2086, #2100, #2117, #2266, #2267, #2268.

Context

Three families of committed artifacts are pure functions of the source tree: tests/fixtures/golden-install-parity/*.json (19 path→hash manifests), tests/workflow-size-baseline.json, and tests/agent-size-baseline.json. Every edit to shipped content requires regenerating them by hand.

Measured against origin/next @ 1c93df04 with git merge-tree:

  • 7 of 7 conflicting open PRs collide on the identical 20-file set.
  • 140 of 143 conflicted-file instances across those PRs are these artifacts. Three other conflicts exist in total.
  • 16 of 32 open PRs touch these paths at all.

The conflicts split into two mechanisms, and neither is what a reviewer would guess.

Adjacency (3 of 7). #2662, #2531 and #2301 change manifest keys entirely disjoint from what next changed — zero overlap. They conflict only because the map is sorted and unrelated keys fall inside git's three-line diff context. The union of the two edits is the correct merge. These are false conflicts.

Same key (4 of 7). Both sides re-hashed the same emitted file. Git offers ours or theirs; both are wrong, because the correct value is neither — it is recomputed from the merged tree. Git's merge interface cannot express the resolution this artifact always needs.

Amplification makes it worse: content under gsd-core/workflows/, references/, templates/ and contexts/ is copied to every host, so one source edit rewrites the same hash in all 19 manifests. The conflict surface is 19× the change. 281 of claude's 440 emitted paths (64%) are plain identity copies.

Why the current design cannot be patched into shape

The premise that this is an absolute invariant does not survive inspection. When a contributor changes emitted bytes they run npm run gen:golden, and the anchor is overwritten. Every PR re-blesses the snapshot. What makes it feel absolute is manual friction, not a fixed reference point — the golden is already a relative check wearing an absolute costume.

Its stated purpose is detecting a change that propagated further than the author intended. That detection path currently runs entirely through a human noticing an anomaly in 7,500 lines of hex:

  • The fixtures carry no linguist-generated marker, so GitHub renders them expanded.
  • .github/CODEOWNERS:1-2 is advisory — required_approving_review_count: 0.
  • .github/PULL_REQUEST_TEMPLATE.md never mentions fixtures, baselines, or regeneration.
  • CONTEXT.md has no entry for this artifact family under any name, so a contributor who sees "conflicts" has nothing to look up.
  • No single command regenerates it. npm run build covers five of eleven generators; gen:golden, size:baseline, gen-inventory-manifest, gen:registry, gen-adr-index and gen-capability-matrix each need separate invocation.

ADR-2264 diagnosed the churn correctly and shipped Phase 1 cleanly. Its Amendment then fixed silent staleness and correctly rejected the copy/transform split on measurement — but it walked back the churn fix without replacing it. That ADR's own 2026-07-17 audit records AC1, "editing the content of a verbatim/path-injected copied shipped file requires zero manual fixture regeneration," as literally unmet. This ADR satisfies AC1 rather than rewording it away.

Decision

Stop committing the derived state. Replace it with a conservation law, checked on every PR.

1. The invariant is relative, and stated as attribution

Build the parity manifest at next HEAD and at PR HEAD. Every emitted path whose hash moved must be attributable — through a declarative provenance table — to a path the pull request actually changed. Unattributable deltas are a hard failure that names them:

39 emitted paths changed that nothing in this diff explains:
  gsd-core/workflows/execute-phase.md
  agents/gsd-planner.md
  ...

This is strictly stronger than the current mechanism for the failure it exists to catch. "You touched one thing and it rippled" stops being an anomaly a reviewer must notice and becomes a computed statement.

This is not the §3 property test ADR-2264's Amendment rejected. That design asserted emitted == transform(source) by calling the installer's own transform, which is tautological. This design never re-derives a byte; it constrains which keys are permitted to move.

2. Provenance comes from a declarative table with a totality guard

The mapping surface is small and stable. Per host, 13 families; of those, roughly nine are identity or prefix rewrites, one is a stem rewrite (skills/ ← commands/gsd/*.md), and four are synthesized files with no repo source (.gsd-profile, package.json, VERSION, .gsd-runtime) that get their own exempt category. Roughly 15–20 rules total, changing only when a new shipped family or host appears.

Totality is enforced. Any emitted path matching no rule is a hard failure, not a skipped entry. A hand-maintained table's characteristic risk is becoming a silent gap; totality converts that into a loud one. If the installer starts emitting something new, the build fails rather than passing it through unattributed.

Extending the Runtime Artifact Install Plan module to emit file-level provenance is the architecturally correct long-term home and is deliberately not a prerequisite. PlanItem is { kind, sourceDir, destDir } — directory-granular, covering only commands, agents, skills and kimi-agents, so the 281 bulk copies bypass it entirely. Making it a prerequisite turns one epic into two. It remains available later as a refactor with behavior already pinned.

3. The escape hatch is a committed acknowledgment, not a flag

Legitimate unattributable deltas exist: change a converter and emitted bytes move for files whose sources nobody touched. That is ADR-2264's "~5% git cannot review," and it must have a way through.

The way through is tests/emitted-drift-ack.json, which names the affected paths and states why. It is deliberately not an environment variable or a CLI flag — a contributor facing a red gate sets a flag, which is what UPDATE_GOLDEN=1 is today.

The design property that matters: the acknowledgment file appears in the changed-files list only when something rippled unexpectedly. Today 100% of emitted-byte changes touch fixtures, so touching them signals nothing. Under this design, touching the acknowledgment is the alarm.

This does not make a bad change impossible. It converts a silent regeneration into a conspicuous declaration. That is the intended strength, stated plainly rather than overclaimed.

4. The size ratchet folds into the same machine

workflow-size-baseline.json conflicts on 7 of 7 — deleting only the golden fixtures would leave every affected PR still blocked. The attribution law does not transfer to it (growth is trivially attributable to the edit that caused it), so instead the same differential machine reports growth with exact byte deltas, and growth requires the same acknowledgment entry.

The committed number was only ever a means to "growth must be noticed and justified." That function survives, stated more legibly — verify-work.md grew 1,247 bytes beats a number changing inside a 93-line map — while pinning nothing and conflicting never.

Bucketing the sizes was rejected: rounding to the nearest 2KB lets a PR add 1.9KB invisibly, and invisible growth is exactly what the ratchet defends against.

5. The baseline is cached, not committed

The push-to-next run publishes the manifest and size maps; the PR lane restores them from cache, keyed on the next sha the PR was merged with. That key discipline is load-bearing — a stale baseline mis-attributes silently. Cache miss falls back to an in-job build at origin/next.

Bot-committing the baseline to next post-merge was considered and rejected. It is close to ADR-2264 Phase 3 (#2268), and notably that ADR's objection does not apply here: the Amendment deferred CI-owned regen because it "needs a write-token workflow running on PR code (an injection surface)," whereas committing post-merge runs already-reviewed code. It was rejected on a different cost — next carries strict: true, so a bot commit after every emitted-byte-changing merge doubles the rate next advances and taxes all ~30 open PRs. Its one unique benefit is an absolute anchor, which §1 establishes is not required.

6. It is a test, not a CI job

The check is a node:test file in the unit suite. Required tests already gates next, so it is enforced the day it lands; a separate job would need an eighth required context, and adding one under strict: true invalidates the status of every open PR at once — a self-inflicted instance of the problem being solved.

A baseline-unavailable path must never be a bare return. In node:test that is a pass, and it would make the gate fail open with nothing in CI to say so.

7. install-tree stays committed

tests/fixtures/install-tree/*.json conflicts on 0 of 7. The file set genuinely changes rarely, its diffs are readable, and keeping it preserves "the installer stopped shipping X" as a hard, absolute failure with no attribution reasoning involved. It is the one artifact in this family already behaving correctly.

Phases

  • Phase 0 — this ADR (#2720, docs-only).
  • Phase 1 — interim relief (#2721). merge=gsd-regen driver, npm run regen:derived, and naming: RULESET.EMITTED_ATTRIBUTION= under ## Test rules and lint plus ### Emitted Artifact Provenance in the glossary. Touches no fixtures, so it breaks none of the 16 exposed PRs.
  • Phase 2 — provenance table + totality guard (#2722).
  • Phase 3 — differential check, dual-run (#2723). Runs beside golden-install-parity.test.cjs, both green, fixtures untouched.
  • Phase 4 — cutover (#2724). Delete the fixtures, generators and bridge driver; flip this ADR to Accepted.

Acceptance criteria (must-haves)

  1. Editing the content of a copied shipped file (for example a gsd-core/workflows/*.md) requires zero manual fixture regeneration and the parity gate still passes. (This is ADR-2264 AC1, satisfied rather than reworded.)
  2. A simulated ripple — edit one source file, corrupt an unrelated emitted file — fails with the unattributable paths named.
  3. A simulated converter change fails without an acknowledgment entry and passes with one.
  4. Every emitted path across all 19 runtime manifests matches exactly one provenance rule; removing a rule fails the totality guard naming the unmatched paths.
  5. A stale cache key is detected rather than silently used as the baseline.
  6. Growth in a workflow or agent file is reported with its exact byte delta and requires an acknowledgment entry.
  7. After Phase 4, no committed path→hash manifest or per-file size baseline remains, and the two checks agreed throughout the Phase 3 dual-run window.

Consequences

  • Positive. The conflict class ends rather than being automated around: 140 of 143 conflicted-file instances disappear. The propagation catch becomes a computed statement instead of a reviewer noticing an anomaly in hex. ~520 KB of committed derived state is deleted, along with the duplicate generator, UPDATE_GOLDEN, and npm run gen:golden. The artifact family finally has a name in CONTEXT.md.
  • Negative — one-time migration. Deleting the fixtures converts existing conflicts into delete/modify conflicts on the same 20 files, affecting 16 PRs. Verified by simulating the deletion with git commit-tree and re-running git merge-tree. The resolution is one identical command per PR and it is terminal; today's is regenerate-rebase-repush, recurring on every merge to next.
  • Negative — new residual risks, accepted. A provenance rule can map to the wrong source and still pass the totality guard: false attribution, not a false alarm. The Phase 3 dual-run window exists to surface exactly this, and spot-check tests on known pairs reduce it further. Separately, the relative chain holds only while the check runs on every merging PR — that is CI configuration rather than design, and if the selection rules narrow later it breaks silently.
  • Neutral. During Phase 1–3, github.com still reports CONFLICTING. Merge drivers live in .git/config, so forks lack them and GitHub's own merge never runs them. The driver removes the labour, not the label, and is retired in Phase 4.

References

  • tests/helpers/install-shared.cjs — buildParityManifest and the exclusion constants (ADR-2264 Phase 1, retained)
  • tests/golden-install-parity.test.cjs, scripts/gen-golden-install-parity-zcode.cjs — removed in Phase 4
  • src/runtime-artifact-install-plan.cts — createRuntimeArtifactInstallPlan; the long-term provenance home
  • scripts/ci-test-scope.cjs:148-178 — the anti-staleness selection rule from ADR-2264 Phase 2
  • scripts/ci-rebase-check.cjs:108 — merges base into HEAD before tests, which is why the baseline is next HEAD rather than the merge-base
  • scripts/lib/allowlist-ratchet.cjs:157-230 — assertFileBaseline, the size ratchet being replaced
  • ADR-1239 (Phase-B safety net), ADR-2264 (superseded by this ADR), ADR-3660 / ADR-1508 (Runtime Artifact family)