ba231ecbfc
Pay down pre-existing error→warn lint debt. Removes dead imports/vars, unused functions, redundant regex/string escapes, and stale eslint-disable directives; converts unused `catch (_e)` to optional catch binding (src/*.cts). No behavior change. Lint 345→125 warnings (0 errors); deferred categories (n/no-process-exit, test-sleeps, control-regex) tracked in #732 for follow-up. Full test suite green (0 failures); code-review verified all removals unused and all escape fixes semantics-preserving. Closes #732 Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
64 lines
3.2 KiB
JavaScript
64 lines
3.2 KiB
JavaScript
// allow-test-rule: source-text-is-the-product
|
|
// Workflow .md / agent .md / command .md / reference .md files — their text
|
|
// IS what the runtime loads. Testing text content tests the deployed contract.
|
|
// Per CONTRIBUTING.md exception matrix.
|
|
|
|
const { test, describe } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
|
|
// #2790: analyze-dependencies.md was deleted (dead skill). The workflow still
|
|
// exists for direct invocation and is tested below.
|
|
describe('analyze-dependencies command', () => {
|
|
test('analyze-dependencies command file was consolidated away (deleted in #2790)', () => {
|
|
// The standalone /gsd-analyze-dependencies command was removed as a dead skill in #2790.
|
|
// The underlying workflow (workflows/analyze-dependencies.md) remains functional.
|
|
const deleted = path.join(__dirname, '..', 'commands', 'gsd', 'analyze-dependencies.md');
|
|
assert.ok(!fs.existsSync(deleted), 'analyze-dependencies.md should have been deleted in #2790');
|
|
});
|
|
|
|
// Legacy placeholder: was previously a separate test; now just passes trivially.
|
|
test('workflow file is sufficient without a standalone command file', () => {
|
|
const p = path.join(__dirname, '..', 'gsd-core', 'workflows', 'analyze-dependencies.md');
|
|
assert.ok(fs.existsSync(p), 'workflows/analyze-dependencies.md should still exist');
|
|
});
|
|
|
|
test('workflow file exists', () => {
|
|
const p = path.join(__dirname, '..', 'gsd-core', 'workflows', 'analyze-dependencies.md');
|
|
assert.ok(fs.existsSync(p), 'workflows/analyze-dependencies.md should exist');
|
|
});
|
|
|
|
test('workflow describes dependency analysis approach', () => {
|
|
const p = path.join(__dirname, '..', 'gsd-core', 'workflows', 'analyze-dependencies.md');
|
|
const content = fs.readFileSync(p, 'utf-8');
|
|
assert.ok(content.includes('ROADMAP') || content.includes('phase'),
|
|
'workflow should reference ROADMAP.md/phases');
|
|
assert.ok(
|
|
content.includes('depends') || content.includes('Depends') || content.includes('dependency'),
|
|
'workflow should reference dependency detection'
|
|
);
|
|
});
|
|
|
|
test('workflow mentions file overlap detection', () => {
|
|
const p = path.join(__dirname, '..', 'gsd-core', 'workflows', 'analyze-dependencies.md');
|
|
const content = fs.readFileSync(p, 'utf-8');
|
|
assert.ok(
|
|
content.includes('file') && (content.includes('overlap') || content.includes('conflict')),
|
|
'workflow should mention file overlap/conflict detection'
|
|
);
|
|
});
|
|
|
|
test('docs/COMMANDS.md does not document the consolidated-away /gsd-analyze-dependencies entry', () => {
|
|
// #2790 deleted the standalone command file. COMMANDS.md must no longer advertise it.
|
|
// The underlying capability lives in workflows/analyze-dependencies.md and is invoked
|
|
// from consolidated entry points (see gsd-phase / gsd-progress workflow chains).
|
|
const p = path.join(__dirname, '..', 'docs', 'COMMANDS.md');
|
|
if (!fs.existsSync(p)) return;
|
|
const content = fs.readFileSync(p, 'utf-8');
|
|
// Look only for the section header form so we tolerate workflow-internal references.
|
|
assert.ok(!/^### `\/gsd-analyze-dependencies`/m.test(content),
|
|
'COMMANDS.md should not document the removed /gsd-analyze-dependencies command');
|
|
});
|
|
});
|