Files
msd-core/get-shit-done/workflows/remove-workspace.md
Tom Boucher 85c67b4b21 chore: invalidate bug-2543 outdated namespace invariant + document /gsd-<cmd> migration in CONTEXT.md (#164)
* test(meta): invalidate bug-2543 outdated /gsd:<cmd> namespace invariant

The "no /gsd-<cmd> hyphen form in source files" scan (test 2 of the
describe block) is skipped via test.skip. Motivation:

- Bug-3584 (2026-05-15) introduced runtime-slash.cjs, which intentionally
  emits `/gsd-${token}` for skills-based runtimes. This is the correct
  canonical form for runtime-persisted strings (ROADMAP.md, STATE.md,
  recommended_actions, fix hints).
- Bug-2543 was last updated 2026-05-12, three days BEFORE bug-3584 landed.
  The "no hyphen form" invariant was never updated to reflect the new
  two-tier model.
- PR #154 first-pass: an agent misread bug-2543 and reverted the correct
  `/gsd-plan-phase` to `/gsd:plan-phase` in phase-lifecycle-policy.ts:156,
  breaking tests/bug-3584-runtime-slash-emitters.test.cjs. A 2nd-pass agent
  reverted.

The canonical active invariant for runtime-emitter context is:
  tests/bug-3584-runtime-slash-emitters.test.cjs

The remaining 4 tests in this file (commands/gsd/ existence, command
filename slug format, transformer behavior, non-command identifier safety)
are still valid and remain active — only test 2 is skipped. This avoids
vacuous-truth (a full describe-block skip would let all assertions pass
trivially).

See CONTEXT.md § "Slash-command form: /gsd-<cmd> vs /gsd:<cmd>" (added
in the companion commit) for the full two-tier model documentation.

User directive: 2026-05-23 session authorizing this invalidation.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* docs(context): document /gsd-<cmd> slash-command migration for AI agents

Adds CONTEXT.md § "Slash-command form: /gsd-<cmd> (current) vs /gsd:<cmd>
(legacy)" to give future agents an unambiguous reference for which form
to use in which context.

Covers:
- The two-tier model (source text → colon; runtime-emitted strings → hyphen)
- The runtime-emitter authority: get-shit-done/bin/lib/runtime-slash.cjs
- The canonical invariant test: bug-3584-runtime-slash-emitters.test.cjs
- The PR #154 incident: how an agent misread bug-2543 and applied the wrong form
- An explicit "Context for AI agents" block: stop and re-read if bug-2543 is
  influencing a patch
- A note that DEFECT.AGENT-RETIRED-SLASH-SYNTAX-DRIFT.* predicates (written
  pre-two-tier) are stale for runtime-emitter contexts

Also updates the stale DEFECT predicates at the end of CONTEXT.md with a
clarifying note (the predicates remain for historical reference; the new §
supersedes their fix-forward guidance for runtime-emitter contexts).

Motivation: PR #154 first-pass incident (2026-05-23 session).
Canonical runtime contract: tests/bug-3584-runtime-slash-emitters.test.cjs.
Companion: test(meta) commit invalidating bug-2543's scan.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* test(meta): re-activate bug-2543 scan as scoped invariant, exclude runtime-emitter contexts

Codex adversarial review of PR #164 [high finding]: the single content-scanning
test in bug-2543 was test.skip, leaving a vacuous test surface. The transformer/
filename unit tests remained active but no live source surface was guarded.

Fix: replace test.skip with an active scoped invariant.

Scope change:
- REMOVED get-shit-done/bin/lib/ from SEARCH_DIRS entirely. That directory is
  runtime-emitter territory (runtime-slash.cjs, *.generated.cjs,
  phase-lifecycle-policy.ts) and intentionally uses /gsd-<cmd> (hyphen) per
  bug-3584's contract. Scanning it causes false positives that led to PR #154
  first-pass incident.
- Added RUNTIME_EMITTER_EXCLUDES set documenting exactly why each file is exempt.
- Remaining SEARCH_DIRS (workflows/, references/, templates/, commands/gsd/,
  agents/, hooks/) are Claude-facing source — colon form is correct there.

Verified: 9/9 tests pass, 0 skipped.
Canonical runtime-emitter contract: tests/bug-3584-runtime-slash-emitters.test.cjs
bug-2543's scoped scope: excludes bin/lib/ (runtime-emitter contexts).

* docs(context): rewrite slash-command section as directory-level matrix

Codex adversarial review of PR #164 [high finding]: the previous CONTEXT.md
section was internally contradictory — line 616 claimed /gsd-<cmd> was globally
canonical while lines 634/640 correctly stated Claude-facing source text uses
/gsd:<cmd>. Same document; opposite claims.

Root cause: the first push of this section (2026-05-23) overstated the hyphen
form as universal, when the project has always had a two-tier model.

Fix: replace the section with an unambiguous directory-level matrix.

New structure:
- Single table mapping each directory/surface to its correct form and enforcement.
- "How to choose" decision tree (4 steps, replaces ambiguous prose).
- "What was WRONG previously" retains historical motivation and adds the
  PR #164 contradiction incident to the record.
- "Context for AI agents" updated: ban mass-rewrites based on single test failure,
  cite the two-tier model explicitly.

Two-tier model (unchanged from reality, now clearly documented):
- Claude-facing source (commands/, agents/, workflows/, etc.): /gsd:<cmd> colon.
- Runtime-emitter contexts (runtime-slash.cjs, *.generated.cjs, ROADMAP.md
  persistence): /gsd-<cmd> hyphen per bug-3584 invariant.

Canonical authorities: bug-2543 (colon contract), bug-3584 (hyphen contract).

* fix(workflows): replace dead /gsd-* tokens with live registry forms

Codex adversarial review of PR #164 [medium finding]: stale slash-command
references in user-facing workflow content. Registry-backed sweep confirmed
the following tokens are not in commands/gsd/ registry.

Tokens removed/updated (dead token → live registry form):

1. /gsd-remove-workspace → /gsd:workspace --remove <name>
   File: get-shit-done/workflows/list-workspaces.md:58
   Reason: no commands/gsd/remove-workspace.md; remove-workspace is a subcommand
   of /gsd:workspace (commands/gsd/workspace.md, --remove flag).

2. /gsd-list-workspaces → /gsd:workspace --list
   File: get-shit-done/workflows/remove-workspace.md:35
   Reason: no commands/gsd/list-workspaces.md; list-workspaces is a subcommand
   of /gsd:workspace (commands/gsd/workspace.md, --list flag).

3. /gsd-list-phase-assumptions <phase> → /gsd:discuss-phase <phase> --assumptions
   File: get-shit-done/workflows/list-phase-assumptions.md:17-18 (usage block)
   Reason: no commands/gsd/list-phase-assumptions.md; the workflow is invoked
   via commands/gsd/discuss-phase.md with --assumptions flag.

4. /gsd-list-phase-assumptions 2 → /gsd:discuss-phase 2 --assumptions
   File: get-shit-done/references/continuation-format.md:59
   Reason: same as #3.

Sweep scope: user-facing markdown only (workflows/, references/). Runtime-emitter
hyphen-form references in bin/lib/ are guarded by bug-3584 and were not touched.

* chore(164): add changeset fragment for adversarial-review fixes

The 3 commits addressing Codex review touched user-facing surfaces
(get-shit-done/workflows/, get-shit-done/references/, CONTEXT.md,
bug-2543 test). Add fragment to satisfy changeset-lint.

Refs #164

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-23 18:42:47 -04:00

3.4 KiB

Remove a GSD workspace, cleaning up git worktrees and deleting the workspace directory.

<required_reading> Read all files referenced by the invoking prompt's execution_context before starting. </required_reading>

1. Setup

Extract workspace name from $ARGUMENTS.

# SDK resolution: prefer local gsd-tools.cjs, fall back to global gsd-sdk (#3668)
GSD_TOOLS="${RUNTIME_DIR:-$(git rev-parse --show-toplevel 2>/dev/null || pwd)}/get-shit-done/bin/gsd-tools.cjs"
if [ -f "$GSD_TOOLS" ]; then
  GSD_SDK="node $GSD_TOOLS"
elif command -v gsd-sdk >/dev/null 2>&1; then
  GSD_SDK="gsd-sdk"
else
  echo "ERROR: gsd-sdk not found on PATH and $GSD_TOOLS does not exist." >&2
  echo "Run: npx get-shit-done-cc@latest --claude --local" >&2
  exit 1
fi
INIT=$($GSD_SDK query init.remove-workspace "$WORKSPACE_NAME")
if [[ "$INIT" == @file:* ]]; then INIT=$(cat "${INIT#@file:}"); fi

Parse JSON for: workspace_name, workspace_path, has_manifest, strategy, repos, repo_count, dirty_repos, has_dirty_repos.

If no workspace name provided:

First run /gsd:workspace --list to show available workspaces, then ask:

Text mode (workflow.text_mode: true in config or --text flag): Set TEXT_MODE=true if --text is present in $ARGUMENTS OR text_mode from init JSON is true. When TEXT_MODE is active, replace every AskUserQuestion call with a plain-text numbered list and ask the user to type their choice number. This is required for non-Claude runtimes (OpenAI Codex, Gemini CLI, etc.) where AskUserQuestion is not available. Use AskUserQuestion:

  • header: "Remove Workspace"
  • question: "Which workspace do you want to remove?"
  • requireAnswer: true

Re-run init with the provided name.

2. Safety Checks

If has_dirty_repos is true:

Cannot remove workspace "$WORKSPACE_NAME" — the following repos have uncommitted changes:

  - repo1
  - repo2

Commit or stash changes in these repos before removing the workspace:
  cd "$WORKSPACE_PATH/repo1"
  git stash   # or git commit

Exit. Do NOT proceed.

3. Confirm Removal

Use AskUserQuestion:

  • header: "Confirm Removal"
  • question: "Remove workspace '$WORKSPACE_NAME' at $WORKSPACE_PATH? This will delete all files in the workspace directory. Type the workspace name to confirm:"
  • requireAnswer: true

If answer does not match $WORKSPACE_NAME: Exit with "Removal cancelled."

4. Clean Up Worktrees

If strategy is worktree:

Initialize the failure flag once before iterating repos:

REMOVE_FAILED=false

For each repo in the workspace:

cd "$SOURCE_REPO_PATH"
if ! git worktree remove "$WORKSPACE_PATH/$REPO_NAME" 2>&1; then
  echo "Warning: Could not remove worktree for $REPO_NAME — source repo may have been moved, deleted, locked, or dirty." >&2
  REMOVE_FAILED=true
fi

If any git worktree remove fails, stop before deleting the workspace directory:

Refusing to delete "$WORKSPACE_PATH" because one or more git worktrees could not be removed.
Resolve the failed worktree removal manually, then rerun remove-workspace.

5. Delete Workspace Directory

if [ "${REMOVE_FAILED:-false}" = "true" ]; then
  echo "Refusing to delete \"$WORKSPACE_PATH\" because one or more git worktrees could not be removed." >&2
  exit 1
fi

rm -rf "$WORKSPACE_PATH"

6. Report

Workspace "$WORKSPACE_NAME" removed.

  Path: $WORKSPACE_PATH (deleted)
  Repos: $REPO_COUNT worktrees cleaned up