Files
msd-core/tests/review-default-reviewers-resolution.test.cjs
Jakub Zych a9a7a328e6 refactor: hard-fork GSD -> MSD (Make Software Done)
Mechanical rename produced by scripts/msd-rename.cjs: gsd/Gsd/GSD -> msd/Msd/MSD
across contents and paths, upstream package/repo coordinates -> @golem15/msd-core
and golem15com/msd-core. Deep links into upstream history, sibling upstream
packages, the GSD-2 import feature, CHANGELOG.md and .changeset/ are kept as-is.

Hand edits on top: MSD block-letter banner and logos, LICENSE copyright line,
package/plugin identity, regenerated lockfile, install-tree fixtures, derived
registries and benchmark baseline; migration checksum baseline re-locked
(MSD keeps its own install state, so no install had applied the old sums);
sort-order and regex-escaped expectations in tests adjusted.
2026-10-06 01:47:40 +02:00

68 lines
2.2 KiB
JavaScript

'use strict';
const { describe, test } = require('node:test');
const assert = require('node:assert/strict');
const {
resolveReviewerSelection,
} = require('../msd-core/bin/lib/review-reviewer-selection.cjs');
describe('review default reviewers resolution (#3079)', () => {
test('no flags + config defaults selects configured subset', () => {
const result = resolveReviewerSelection({
detected: ['qwen', 'codex', 'claude'],
explicitFlags: [],
allFlag: false,
configuredDefaultReviewers: ['qwen', 'codex'],
});
assert.strictEqual(result.source, 'config_default');
assert.deepStrictEqual(result.selected, ['codex', 'qwen']);
assert.deepStrictEqual(result.errors, []);
});
test('--all ignores configured defaults', () => {
const result = resolveReviewerSelection({
detected: ['qwen', 'codex', 'claude'],
explicitFlags: [],
allFlag: true,
configuredDefaultReviewers: ['qwen'],
});
assert.strictEqual(result.source, 'all_flag');
assert.deepStrictEqual(result.selected, ['claude', 'codex', 'qwen']);
});
test('explicit flags win over config defaults', () => {
const result = resolveReviewerSelection({
detected: ['qwen', 'codex', 'claude', 'cursor'],
explicitFlags: ['cursor'],
allFlag: false,
configuredDefaultReviewers: ['qwen', 'codex'],
});
assert.strictEqual(result.source, 'explicit_flags');
assert.deepStrictEqual(result.selected, ['cursor']);
});
test('unknown configured slugs warn and all-undetected known slugs error', () => {
const result = resolveReviewerSelection({
detected: ['qwen'],
explicitFlags: [],
allFlag: false,
configuredDefaultReviewers: ['unknown_slug', 'codex'],
});
assert.strictEqual(result.source, 'config_default');
assert.ok(
result.warnings.some((msg) => msg.includes('unknown reviewer slug') && msg.includes('unknown_slug')),
`expected warning for unknown slug, got: ${JSON.stringify(result.warnings)}`
);
assert.ok(
result.errors.some((msg) => msg.includes('all configured default reviewers are unavailable')),
`expected unavailable error, got: ${JSON.stringify(result.errors)}`
);
});
});