msd-core/tests/defaults-json-fallback.test.cjs

/**
 * MSD Tools Tests — ~/.msd/defaults.json fallback (#1683)
 *
 * When .planning/ does not exist (pre-project context), loadConfig() should
 * consult ~/.msd/defaults.json before returning hardcoded defaults.
 * When .planning/ exists but config.json is missing, hardcoded defaults are used.
 */

const { test, describe } = require('node:test');
const assert = require('node:assert/strict');
const fs = require('fs');
const path = require('path');
const os = require('os');
const { cleanup } = require('./helpers.cjs');

const { loadConfig } = require('../msd-core/bin/lib/config-loader.cjs');

/** Create a bare temp dir (no .planning/) to simulate pre-project context */
function createBareTmpDir() {
  return fs.mkdtempSync(path.join(os.tmpdir(), 'msd-test-'));
}

describe('loadConfig ~/.msd/defaults.json fallback (#1683)', () => {
  test('pre-project, no defaults.json → hardcoded defaults', (t) => {
    const tmpDir = createBareTmpDir();
    process.env.MSD_HOME = tmpDir;
    t.after(() => { delete process.env.MSD_HOME; cleanup(tmpDir); });

    const config = loadConfig(tmpDir);
    assert.strictEqual(config.model_profile, 'balanced');
    assert.strictEqual(config.context_window, 200000);
    assert.strictEqual(config.research, true);
    assert.strictEqual(config.subagent_timeout, 300000);
  });

  test('pre-project, defaults.json exists → merges with hardcoded defaults', (t) => {
    const tmpDir = createBareTmpDir();

    // Create ~/.msd/defaults.json under fake MSD_HOME
    const msdDir = path.join(tmpDir, '.msd');
    fs.mkdirSync(msdDir, { recursive: true });
    fs.writeFileSync(
      path.join(msdDir, 'defaults.json'),
      JSON.stringify({ model_profile: 'quality', context_window: 1000000 })
    );

    process.env.MSD_HOME = tmpDir;
    t.after(() => { delete process.env.MSD_HOME; cleanup(tmpDir); });

    const config = loadConfig(tmpDir);
    // Values from defaults.json
    assert.strictEqual(config.model_profile, 'quality');
    assert.strictEqual(config.context_window, 1000000);
    // Hardcoded defaults for keys not in defaults.json
    assert.strictEqual(config.research, true);
    assert.strictEqual(config.subagent_timeout, 300000);
    assert.strictEqual(config.parallelization, true);
  });

  test('.planning/ exists but no config.json → hardcoded defaults (not defaults.json)', (t) => {
    const tmpDir = createBareTmpDir();
    // Create .planning/ without config.json
    fs.mkdirSync(path.join(tmpDir, '.planning'), { recursive: true });

    // Create defaults.json — should NOT be consulted
    const msdDir = path.join(tmpDir, '.msd');
    fs.mkdirSync(msdDir, { recursive: true });
    fs.writeFileSync(
      path.join(msdDir, 'defaults.json'),
      JSON.stringify({ model_profile: 'quality', context_window: 1000000 })
    );

    process.env.MSD_HOME = tmpDir;
    t.after(() => { delete process.env.MSD_HOME; cleanup(tmpDir); });

    const config = loadConfig(tmpDir);
    // Hardcoded defaults — NOT defaults.json values
    assert.strictEqual(config.model_profile, 'balanced');
    assert.strictEqual(config.context_window, 200000);
  });

  test('project config exists → project config wins', (t) => {
    const tmpDir = createBareTmpDir();
    fs.mkdirSync(path.join(tmpDir, '.planning'), { recursive: true });
    fs.writeFileSync(
      path.join(tmpDir, '.planning', 'config.json'),
      JSON.stringify({ model_profile: 'budget' })
    );

    // Also write defaults.json with a different value
    const msdDir = path.join(tmpDir, '.msd');
    fs.mkdirSync(msdDir, { recursive: true });
    fs.writeFileSync(
      path.join(msdDir, 'defaults.json'),
      JSON.stringify({ model_profile: 'quality', context_window: 1000000 })
    );

    process.env.MSD_HOME = tmpDir;
    t.after(() => { delete process.env.MSD_HOME; cleanup(tmpDir); });

    const config = loadConfig(tmpDir);
    assert.strictEqual(config.model_profile, 'budget');
    assert.strictEqual(config.context_window, 200000);
  });

  test('defaults.json with unknown keys → unknown keys NOT passed through', (t) => {
    const tmpDir = createBareTmpDir();

    const msdDir = path.join(tmpDir, '.msd');
    fs.mkdirSync(msdDir, { recursive: true });
    fs.writeFileSync(
      path.join(msdDir, 'defaults.json'),
      JSON.stringify({
        model_profile: 'quality',
        unknown_key: 'should_not_appear',
        another_unknown: 42,
      })
    );

    process.env.MSD_HOME = tmpDir;
    t.after(() => { delete process.env.MSD_HOME; cleanup(tmpDir); });

    const config = loadConfig(tmpDir);
    assert.strictEqual(config.model_profile, 'quality');
    assert.strictEqual(config.unknown_key, undefined);
    assert.strictEqual(config.another_unknown, undefined);
  });

  test('defaults.json with invalid JSON → returns hardcoded defaults', (t) => {
    const tmpDir = createBareTmpDir();

    const msdDir = path.join(tmpDir, '.msd');
    fs.mkdirSync(msdDir, { recursive: true });
    fs.writeFileSync(path.join(msdDir, 'defaults.json'), '{ not valid json !!!');

    process.env.MSD_HOME = tmpDir;
    t.after(() => { delete process.env.MSD_HOME; cleanup(tmpDir); });

    const config = loadConfig(tmpDir);
    assert.strictEqual(config.model_profile, 'balanced');
    assert.strictEqual(config.context_window, 200000);
  });

  // ─── #2069: global-defaults must forward model_policy / model_profile_overrides / runtime ─
  // The _globalBaseCfg whitelist in Branch D of loadConfigResolved previously omitted these
  // three keys, so they were silently dropped from ~/.msd/defaults.json while the identical
  // keys in a project's .planning/config.json were honored. The tests below are fail-first:
  // each asserts the global path forwards its key, mirroring the project-config parity test.

  test('#2069 defaults.json model_policy → forwarded from global defaults', (t) => {
    const tmpDir = createBareTmpDir();
    const policy = { provider: 'anthropic', budget: 'high' };

    const msdDir = path.join(tmpDir, '.msd');
    fs.mkdirSync(msdDir, { recursive: true });
    fs.writeFileSync(
      path.join(msdDir, 'defaults.json'),
      JSON.stringify({ model_policy: policy })
    );

    process.env.MSD_HOME = tmpDir;
    t.after(() => { delete process.env.MSD_HOME; cleanup(tmpDir); });

    const config = loadConfig(tmpDir);
    assert.deepStrictEqual(config.model_policy, policy);
  });

  test('#2069 defaults.json model_profile_overrides → forwarded from global defaults', (t) => {
    const tmpDir = createBareTmpDir();
    const overrides = { claude: { planner: { model: 'claude-opus-4-5' } } };

    const msdDir = path.join(tmpDir, '.msd');
    fs.mkdirSync(msdDir, { recursive: true });
    fs.writeFileSync(
      path.join(msdDir, 'defaults.json'),
      JSON.stringify({ model_profile_overrides: overrides })
    );

    process.env.MSD_HOME = tmpDir;
    t.after(() => { delete process.env.MSD_HOME; cleanup(tmpDir); });

    const config = loadConfig(tmpDir);
    assert.deepStrictEqual(config.model_profile_overrides, overrides);
  });

  test('#2069 defaults.json runtime → forwarded from global defaults', (t) => {
    const tmpDir = createBareTmpDir();
    const runtime = 'codex';

    const msdDir = path.join(tmpDir, '.msd');
    fs.mkdirSync(msdDir, { recursive: true });
    fs.writeFileSync(
      path.join(msdDir, 'defaults.json'),
      JSON.stringify({ runtime })
    );

    process.env.MSD_HOME = tmpDir;
    t.after(() => { delete process.env.MSD_HOME; cleanup(tmpDir); });

    const config = loadConfig(tmpDir);
    assert.strictEqual(config.runtime, runtime);
  });

  test('#2069 defaults.json parity: model_policy / model_profile_overrides / runtime survive identically to project-config path', (t) => {
    // Identical values in ~/.msd/defaults.json (no .planning/) vs .planning/config.json (no defaults.json)
    // must produce identical config.<key> for each of the three previously-dropped keys. A future
    // regression breaking shape-parity for just one key — e.g. changing the project path to
    // `parsed['runtime'] ?? null` — would slip a single-key test, so all three are asserted here.
    const policy = { provider: 'anthropic', budget: 'low' };
    const overrides = { claude: { planner: { model: 'claude-opus-4-5' } } };
    const runtime = 'codex';

    // Global path: ~/.msd/defaults.json only, no .planning/
    const globalDir = createBareTmpDir();
    const globalMsdDir = path.join(globalDir, '.msd');
    fs.mkdirSync(globalMsdDir, { recursive: true });
    fs.writeFileSync(
      path.join(globalMsdDir, 'defaults.json'),
      JSON.stringify({ model_policy: policy, model_profile_overrides: overrides, runtime })
    );

    process.env.MSD_HOME = globalDir;
    const globalConfig = loadConfig(globalDir);
    delete process.env.MSD_HOME;
    t.after(() => { cleanup(globalDir); });

    // Project path: .planning/config.json only, no defaults.json
    const projectDir = createBareTmpDir();
    fs.mkdirSync(path.join(projectDir, '.planning'), { recursive: true });
    fs.writeFileSync(
      path.join(projectDir, '.planning', 'config.json'),
      JSON.stringify({ model_policy: policy, model_profile_overrides: overrides, runtime })
    );

    // MSD_HOME pointing somewhere with no defaults.json so the project path is the sole source.
    const emptyHome = createBareTmpDir();
    process.env.MSD_HOME = emptyHome;
    const projectConfig = loadConfig(projectDir);
    delete process.env.MSD_HOME;
    t.after(() => { cleanup(projectDir); cleanup(emptyHome); });

    assert.deepStrictEqual(globalConfig.model_policy, projectConfig.model_policy);
    assert.deepStrictEqual(globalConfig.model_profile_overrides, projectConfig.model_profile_overrides);
    assert.strictEqual(globalConfig.runtime, projectConfig.runtime);
  });
});