* feat(#3415): ship local/no-unbounded-quantifier, burn down ReDoS class Phase 4 of epic #3212 (ADR-3212 §5/§7, the final phase). New rule flags an unbounded */+/{n,} quantifier over a broad character class ([\s\S], dotAll ., or a 1-2-unit negated class like [^\n]/[^)\n] — the exact #2128-fixed shape) applied to a regex whose match target is data-flow-traced to readFileSync content. eslint-rules/lib/readfilesync-trace.cjs extracts the data-flow tracer shared with no-crlf-fragile-split (Phase 2) rather than a second copy — no-crlf-fragile-split refactored onto it with zero behavior change, parity-tested. Real triage, not 798 mechanical edits: the ADR's census (2026-08-08) screened every unbounded quantifier in the tree unscoped. Correctly scoped to readFileSync-derived content (matching Phase 2's own G2/G3 scoping), the rule found 162 real hits across two detection waves — the second wave (93) surfaced only after a genuine off-by-one bug in this rule's own first draft was caught while writing its RuleTester tests and fixed (the bug silently missed every directly-quantified [\s\S]* with no gap before the quantifier — exactly the class this rule exists to catch). 3 hits landed in production src/ (commands.cts, milestone.cts, roadmap.cts) and were each empirically timed against adversarial input (matching #2128's own measured-not-assumed precedent) — all confirmed linear-time/benign, left unbounded with a measured-evidence comment rather than mechanically bounded. The remaining 159 are test-file fixture parsing (test-author-controlled, fixed-size content, not adversarial input) — each suppressed with a specific, non-generic reason. Zero functional behavior changed anywhere in this diff. tests/no-pending-3212-markers.test.cjs locks the epic's own closing invariant (ADR §7: "assert zero pending #3212 markers remain") — ground truth confirmed trivially true today (no phase left any such marker behind), now regression-locked going forward. Design: .gsd/phase/chore-3415-prohibition-with-teeth/40-design.md Test matrix: .gsd/phase/chore-3415-prohibition-with-teeth/50-test-matrix.md Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * fix(#3415): correct rule category mislabel, add CI test-scope entry An orthogonal Standards-axis review found eslint-rules/no-unbounded-quantifier.cjs mistakenly carried meta.docs.category: 'Portability', copied from a sibling rule without realizing what that implied: docs/contributing/cross-platform- portability-rules.md governs an ADR-1703 rule family under a hard "zero escape hatches" contract (tests/portability-rule-disable-ban.test.cjs's PROTECTED_RULES bans eslint-disable for those rules entirely). This rule is not part of that family — it's ADR-3212 (ReDoS/CWE-1333), a different epic — and its eslint-disable-next-line suppressions (159 of them, added earlier this same phase after empirical benign-verification) are an intentional, correct design, not a bypass. Corrected to category: 'Best Practices', matching the actual precedent (no-adhoc-regex-escape.cjs, Phase 1 of the same epic, which is also correctly outside PROTECTED_RULES), and the rule's own docstring now states this explicitly so a future reader doesn't have to re-derive it. Also registers a new scripts/ci-test-scope.cjs bucket so editing this rule or the shared eslint-rules/lib/readfilesync-trace.cjs helper re-runs their own test suites under targeted CI selection — was previously unregistered and invisible to that fast-path (this PR's own gsd-test checkpoint runs the full suite regardless, so this only affects future narrowly-scoped PRs). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * fix(#3415): bound no-unbounded-quantifier's own scanner (CWE-1333, ironic) Security review found the rule meant to catch algorithmic-complexity bugs had one of its own: hasUnboundedBroadQuantifier's negated-class inner scan walked from each `[^` occurrence to the next `]` (or EOF) with no bound, while the outer loop only ever advanced by one character — O(n²) total work on a pattern with many unclosed `[^` runs. Runs unconditionally inside checkPattern on any `new RegExp('literal string')` argument in any linted file, before the (cheap) readFileSync data-flow gate — so a single crafted string literal, no valid regex syntax required, could make `npm run lint` / CI hang. Empirically confirmed both the bug and the fix: pre-fix, n=4000/8000/ 16000/32000 chars took 30.8/115.6/463.8/1874.3ms (~4x work per 2x n, quadratic); extrapolated, the 300000-char repro from the finding would run ~165s. Post-fix (bail the inner scan once units exceeds the rule's own 1-2-unit scope, rather than continuing to hunt for a closing `]`), the same 300000-char input runs in 8.7ms via the real rule module, independently reconfirmed at 18ms via a fresh Linter.verify() call. New regression row in tests/no-unbounded-quantifier.rule.test.cjs asserts the RuleTester run on a 50000-char adversarial pattern completes and returns a defined result — no wall-clock assertion (CLAUDE.md Clock Seams / local/no-elapsed-assertion). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * fix(#3415): triage 3 new sites, re-raise ceiling after upstream batch next merged 12 more PRs during this PR's review. Two consequences: - tests/edit-phase.test.cjs (fix #3262, unrelated) added 3 new content.match(/<tag>([\s\S]*?)<\/tag>/) reads of this repo's own workflow .md content — the same Class A pattern as the ~159 sites already triaged elsewhere in this PR. Suppressed with the same established reason. - lint-allow-test-rule-refs' ratchet ceiling needed re-raising again (301 -> 303) for the same reason as the two prior bumps: organic growth from unrelated, already-reviewed PRs landing concurrently, not a defect in this branch's own diff. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> --------- Co-authored-by: sim <sim@local> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
89 lines
3.7 KiB
JavaScript
89 lines
3.7 KiB
JavaScript
// allow-test-rule: source-text-is-the-product (see #3149)
|
|
// gsd-core/workflows/debug.md is shipped prompt content: the text IS what the
|
|
// runtime loads, so its Step 0 contract can only be asserted against the text.
|
|
// The behavioral half of this change lives in tests/init-debug.test.cjs, which
|
|
// carries no exemption.
|
|
|
|
'use strict';
|
|
|
|
/**
|
|
* `debug.md` Step 0 contract after the `init.debug` consolidation (#3149).
|
|
*
|
|
* Matrix: `.gsd/phase/feat-3149-cmdinitdebug/50-test-matrix.md` group F.
|
|
*
|
|
* Guards the four ways this consolidation can silently regress:
|
|
* F1/F2 — a replaced round-trip creeping back, or the new one being lost.
|
|
* F3 — reading `config.response_language` (the nested state.load shape)
|
|
* instead of the flat top-level field withProjectRoot injects. This
|
|
* is the #2402 defect class: the workflow silently stays English.
|
|
* F4 — losing the `@file:` unwrap, which large init payloads still need.
|
|
* F5 — dropping the `section_manifest: null` -> read-everything rule,
|
|
* without which a null manifest reads as "read nothing".
|
|
*/
|
|
|
|
const { describe, test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
|
|
const WORKFLOW_PATH = path.join(__dirname, '..', 'gsd-core', 'workflows', 'debug.md');
|
|
const workflow = fs.readFileSync(WORKFLOW_PATH, 'utf-8');
|
|
|
|
/** Every `gsd_run query <name>` invocation in the workflow, in document order. */
|
|
function queryInvocations(text) {
|
|
return [...text.matchAll(/gsd_run query ([\w.-]+)/g)].map((m) => m[1]);
|
|
}
|
|
|
|
describe('debug.md Step 0 init contract (#3149, matrix §F)', () => {
|
|
test('calls init.debug exactly once (row F1)', () => {
|
|
const initDebugCalls = queryInvocations(workflow).filter((q) => q === 'init.debug');
|
|
assert.equal(initDebugCalls.length, 1, 'exactly one init.debug round-trip');
|
|
});
|
|
|
|
test('no longer makes the three replaced calls (row F2)', () => {
|
|
const queries = queryInvocations(workflow);
|
|
|
|
assert.equal(queries.includes('state.load'), false, 'state.load is replaced by init.debug');
|
|
assert.equal(
|
|
workflow.includes('resolve-model gsd-debugger'),
|
|
false,
|
|
'debugger_model now rides the init bundle'
|
|
);
|
|
assert.equal(
|
|
workflow.includes('config-get workflow.tdd_mode'),
|
|
false,
|
|
'tdd_mode now rides the init bundle'
|
|
);
|
|
});
|
|
|
|
test('reads the flat response_language, not the nested state.load shape (row F3)', () => {
|
|
assert.equal(
|
|
workflow.includes('config.response_language'),
|
|
false,
|
|
'withProjectRoot injects response_language at the TOP level; reading config.response_language ' +
|
|
'against an init bundle resolves undefined and silently drops translated output (#2402)'
|
|
);
|
|
assert.ok(
|
|
workflow.includes('`response_language`'),
|
|
'the field is still documented, just at its new location'
|
|
);
|
|
});
|
|
|
|
test('still unwraps an @file: payload (row F4)', () => {
|
|
assert.ok(
|
|
workflow.includes('@file:'),
|
|
'init payloads can spill to a file; dropping the unwrap leaves INIT holding a path, not JSON'
|
|
);
|
|
});
|
|
|
|
test('documents the null-manifest read-everything fallback (row F5)', () => {
|
|
assert.ok(workflow.includes('section_manifest'), 'the field is documented');
|
|
assert.ok(
|
|
// eslint-disable-next-line local/no-unbounded-quantifier -- parses maintainer-authored workflow markdown, bounded prose, not adversarial input
|
|
/`null`[^\r\n]*read this workflow in full/i.test(workflow),
|
|
'a null section_manifest must be documented as "read everything" — without the rule, ' +
|
|
'a null manifest reads as an empty selection and the workflow reads nothing'
|
|
);
|
|
});
|
|
});
|